[GitHub] [qpid-jms] gemmellr commented on pull request #48: Update ExternalMechanism.java to be RFC compliant

[GitBox <gi...@apache.org>]

gemmellr commented on PR #48:
URL: https://github.com/apache/qpid-jms/pull/48#issuecomment-1217833073

   I wouldnt really say its 'not compliant' so much as it simply doenst support requesting to act as a particular non-server-associated identity, like various other clients (and servers) similarly dont support. 
   
   Which server is it you are looking to use that you actually _require_ to pass a client-defined identity for EXTERNAL? I cant say I currently know of any that actually require it. Most I know of even ignore it, since its fairly typical for servers to want to govern the identity they consider the client to be, especially with EXTERNAL. To your question, such reasons are why the Qpid JMS client does not support this, it simply hasnt ever _needed_ to, and there would actually be no point for various servers it has been common to use it with.
   
   Its a notable change in behaviour to simply make it always do this now if the username field happens to be set, given it would have been ignored to this point. Perhaps an option would be needed to toggle the behaviour, though that is fairly ugly so I really dont want such a toggle..I guess I'd skip it for now and assess later.
   
   It would be good if you can outline why you believe you _need_ this currently. If then proceeding you would have to raise a JIRA for the change, squash your commits, update the commit to reference the JIRA (see prior commits), and you also havent included any tests which which would be required. Some of the indentation also looks wrong in the change itself and should be fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org