You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/19 12:53:55 UTC

[GitHub] [arrow] alamb commented on a change in pull request #9262: ARROW-11317: Run tests once in CI (not twice) and include prettyprint feature

alamb commented on a change in pull request #9262:
URL: https://github.com/apache/arrow/pull/9262#discussion_r560155736



##########
File path: .github/workflows/rust.yml
##########
@@ -109,14 +109,14 @@ jobs:
           export CARGO_HOME="/github/home/.cargo"
           export CARGO_TARGET_DIR="/github/home/target"
           cd rust
-          cargo test
+          # run tests on all workspace members
+          cargo test --all --features=prettyprint
           # test datafusion examples
           cd datafusion
           cargo run --example csv_sql
           cargo run --example parquet_sql
           cd ..
           cd arrow
-          cargo test

Review comment:
       this appears to run all the arrow tests twice -- once in the main workspace and once in the arrow crate again. I am not sure that is adding any value




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org