[jira] [Work logged] (HIVE-26385) Iceberg integration: Implement merge into iceberg table

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-26385?focusedWorklogId=789911&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-789911 ]

ASF GitHub Bot logged work on HIVE-26385:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jul/22 07:45
            Start Date: 12/Jul/22 07:45
    Worklog Time Spent: 10m 
      Work Description: kasakrisz opened a new pull request, #3430:
URL: https://github.com/apache/hive/pull/3430

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   1. Extract common parts which collects and appends the sort and delete columns in case of split update and merge.
   2. Merge IcebergWriter data and delete file collections.
   3. Append the number of writers in the job to the operationId to generate a unique file name for each writer.
   
   ### Why are the changes needed?
   1. Implement merge into iceberg table by reusing split update code parts.
   2. A merge with an insert and an update branch has at least two insert IcebergWriters. If the target table is not partitioned no sorting and exchange is required and both FileSink operators wrapping the IcebergWriters are located in the same Reducer and Job.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes. Merge statements should not throw any exceptions when the target is an iceberg table.
   
   ### How was this patch tested?
   ```
   mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestIcebergLlapLocalCliDriver -Dqfile=merge_iceberg_orc.q,merge_iceberg_partitioned_orc.q -pl itests/qtest-iceberg -Piceberg -Pitests
   ```




Issue Time Tracking
-------------------

            Worklog Id:     (was: 789911)
    Remaining Estimate: 0h
            Time Spent: 10m

> Iceberg integration: Implement merge into iceberg table
> -------------------------------------------------------
>
>                 Key: HIVE-26385
>                 URL: https://issues.apache.org/jira/browse/HIVE-26385
>             Project: Hive
>          Issue Type: Improvement
>          Components: File Formats
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>             Fix For: 4.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code}
> create external table target_ice(a int, b string, c int) partitioned by spec (bucket(16, a), truncate(3, b)) stored by iceberg stored as orc tblproperties ('format-version'='2');
> create table source(a int, b string, c int);
> ...
> merge into target_ice as t using source src ON t.a = src.a
> when matched and t.a > 100 THEN DELETE
> when matched then update set b = 'Merged', c = t.c + 10
> when not matched then insert values (src.a, src.b, src.c);
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)