You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/07/09 12:29:21 UTC
[Bug 4471] New: Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
http://bugzilla.spamassassin.org/show_bug.cgi?id=4471
Summary: Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP
configurable
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: spamc/spamd
AssignedTo: dev@spamassassin.apache.org
ReportedBy: maddenj+spamassassin@skynet.ie
Comment in spamc.c svn log for r202163. Patch to follow.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4471] RFE: [review] Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4471
------- Additional Comments From parkerm@pobox.com 2005-07-09 08:19 -------
Subject: Re: Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
>line switches to change them. Switches used were 'T' for reTry (since both r
>and R are already taken) and 'N' for nap (since both s and S are already
>taken).
>
>
Brief look at the patch and it looks ok, however, I would like to wait
for longopt support and use that for these options instead of taking up
a couple more single character options.
Michael
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4471] RFE: [review] Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4471
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
BugsThisDependsOn| |4326
Target Milestone|Undefined |3.2.0
------- Additional Comments From jm@jmason.org 2006-04-21 18:20 -------
aiming at 3.2.0, these should really have gone in by now :(
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4471] RFE: Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4471
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|RFE: [review] Make |RFE: Make
|MAX_CONNECT_RETRIES and |MAX_CONNECT_RETRIES and
|CONNECT_RETRY_SLEEP |CONNECT_RETRY_SLEEP
|configurable |configurable
------- Additional Comments From jm@jmason.org 2006-04-22 13:18 -------
ok, the longopt code is in -- this patch needs to be redone using something like:
usg(" --connect-retries retries\n"
" Try connecting to spamd this many times\n");
usg(" --retry-sleep sleep Sleep for this length between attempts to\n"
" connect to spamd\n");
instead of -F and -N.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4471] RFE: Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4471
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|3.2.0 |3.3.0
------- Additional Comments From jm@jmason.org 2006-12-12 12:40 -------
moving RFEs and low-priority stuff to 3.3.0 target
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4471] RFE: [review] Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4471
------- Additional Comments From maddenj+spamassassin@skynet.ie 2005-07-09 09:26 -------
Subject: Re: RFE: [review] Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On (09/07/05 08:19), bugzilla-daemon@bugzilla.spamassassin.org didst pronounce:
> Brief look at the patch and it looks ok, however, I would like to wait
> for longopt support and use that for these options instead of taking up
> a couple more single character options.
>
That's grand. I think the longopt support I was writing is ready for
inclusion, but I understand it's not tested enough for 3.1.
Would it be an idea to include the code now, without the CLI switches so
that they just need to be added with the longopt patch?
- --
Chat ya later,
John.
- --
BOFH excuse #1: clock speed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCz/rCQBw+ZtKOvTIRAsKFAJ4kUNNYK92HMn55ttowMeqvV6mULwCfbQYo
6uYYggaH7aCiOECfUrSfdw4=
=l88r
-----END PGP SIGNATURE-----
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4471] Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4471
------- Additional Comments From maddenj+spamassassin@skynet.ie 2005-07-09 03:32 -------
Created an attachment (id=3014)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=3014&action=view)
Configurable CONNECT_MAX_RETRIES and CONNECT_RETRY_SLEEP
Added connect_max_retries and connect_retry_sleep to struct transport,
initialised them in transport_init, removed the #define's and added command
line switches to change them. Switches used were 'T' for reTry (since both r
and R are already taken) and 'N' for nap (since both s and S are already
taken).
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4471] RFE: [review] Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4471
Bug 4471 depends on bug 4326, which changed state.
Bug 4326 Summary: RFE : [review] spamc longopt support
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4326
What |Old Value |New Value
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4471] RFE: Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4471
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From jm@jmason.org 2007-01-09 08:46 -------
that wasn't quite ready -- but I fixed it up and applied it anyway ;)
- defaults were changed from 3 retries, 1 sec apart.
- no POD doc.
- no mention of defaults in the usage log
- spamc didn't work unless they were specified ;) (this could have been a
side-effect of breakage from my fix of #1 though)
- indent was a bit icky, using tabs instead of spaces
anyway, now in:
svn commit -m "bug 4471: add --connect-retries and --retry-sleep switches to
spamc, thanks to John Madden <maddenj+spamassassin at skynet.ie>"
Sending spamc/libspamc.c
Sending spamc/libspamc.h
Sending spamc/spamc.c
Sending spamc/spamc.pod
Transmitting file data ....
Committed revision 494481.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4471] RFE: Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=4471
maddenj+spamassassin@skynet.ie changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3014 is|0 |1
obsolete| |
------- Additional Comments From maddenj+spamassassin@skynet.ie 2007-01-09 08:22 -------
Created an attachment (id=3820)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3820&action=view)
Configurable with longopts
Added these new options as longopts.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4471] RFE: [review] Make MAX_CONNECT_RETRIES and CONNECT_RETRY_SLEEP configurable
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4471
maddenj+spamassassin@skynet.ie changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Make MAX_CONNECT_RETRIES and|RFE: [review] Make
|CONNECT_RETRY_SLEEP |MAX_CONNECT_RETRIES and
|configurable |CONNECT_RETRY_SLEEP
| |configurable
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.