You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/06 17:01:45 UTC
[GitHub] [yunikorn-k8shim] pbacsko opened a new pull request, #499: [YUNIKORN-1404] e2e: don't delete individual pods when jobs are submitted
pbacsko opened a new pull request, #499:
URL: https://github.com/apache/yunikorn-k8shim/pull/499
### What is this PR for?
Don't just clean up individual pods when jobs are submitted, instead, delete the job then delete any pods in the namespace which are still there. This ensure proper cleanup.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1404
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #499: [YUNIKORN-1404] e2e: don't delete individual pods when jobs are submitted
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #499:
URL: https://github.com/apache/yunikorn-k8shim/pull/499#issuecomment-1339706677
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#499](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a333289) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/1ff14f1b8960d579e45bbff7e39e13a8c3594c5f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ff14f1) will **increase** coverage by `0.92%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 66.67% 67.60% +0.92%
==========================================
Files 43 42 -1
Lines 7563 7463 -100
==========================================
+ Hits 5043 5045 +2
+ Misses 2332 2230 -102
Partials 188 188
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...in/admissioncontrollers/webhook/metadata/labels.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL21ldGFkYXRhL2xhYmVscy5nbw==) | | |
| [...admissioncontrollers/webhook/metadata/usergroup.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL21ldGFkYXRhL3VzZXJncm91cC5nbw==) | | |
| [pkg/plugin/admissioncontrollers/webhook/webhook.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL3dlYmhvb2suZ28=) | | |
| [...in/admissioncontrollers/webhook/webhook\_manager.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL3dlYmhvb2tfbWFuYWdlci5nbw==) | | |
| [...lugin/admissioncontrollers/webhook/conf/am\_conf.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2NvbmYvYW1fY29uZi5nbw==) | | |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | | |
| [...n/admissioncontrollers/webhook/metadata/extract.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL21ldGFkYXRhL2V4dHJhY3QuZ28=) | | |
| [pkg/admission/conf/am\_conf.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkbWlzc2lvbi9jb25mL2FtX2NvbmYuZ28=) | `61.47% <0.00%> (ø)` | |
| [pkg/admission/metadata/usergroup.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkbWlzc2lvbi9tZXRhZGF0YS91c2VyZ3JvdXAuZ28=) | `78.65% <0.00%> (ø)` | |
| [pkg/admission/metadata/extract.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkbWlzc2lvbi9tZXRhZGF0YS9leHRyYWN0Lmdv) | `100.00% <0.00%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/yunikorn-k8shim/pull/499/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] manirajv06 commented on pull request #499: [YUNIKORN-1404] e2e: don't delete individual pods when jobs are submitted
Posted by GitBox <gi...@apache.org>.
manirajv06 commented on PR #499:
URL: https://github.com/apache/yunikorn-k8shim/pull/499#issuecomment-1352676721
@pbacsko Changes looks good. Are you planning to add any more changes? If not, Can you check the test failures and take this forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #499: [YUNIKORN-1404] e2e: don't delete individual pods when jobs are submitted
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #499: [YUNIKORN-1404] e2e: don't delete individual pods when jobs are submitted
URL: https://github.com/apache/yunikorn-k8shim/pull/499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] pbacsko commented on pull request #499: [YUNIKORN-1404] e2e: don't delete individual pods when jobs are submitted
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko commented on PR #499:
URL: https://github.com/apache/yunikorn-k8shim/pull/499#issuecomment-1460937865
Update: new PR contains some refactor & simplifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] pbacsko commented on pull request #499: [YUNIKORN-1404] e2e: don't delete individual pods when jobs are submitted
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko commented on PR #499:
URL: https://github.com/apache/yunikorn-k8shim/pull/499#issuecomment-1492069260
@manirajv06 fixed all issues, pls review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org