You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ryan-williams <gi...@git.apache.org> on 2015/01/27 04:34:56 UTC
[GitHub] spark pull request: [SPARK-5422] Add support for sending Graphite ...
GitHub user ryan-williams opened a pull request:
https://github.com/apache/spark/pull/4218
[SPARK-5422] Add support for sending Graphite metrics via UDP
Depends on [SPARK-5413](https://issues.apache.org/jira/browse/SPARK-5413) / #4209, included here, will rebase once the latter's merged.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ryan-williams/spark udp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4218.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4218
----
commit cb582623170294311a6880d8a178c712fbaf0b6c
Author: Ryan Williams <ry...@gmail.com>
Date: 2015-01-26T21:50:55Z
bump metrics dependency to v3.1.0
pick up batching of TCP requests to graphite, among other things
commit ebae39347ab3d187bb5eef943882b6bb4c385113
Author: Ryan Williams <ry...@gmail.com>
Date: 2015-01-27T03:25:19Z
Add support for sending Graphite metrics via UDP
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5422] Add support for sending Graphite ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4218#issuecomment-71584864
[Test build #26142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26142/consoleFull) for PR 4218 at commit [`ebae393`](https://github.com/apache/spark/commit/ebae39347ab3d187bb5eef943882b6bb4c385113).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5422] Add support for sending Graphite ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4218#issuecomment-71589336
[Test build #26142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26142/consoleFull) for PR 4218 at commit [`ebae393`](https://github.com/apache/spark/commit/ebae39347ab3d187bb5eef943882b6bb4c385113).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5422] Add support for sending Graphite ...
Posted by hammer <gi...@git.apache.org>.
Github user hammer commented on the pull request:
https://github.com/apache/spark/pull/4218#issuecomment-72352426
@pwendell @rxin we'd love to get this patch into 1.3 to improve the scalability of metrics collection. it's a pretty straightforward patch. Could you guys give it some Databricks love this week? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5422] Add support for sending Graphite ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4218#issuecomment-71589339
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26142/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5422] Add support for sending Graphite ...
Posted by hammer <gi...@git.apache.org>.
Github user hammer commented on the pull request:
https://github.com/apache/spark/pull/4218#issuecomment-72355732
Awesome thanks @rxin!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5422] Add support for sending Graphite ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5422] Add support for sending Graphite ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4218#issuecomment-72355227
Merging in master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org