You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "drpmma (via GitHub)" <gi...@apache.org> on 2023/05/06 03:12:21 UTC
[GitHub] [rocketmq] drpmma opened a new pull request, #6697: [ISSUE #6696] Refector proxy common and client module
drpmma opened a new pull request, #6697:
URL: https://github.com/apache/rocketmq/pull/6697
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #6696
### Brief Description
1. Move `StartAndShutdown` and its related classes from the `proxy.common` to the `common` module
2. Move `MQClientAPIExt` from the `proxy` module to the `client` module
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
Module relocation, no need for function test.
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] drpmma merged pull request #6697: [ISSUE #6696] Refector proxy common and client module
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma merged PR #6697:
URL: https://github.com/apache/rocketmq/pull/6697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6697: [ISSUE #6696] Refector proxy common and client module
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6697:
URL: https://github.com/apache/rocketmq/pull/6697#issuecomment-1537033818
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6697](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f03eb8) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/6f6032e9eb812d42a67bea3cdb02cf4ef6e7f6c3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6f6032e) will **decrease** coverage by `0.20%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## develop #6697 +/- ##
=============================================
- Coverage 43.05% 42.85% -0.20%
+ Complexity 9024 8992 -32
=============================================
Files 1109 1110 +1
Lines 78615 78643 +28
Branches 10232 10233 +1
=============================================
- Hits 33845 33703 -142
- Misses 40532 40722 +190
+ Partials 4238 4218 -20
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rocketmq/client/common/NameserverAccessConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29tbW9uL05hbWVzZXJ2ZXJBY2Nlc3NDb25maWcuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...mpl/mqclient/DoNothingClientRemotingProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9tcWNsaWVudC9Eb05vdGhpbmdDbGllbnRSZW1vdGluZ1Byb2Nlc3Nvci5qYXZh) | `0.00% <ø> (ø)` | |
| [.../rocketmq/client/impl/mqclient/MQClientAPIExt.java](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9tcWNsaWVudC9NUUNsaWVudEFQSUV4dC5qYXZh) | `0.00% <ø> (ø)` | |
| [...ketmq/client/impl/mqclient/MQClientAPIFactory.java](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9tcWNsaWVudC9NUUNsaWVudEFQSUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ocketmq/common/utils/AbstractStartAndShutdown.java](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvQWJzdHJhY3RTdGFydEFuZFNodXRkb3duLmphdmE=) | `0.00% <ø> (ø)` | |
| [...apache/rocketmq/common/utils/StartAndShutdown.java](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvU3RhcnRBbmRTaHV0ZG93bi5qYXZh) | `0.00% <ø> (ø)` | |
| [...n/java/org/apache/rocketmq/proxy/ProxyStartup.java](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L1Byb3h5U3RhcnR1cC5qYXZh) | `44.82% <ø> (ø)` | |
| [...ava/org/apache/rocketmq/proxy/grpc/GrpcServer.java](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvR3JwY1NlcnZlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...etmq/proxy/grpc/v2/DefaultGrpcMessingActivity.java](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvdjIvRGVmYXVsdEdycGNNZXNzaW5nQWN0aXZpdHkuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...cketmq/proxy/grpc/v2/GrpcMessagingApplication.java](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvdjIvR3JwY01lc3NhZ2luZ0FwcGxpY2F0aW9uLmphdmE=) | `38.91% <ø> (ø)` | |
| ... and [24 more](https://app.codecov.io/gh/apache/rocketmq/pull/6697?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [19 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6697/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org