[GitHub] [solr] gerlowskija commented on pull request #1738: SOLR-15753: Ensure v2 API requests are logged

["gerlowskija (via GitHub)" <gi...@apache.org>]

gerlowskija commented on PR #1738:
URL: https://github.com/apache/solr/pull/1738#issuecomment-1614825404

   > I am so thankful you are a wizard with the Jersey stuff
   
   Haha, thanks - but I swear I'm just one or two frantic google-searches ahead of everyone else haha!
   
   > would it be possible to log the body of the request as well?
   
   I definitely want to log out the body of POST and PUT requests, but I'm still figuring out how to make that work.
   
   The main hurdle is that Jersey filters have access to the request body as an InputStream, but since the logging filter in this PR is a "response filter" that runs _after_ the API method, that InputStream has already been consumed and is mostly useless.  The workaround for this is to have something cache whatever POJO the request body is deserialized into, so that it's accessible by the logging filter, but I haven't found a non-hacky way to do that yet.
   
   That's the main issue, though there are a few others (e.g. do we want to try to extend `logParamsList` in some way to cover potentially nested request bodies?). So unless you think we really should include it here, I was probably gonna work on request-body logging in a separate PR (but the same JIRA).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org