You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/06/01 13:05:13 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new issue #5898: TC Cache Config RPM does not depend on `git` and `perl` unless built on RHEL 6, 7, or 8
zrhoffman opened a new issue #5898:
URL: https://github.com/apache/trafficcontrol/issues/5898
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the #traffic-control channel on the ASF slack (https://s.apache.org/slack-invite)
or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
-->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- bug report
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- Traffic Control Cache Config (`t3c`) RPM spec file
## Current behavior:
<!-- Describe how the bug manifests -->
Unless the RPM build distribution is RHEL 6, RHEL 7, or RHEL 8, an RPM from [`trafficcontrol-cache-config.spec`](https://github.com/apache/trafficcontrol/blob/60a9ffdcab/cache-config/build/trafficcontrol-cache-config.spec) will have no dependencies.
## Expected behavior:
<!-- Describe what the behavior would be without the bug -->
`trafficcontrol-cache-config` should depend on `git` and `perl`:
https://github.com/apache/trafficcontrol/blob/f126954b4f8753ffa2be9006f996a2a971484a9a/cache-config/build/trafficcontrol-cache-config.spec#L29-L31
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug, please provide the *STEPS TO REPRODUCE* and
include the applicable TC version.
-->
1. Go through the steps to [build the ATC RPMs natively](https://traffic-control-cdn.readthedocs.io/en/latest/development/building.html#build-the-rpms-natively)
2. Build the TC Cache Config RPM outside of Docker, assuming you are not on CentOS 6, CentOS 7, or CentOS 8:
```shell
cd infrastructure/cdn-in-a-box
make native cache/trafficcontrol-cache-config.rpm
rpm -q --requires cache/trafficcontrol-cache-config.rpm
```
Output of `rpm -q --requires cache/trafficcontrol-cache-config.rpm` that reproduces the bug:
```
/bin/sh
/bin/sh
/usr/bin/perl
config(trafficcontrol-cache-config) = 6.0.0-11401.60a9ffdc.el8
perl(Getopt::Long)
perl(strict)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
```
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on issue #5898: TC Cache Config RPM does not depend on `git` and `perl` unless built on RHEL 6, 7, or 8
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #5898:
URL: https://github.com/apache/trafficcontrol/issues/5898#issuecomment-852199337
That's just a result of `rpmbuild` detecting a script with a Perl shebang. We should still explicitly require the dependency until the Perl script is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp closed issue #5898: TC Cache Config RPM does not depend on `git` and `perl` unless built on RHEL 6, 7, or 8
Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #5898:
URL: https://github.com/apache/trafficcontrol/issues/5898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on issue #5898: TC Cache Config RPM does not depend on `git` and `perl` unless built on RHEL 6, 7, or 8
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #5898:
URL: https://github.com/apache/trafficcontrol/issues/5898#issuecomment-852179891
based on the reproduction instructions' output, it does look like the RPM depends on a Perl interpreter at `/usr/bin/perl` as well as packages which themselves depend on Perl e.g. `perl(strict)` - do those really not result in an implicit dependency on Perl?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org