[jira] [Commented] (ISIS-1060) An exception is logged when the provided credentials are invalid

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14373050#comment-14373050 ] 

ASF subversion and git services commented on ISIS-1060:
-------------------------------------------------------

Commit 63d26a7b23672066f9595d6fe5ae3a6854feb951 in isis's branch refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=63d26a7 ]

ISIS-1060 An exception is logged when the provided credentials are invalid


> An exception is logged when the provided credentials are invalid
> ----------------------------------------------------------------
>
>                 Key: ISIS-1060
>                 URL: https://issues.apache.org/jira/browse/ISIS-1060
>             Project: Isis
>          Issue Type: Wish
>          Components: Core
>    Affects Versions: core-1.8.0
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>
> If trying to authenticate with wrong credentials Isis Shiro integration logs an ERROR with its complete stacktrace.
> This is not an error in the application so I think it should be logged with lower level, e.g. WARN (but even WARN looks too much to me for this normal use case).
> The second change that I'd recommend is to not dump the stacktrace.
> Instead of:
>   LOG.error("Unable to authenticate", ae);
> do:
>   LOG.error("Unable to authenticate. Reason: " + ae.getMessage());



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)