You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/10/17 07:33:51 UTC
[GitHub] [maven-dependency-plugin] slawekjaranowski opened a new pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
slawekjaranowski opened a new pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169
By default pom and ear packaging are ignored from analyzing.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169#issuecomment-968247190
When we have default value, like:
```
@Parameter( defaultValue = "pom,ear" )
private List<String> ignoredPackagings = new ArrayList<>();
```
In maven `3.2.5` this default value is used always and win with configuration for collection in pom.
fixed to:
```
@Parameter
private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a change in pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169#discussion_r748863820
##########
File path: src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
##########
@@ -222,6 +222,18 @@
@Parameter
private String[] ignoredUnusedDeclaredDependencies = new String[0];
+ /**
+ * List of project packaging that will be ignored.
+ *
+ * <p>
+ * by default <b>pom</b> and <b>ear</b> are ignored.
+ * </p>
+ *
+ * @since 3.2.1
+ */
+ @Parameter
+ private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
Review comment:
Now look like standard defaults
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a change in pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169#discussion_r748837146
##########
File path: src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
##########
@@ -222,6 +222,18 @@
@Parameter
private String[] ignoredUnusedDeclaredDependencies = new String[0];
+ /**
+ * List of project packaging that will be ignored.
+ *
+ * <p>
+ * by default <b>pom</b> and <b>ear</b> are ignored.
+ * </p>
+ *
+ * @since 3.2.1
+ */
+ @Parameter
+ private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
Review comment:
- dock will be fixed.
- Maven 3.2.5 is used on ASF jenkins ... so we need workaround ...
- I prefer add new package with new issue and new PR - I don't want to change scope of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169#issuecomment-968252892
@slachiewicz please try again on jenkins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] pzygielo commented on pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169#issuecomment-968255529
> When we have default value, like:
>
> ```
> @Parameter( defaultValue = "pom,ear" )
> private List<String> ignoredPackagings = new ArrayList<>();
> ```
>
> In maven `3.2.5` this default value is used always and win with configuration for collection in pom.
>
> fixed to:
>
> ```
> @Parameter
> private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
> ```
But `defaultValue` finds its way into documentation, in standard way. With above (fixed to) approach I would definitely have missed that one sentence of description, when looking for defaults only. And maven 3.2.5 looks like very, very old version to support its bugs here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] pzygielo commented on a change in pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169#discussion_r748826986
##########
File path: src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
##########
@@ -222,6 +222,18 @@
@Parameter
private String[] ignoredUnusedDeclaredDependencies = new String[0];
+ /**
+ * List of project packaging that will be ignored.
+ *
+ * <p>
+ * by default <b>pom</b> and <b>ear</b> are ignored.
+ * </p>
+ *
+ * @since 3.2.1
+ */
+ @Parameter
+ private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
Review comment:
I'd also like to see `rar` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] pzygielo edited a comment on pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
pzygielo edited a comment on pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169#issuecomment-968255529
> When we have default value, like:
>
> ```
> @Parameter( defaultValue = "pom,ear" )
> private List<String> ignoredPackagings = new ArrayList<>();
> ```
>
> In maven `3.2.5` this default value is used always and win with configuration for collection in pom.
>
> fixed to:
>
> ```
> @Parameter
> private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
> ```
But `defaultValue` finds its way into documentation, in standard way. With above (fixed to) approach I would definitely have missed that one sentence of description, when looking for defaults only. And maven 3.2.5 looks like very, very old version to support its bugs here.
Also the doc formatting is a bit off now (at least sentence could start with capital) :
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] pzygielo commented on a change in pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169#discussion_r748837756
##########
File path: src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
##########
@@ -222,6 +222,18 @@
@Parameter
private String[] ignoredUnusedDeclaredDependencies = new String[0];
+ /**
+ * List of project packaging that will be ignored.
+ *
+ * <p>
+ * by default <b>pom</b> and <b>ear</b> are ignored.
+ * </p>
+ *
+ * @since 3.2.1
+ */
+ @Parameter
+ private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
Review comment:
> * Maven 3.2.5 is used on ASF jenkins ... so we need workaround ...
:disappointed:
> * I prefer add new package with new issue and new PR - I don't want to change scope of this
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a change in pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169#discussion_r748837146
##########
File path: src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java
##########
@@ -222,6 +222,18 @@
@Parameter
private String[] ignoredUnusedDeclaredDependencies = new String[0];
+ /**
+ * List of project packaging that will be ignored.
+ *
+ * <p>
+ * by default <b>pom</b> and <b>ear</b> are ignored.
+ * </p>
+ *
+ * @since 3.2.1
+ */
+ @Parameter
+ private List<String> ignoredPackagings = Arrays.asList( "pom", "ear" );
Review comment:
- docs will be fixed.
- Maven 3.2.5 is used on ASF jenkins ... so we need workaround ...
- I prefer add new package with new issue and new PR - I don't want to change scope of this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169#issuecomment-969075384
@slachiewicz please refresh branch for jenkins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slachiewicz closed pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
slachiewicz closed pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-plugin] slachiewicz commented on pull request #169: [MDEP-752] Add ignoredPackagings options for analyze
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #169:
URL: https://github.com/apache/maven-dependency-plugin/pull/169#issuecomment-968167425
Our builds for Maven 3.2 fails https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dependency-plugin/job/MDEP-752/
can You check it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org