You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sean Mickey (JIRA)" <ji...@apache.org> on 2010/06/30 02:33:50 UTC

[jira] Updated: (LANG-411) HashCodeBuilder: expose typed hashing methods

     [ https://issues.apache.org/jira/browse/LANG-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Mickey updated LANG-411:
-----------------------------

    Attachment: ObjectUtils-Patch-Addresses-LANG-411-and-LANG-627.txt
                ObjectUtilsTest-Patch-Adds-Tests-For-Changes-To-Address-LANG-411-and-LANG-627.txt

I have created a patch to ObjectUtils that addresses LANG-411 and LANG-627. It is attached for review.

I have also created a corresponding patch to ObjectUtilsTest that unit tests the functionality added in the ObjectUtils patch. It is also attached for review.

I chose this simple set of changes because it lets me get my feet wet with something simple and straightforward, but that is also a fair amount of work so that it alleviates the load on some of the old hands.

I hope this is helpful and I look forward to all feedback. Thanks~

> HashCodeBuilder: expose typed hashing methods
> ---------------------------------------------
>
>                 Key: LANG-411
>                 URL: https://issues.apache.org/jira/browse/LANG-411
>             Project: Commons Lang
>          Issue Type: Wish
>          Components: lang.builder.*
>    Affects Versions: 2.3
>            Reporter: Paul Benedict
>            Priority: Minor
>             Fix For: 3.1
>
>         Attachments: ObjectUtils-Patch-Addresses-LANG-411-and-LANG-627.txt, ObjectUtilsTest-Patch-Adds-Tests-For-Changes-To-Address-LANG-411-and-LANG-627.txt
>
>
> HashCodeBuilder encapsulates the good advice of Joshua Bloch. He details how each java.lang type should be hashed. I want to use those too ... but without reflection. Please expose those as static methods:
> hashInt, hashBoolean, etc.
> They should take two parameters: the field value, and the hash multiplier value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.