[GitHub] [flink] bowenli86 commented on a change in pull request #10296: [FLINK-14691][table]Add use/create/drop/alter database operation and support it in flink/blink planner

[GitBox <gi...@apache.org>]

bowenli86 commented on a change in pull request #10296: [FLINK-14691][table]Add use/create/drop/alter database operation and support it in flink/blink planner
URL: https://github.com/apache/flink/pull/10296#discussion_r350379232
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java
 ##########
 @@ -455,6 +457,93 @@ public void createTable(CatalogBaseTable table, ObjectIdentifier objectIdentifie
 			"CreateTable");
 	}
 
+	/**
+	 * Creates a database in a given fully qualified path.
+	 *
+	 * @param catalogName The catalog where database will be created.S
+	 * @param databaseName Name of database to be created.
+	 * @param database The database to be created.
+	 * @param ignoreIfExists If false exception will be thrown if a database exists in the given path.
+	 */
+	public void createDatabase(String catalogName,
 
 Review comment:
   Database should not be created via catalog manager. We should get the catalog first, and just call catalog APIs for db creation. Otherwise, we are basically copying all catalog APIs to catalog manager

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services