[GitHub] [arrow] lidavidm commented on pull request #13037: ARROW-16425: [C++] Add compute kernel test for scalar array timestamp comparison

[GitBox <gi...@apache.org>]

lidavidm commented on PR #13037:
URL: https://github.com/apache/arrow/pull/13037#issuecomment-1117562953

   Thanks, looks like the formatter is pointing out that the declarations need to be separated:
   
   ```diff
   --- /arrow/cpp/src/arrow/compute/kernels/scalar_compare_test.cc
   +++ /arrow/cpp/src/arrow/compute/kernels/scalar_compare_test.cc (after clang format)
   @@ -520,7 +520,7 @@
        for (const auto& array_case :
             std::vector<ArrayCase>{{scalar_side, array_side, expected},
                                    {array_side, scalar_side, flip_expected}}) {
   -      const auto& lhs = array_case.side1, rhs = array_case.side2;
   +      const auto &lhs = array_case.side1, rhs = array_case.side2;
          if (scalar_type->Equals(array_type)) {
            ASSERT_OK_AND_ASSIGN(Datum result,
                                 CallFunction(CompareOperatorToFunctionName(op), {lhs, rhs}));
   @@ -544,7 +544,7 @@
                 {timestamp(unit, "utc"), timestamp(unit)},
                 {timestamp(unit, "utc"), timestamp(unit, "utc")},
             }) {
   -      const auto& t0 = types.first, t1 = types.second;
   +      const auto &t0 = types.first, t1 = types.second;
          CheckArrayCase(t0, t1, CompareOperator::EQUAL, "[true, false, null, false]",
                         "[true, false, null, false]");
          CheckArrayCase(t0, t1, CompareOperator::NOT_EQUAL, "[false, true, null, true]",
   /arrow/cpp/src/arrow/compute/kernels/scalar_compare_test.cc had clang-format style issues
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org