You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/04 16:07:44 UTC
[GitHub] [airflow] josh-fell opened a new pull request #21330: Update test connection functionality to use custom form fields
josh-fell opened a new pull request #21330:
URL: https://github.com/apache/airflow/pull/21330
Closes: #21188
| Before | After |
| -------- | ------- |
|  |  |
When testing, if the `Extra` field is not a valid JSON, an error message is displayed to the user to help provide some direction. (The simple JSON parsing check doesn't _definitively_ check whether the value is valid JSON but the edge cases like `true`, `{false}`, `1`, etc. would be effectively useless for the connection anyway. Thinking it was better to provide some feedback to users was valuable here especially for syntax errors of manually inputting a JSON object.)
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21330: Update test connection functionality to use custom form fields
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21330:
URL: https://github.com/apache/airflow/pull/21330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21330: Update test connection functionality to use custom form fields
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21330:
URL: https://github.com/apache/airflow/pull/21330#issuecomment-1040669122
Just the docker-compose timout problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #21330: Update test connection functionality to use custom form fields
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #21330:
URL: https://github.com/apache/airflow/pull/21330#issuecomment-1040970040
I'm going to kick this to 2.3.0 because of the number of other changes that have happened to connection testing since 2.2.x forked off. We can always reevaluate for 2.2.5 (if there is one) if we think this would work on its own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21330: Update test connection functionality to use custom form fields
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21330:
URL: https://github.com/apache/airflow/pull/21330#issuecomment-1030173803
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi closed pull request #21330: Update test connection functionality to use custom form fields
Posted by GitBox <gi...@apache.org>.
bbovenzi closed pull request #21330:
URL: https://github.com/apache/airflow/pull/21330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org