You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/24 18:02:56 UTC
[GitHub] [nifi] chihhanyu opened a new pull request, #5135: NIFI-8611: GCP BigQuery processors support using designate project resource for ingestion
chihhanyu opened a new pull request, #5135:
URL: https://github.com/apache/nifi/pull/5135
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
Please refer to JIRA ticket for details:
https://issues.apache.org/jira/browse/NIFI-8611
This change is already used in our production environment which can properly support using different source project and ingestion project in the property of GCP processors.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bejancsaba commented on pull request #5135: NIFI-8611: GCP BigQuery processors support using designate project resource for ingestion
Posted by GitBox <gi...@apache.org>.
bejancsaba commented on PR #5135:
URL: https://github.com/apache/nifi/pull/5135#issuecomment-1290751704
@chihhanyu I wanted to highlight that in the mean time as I see there was some refactor around projectId (the code was extracted to abstract class so that is why there are conflicts I think) also these processors were marked as deprecated (still fully functional) in favour of the new BigQuery processor targeting the new Write API: https://github.com/apache/nifi/pull/6344
If you resolve your conflicts I can take a look regarding applying this change to the new processor as well or feel free to change that as well the properties should be fairly similar to the old ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #5135: NIFI-8611: GCP BigQuery processors support using designate project resource for ingestion
Posted by GitBox <gi...@apache.org>.
joewitt commented on PR #5135:
URL: https://github.com/apache/nifi/pull/5135#issuecomment-1289396457
@chihhanyu I apologize. I completely dropped this ball and didn't see your notes. You did the right things. If you are still interested in this please re-submit the PR. Actually I'll re-open this one but i'm guessing rebasing is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] chihhanyu commented on pull request #5135: NIFI-8611: GCP BigQuery processors support using designate project resource for ingestion
Posted by GitBox <gi...@apache.org>.
chihhanyu commented on PR #5135:
URL: https://github.com/apache/nifi/pull/5135#issuecomment-1290626362
> @chihhanyu I apologize. I completely dropped this ball and didn't see your notes. You did the right things. If you are still interested in this please re-submit the PR. Actually I'll re-open this one but i'm guessing rebasing is needed
@joewitt
Thanks for the reply!
I'll rebase to the latest version in these days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] closed pull request #5135: NIFI-8611: GCP BigQuery processors support using designate project resource for ingestion
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5135: NIFI-8611: GCP BigQuery processors support using designate project resource for ingestion
URL: https://github.com/apache/nifi/pull/5135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] chihhanyu commented on pull request #5135: NIFI-8611: GCP BigQuery processors support using designate project resource for ingestion
Posted by GitBox <gi...@apache.org>.
chihhanyu commented on PR #5135:
URL: https://github.com/apache/nifi/pull/5135#issuecomment-1296097961
@bejancsaba Thanks for the info! It's really great to see the new processor adating new Write API and handle batch and streaming in one place.
It seems to me that deprecated processors should be phased out slowly, and finally replaced by a new version.
Let me fix the conflict first and see if I can apply the change for new PutBigQuery processor as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bejancsaba commented on pull request #5135: NIFI-8611: GCP BigQuery processors support using designate project resource for ingestion
Posted by GitBox <gi...@apache.org>.
bejancsaba commented on PR #5135:
URL: https://github.com/apache/nifi/pull/5135#issuecomment-1296235669
> It seems to me that deprecated processors should be phased out slowly, and finally replaced by a new version. Let me fix the conflict first and see if I can apply the change for new PutBigQuery processor as well.
@chihhanyu Thanks for looking into this. I agree the old processors should be slowly phased out. For now they got the deprecation notation so hopefully new adopters will naturally move to the new processor. There is one thing I wanted to highlight. For the new processor the Proxy Configuration Service property / functionality is not yet available. As that needs to be addressed on gRPC level it will be covered as part of a follow up ticket: https://issues.apache.org/jira/browse/NIFI-10707 Not sure whether it affects your use case or not just wanted to highlight it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] github-actions[bot] commented on pull request #5135: NIFI-8611: GCP BigQuery processors support using designate project resource for ingestion
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5135:
URL: https://github.com/apache/nifi/pull/5135#issuecomment-1447325477
Automated review is marking this PR as stale due to lack of updates in the past four months. This PR will be closed in 15 days if the stale label is not removed. This stale label and automated closure does not indicate a judgement of the PR, just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale label. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org