[jira] [Commented] (REEF-579) Nuspec and build.prop files should be checked out as CRLF from git

["Brian Cho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679466#comment-14679466 ] 

Brian Cho commented on REEF-579:
--------------------------------

I believe (b) is the way to go. I tried applying (a) locally _(listed below)_, and there are still multiple files in /lang/cs that are not checked out as CRLF (because they don't match in the root .gitattributes).

I'll go with (b), but please make an objection if this doesn't seem right. 

Also, please let me know if there are any files listed below that should definitely NOT be CRLF. It appears *.snk should be marked binary.

{noformat}
Brians-MacBook-Pro:cs bcho$ grep -L -R "\r" *
Org.Apache.REEF.Bridge/Org.Apache.REEF.Bridge.vcxproj
Org.Apache.REEF.Bridge/Org.Apache.REEF.Bridge.vcxproj.filters
Org.Apache.REEF.Bridge/ReadMe.txt
Org.Apache.REEF.Client/packages.config
Org.Apache.REEF.Client/Properties/Resources.xml
Org.Apache.REEF.Common/packages.config
Org.Apache.REEF.Common/Protobuf/Proto/client_runtime.proto
Org.Apache.REEF.Common/Protobuf/Proto/driver_runtime.proto
Org.Apache.REEF.Common/Protobuf/Proto/evaluator_runtime.proto
Org.Apache.REEF.Common/Protobuf/Proto/reef_protocol.proto
Org.Apache.REEF.Common/Protobuf/Proto/reef_service_protos.proto
Org.Apache.REEF.Driver/packages.config
Org.Apache.REEF.Evaluator/NugetExeFix.txt
Org.Apache.REEF.Evaluator/packages.config
Org.Apache.REEF.Examples/ConfigFiles/evaluator.conf
Org.Apache.REEF.Examples.AllHandlers/Readme.md
Org.Apache.REEF.Examples.HelloREEF/App.config
Org.Apache.REEF.Examples.HelloREEF/Readme.md
Org.Apache.REEF.Network/packages.config
Org.Apache.REEF.Network.Tests/packages.config
Org.Apache.REEF.Tang/packages.config
Org.Apache.REEF.Tang.Tests/packages.config
Org.Apache.REEF.Tests/app.config
Org.Apache.REEF.Tests/packages.config
Org.Apache.REEF.Utilities/packages.config
Org.Apache.REEF.Wake/packages.config
Org.Apache.REEF.Wake/Remote/Proto/RemoteProtocol.proto
Org.Apache.REEF.Wake.Tests/packages.config
keyfile.snk
pom.xml
publickey.snk
{noformat}

> Nuspec and build.prop files should be checked out as CRLF from git
> ------------------------------------------------------------------
>
>                 Key: REEF-579
>                 URL: https://issues.apache.org/jira/browse/REEF-579
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF.NET
>            Reporter: Brian Cho
>            Assignee: Brian Cho
>
> All .NET files should remain CRLF even when checked out with *nix. Currently nuspec and build.prop files are not.
> We could either (a) add these path strings to the root .gitattributes or (b) add separate .gitattributes per lang directory. (a) is a quicker fix, while (b) might be better for long-term maintenance, when yet more file extensions are added to the repo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)