You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "RapperCL (via GitHub)" <gi...@apache.org> on 2023/09/06 16:06:30 UTC
[GitHub] [rocketmq] RapperCL opened a new pull request, #7316: [ISSUE #7315] Adding Rejected Policy Parameters to the ThreadPoolMonitor Construction Method
RapperCL opened a new pull request, #7316:
URL: https://github.com/apache/rocketmq/pull/7316
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #issue_id
[issue](https://github.com/apache/rocketmq/issues/7315)
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #7316: [ISSUE #7315] Adding Rejected Policy Parameters to the ThreadPoolMonitor Construction Method
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7316:
URL: https://github.com/apache/rocketmq/pull/7316#issuecomment-1732324688
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7316?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7316](https://app.codecov.io/gh/apache/rocketmq/pull/7316?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (92f496f) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/4a8e0d5b851d1f9573cda79b7d2e42ee498809da?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4a8e0d5) will **decrease** coverage by `0.13%`.
> Report is 7 commits behind head on develop.
> The diff coverage is `53.84%`.
```diff
@@ Coverage Diff @@
## develop #7316 +/- ##
=============================================
- Coverage 42.68% 42.55% -0.13%
+ Complexity 9482 9445 -37
=============================================
Files 1150 1150
Lines 82729 82733 +4
Branches 10777 10778 +1
=============================================
- Hits 35311 35206 -105
- Misses 43012 43115 +103
- Partials 4406 4412 +6
```
| [Files Changed](https://app.codecov.io/gh/apache/rocketmq/pull/7316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ache/rocketmq/common/thread/ThreadPoolMonitor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdGhyZWFkL1RocmVhZFBvb2xNb25pdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...y/service/receipt/DefaultReceiptHandleManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2UvcmVjZWlwdC9EZWZhdWx0UmVjZWlwdEhhbmRsZU1hbmFnZXIuamF2YQ==) | `70.83% <50.00%> (-0.70%)` | :arrow_down: |
| [...cketmq/proxy/grpc/v2/GrpcMessagingApplication.java](https://app.codecov.io/gh/apache/rocketmq/pull/7316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvdjIvR3JwY01lc3NhZ2luZ0FwcGxpY2F0aW9uLmphdmE=) | `36.41% <100.00%> (-2.51%)` | :arrow_down: |
... and [57 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7316/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7315] Adding Rejected Policy Parameters to the ThreadPoolMonitor Construction Method [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #7316: [ISSUE #7315] Adding Rejected Policy Parameters to the ThreadPoolMonitor Construction Method
URL: https://github.com/apache/rocketmq/pull/7316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RapperCL commented on pull request #7316: [ISSUE #7315] Adding Rejected Policy Parameters to the ThreadPoolMonitor Construction Method
Posted by "RapperCL (via GitHub)" <gi...@apache.org>.
RapperCL commented on PR #7316:
URL: https://github.com/apache/rocketmq/pull/7316#issuecomment-1732503045
> @RapperCL Please resolve the conflict.
👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7315] Adding Rejected Policy Parameters to the ThreadPoolMonitor Construction Method [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7316:
URL: https://github.com/apache/rocketmq/pull/7316#issuecomment-2418191506
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7315] Adding Rejected Policy Parameters to the ThreadPoolMonitor Construction Method [rocketmq]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7316:
URL: https://github.com/apache/rocketmq/pull/7316#issuecomment-2424307183
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7315] Adding Rejected Policy Parameters to the ThreadPoolMonitor Construction Method [rocketmq]
Posted by "RapperCL (via GitHub)" <gi...@apache.org>.
RapperCL commented on PR #7316:
URL: https://github.com/apache/rocketmq/pull/7316#issuecomment-1751894658
> @RapperCL Please resolve the conflict.
> > @RapperCL Please resolve the conflict.
>
> 👌
@lizhimins @mxsm hey， please review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org