Re: [PR] [SPARK-47577][CORE][PART1] Migrate logError with variables to structured logging framework [spark]

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #45834:
URL: https://github.com/apache/spark/pull/45834#discussion_r1549003961


##########
common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala:
##########
@@ -21,17 +21,57 @@ package org.apache.spark.internal
  * All structured logging keys should be defined here for standardization.
  */
 object LogKey extends Enumeration {
+  val EXECUTOR_ID = Value

Review Comment:
   would it be better to sort alphabetically if we don't need to keep bianry compatible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org