[GitHub] [samza] kw2542 commented on a change in pull request #1246: SAMZA-2409: Update YarnJob to construct job submission env varible

[GitBox <gi...@apache.org>]

kw2542 commented on a change in pull request #1246: SAMZA-2409: Update YarnJob to construct job submission env varible
URL: https://github.com/apache/samza/pull/1246#discussion_r366102401
 
 

 ##########
 File path: samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala
 ##########
 @@ -173,10 +173,16 @@ object YarnJob extends Logging {
   @VisibleForTesting
   private[yarn] def buildEnvironment(config: Config, yarnConfig: YarnConfig,
     jobConfig: JobConfig): Map[String, String] = {
-    val coordinatorSystemConfig = CoordinatorStreamUtil.buildCoordinatorStreamConfig(config)
     val envMapBuilder = Map.newBuilder[String, String]
-    envMapBuilder += ShellCommandConfig.ENV_COORDINATOR_SYSTEM_CONFIG ->
-      Util.envVarEscape(SamzaObjectMapper.getObjectMapper.writeValueAsString(coordinatorSystemConfig))
+    if (jobConfig.getConfigLoaderFactory.isPresent) {
+      envMapBuilder += ShellCommandConfig.ENV_SUBMISSION_CONFIG ->
+        Util.envVarEscape(SamzaObjectMapper.getObjectMapper.writeValueAsString(config))
 
 Review comment:
   Very good question, in the final approved SEP-23, we will not read any properties/config file during submission anymore. All submission related configs will be provided explicitly using --config.
   
   ApplicationRunnerMain will be updated in a separate PR to reflect this change as well. Full job config will only be read on AM, and then apply the overridden values we get from ApplicationRunnerMain will be passed to AM to override the value we load.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services