You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/06/20 05:43:31 UTC
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test modified according to Sh...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1047
[ TEST ] Selenium test modified according to Shiro failed the test.
### What is this PR for?
Shiro web test is included as an element of Selenium web test.
However, Shiro test case is to restart the zeppelin server.
As a result, the Selenium test does not work properly.
- Shiro modified to proceed to the last test.
### What type of PR is it?
Bug Fix
### Todos
- [x] added plugin (maven-surefire) in zeppelin-server pom.
- [x] modified class name
(AuthenticationIT.java -> ZeppelinShiroAuthenticationIT.java) -fixed last test
### How should this be tested?
this is a travis result issue.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin cifail/selenium-testfailed-via-auth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1047.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1047
----
commit c0b0dd2aa752f6abed8bed8ddc7bbff66eabb480
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T05:18:27Z
Selenium test modified according to Shiro failed the test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test modified according to Sh...
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1047
[ TEST ] Selenium test modified according to Shiro failed the test.
### What is this PR for?
Shiro web test is included as an element of Selenium web test.
However, Shiro test case is to restart the zeppelin server.
As a result, the Selenium test does not work properly.
- Shiro modified to proceed to the last test.
```java
public class AuthenticationIT extends AbstractZeppelinIT {
@BeforeClass
public static void startUp() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
originalShiro = StringUtils.join(FileUtils.readLines(file, "UTF-8"), "\n");
FileUtils.write(file, authShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT startUp::", e);
}
ZeppelinITUtils.restartZeppelin(); // <---- restart
driver = WebDriverManager.getWebDriver();
}
@AfterClass
public static void tearDown() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
FileUtils.write(file, originalShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT tearDown::", e);
}
ZeppelinITUtils.restartZeppelin(); // <----- restart
driver.quit();
}
}
```
### What type of PR is it?
Bug Fix
### Todos
- [x] added plugin (maven-surefire) in zeppelin-server pom.
- [x] modified class name
(AuthenticationIT.java -> ZeppelinShiroAuthenticationIT.java) -fixed last test
### How should this be tested?
this is a travis result issue.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin cifail/selenium-testfailed-via-auth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1047.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1047
----
commit c0b0dd2aa752f6abed8bed8ddc7bbff66eabb480
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T05:18:27Z
Selenium test modified according to Shiro failed the test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1047
[ TEST ] Selenium test
### What is this PR for?
Shiro web test is included as an element of Selenium web test.
However, Shiro test case is to restart the zeppelin server.
As a result, the Selenium test does not work properly.
- Shiro modified to proceed to the last test.
```java
public class AuthenticationIT extends AbstractZeppelinIT {
@BeforeClass
public static void startUp() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
originalShiro = StringUtils.join(FileUtils.readLines(file, "UTF-8"), "\n");
FileUtils.write(file, authShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT startUp::", e);
}
ZeppelinITUtils.restartZeppelin(); // <---- restart
driver = WebDriverManager.getWebDriver();
}
@AfterClass
public static void tearDown() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
FileUtils.write(file, originalShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT tearDown::", e);
}
ZeppelinITUtils.restartZeppelin(); // <----- restart
driver.quit();
}
}
```
### What type of PR is it?
Bug Fix
### Todos
- [x] added plugin (maven-surefire) in zeppelin-server pom.
- [x] modified class name
(AuthenticationIT.java -> ZeppelinShiroAuthenticationIT.java) -fixed last test
### How should this be tested?
this is a travis result issue.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin cifail/selenium-testfailed-via-auth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1047.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1047
----
commit c0b0dd2aa752f6abed8bed8ddc7bbff66eabb480
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T05:18:27Z
Selenium test modified according to Shiro failed the test.
commit 6c99111bdd39e1c76817c9f0fb3a37a9b17bd998
Author: root <ro...@worker8.nflabs.com>
Date: 2016-06-20T06:21:45Z
add initSecurityManager method.
commit cff604eba088a6a32b33bcfa796baba637e0c23e
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T06:31:53Z
test import pr 1034
commit 46c1b25e3d1c99d905d5e1bb3e8481b65cdba98b
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T06:39:31Z
fix create note xpath
commit 13a6139b1714a32718b5fa36cc3c6d8fad2ca435
Author: astroshim <hsshim.nflabs.com>
Date: 2016-06-20T07:45:33Z
add shiro-config-core
commit dab34fb99dfacc7c5f5cb22b05d06ef79398ac08
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T07:58:16Z
test remove auth
commit 5a2b26829681f41ceae54ab7b4d90fea7df9e8ba
Author: astroshim <hsshim.nflabs.com>
Date: 2016-06-20T08:08:49Z
add shiro ini to SecurityManager.
commit d12193cd1cbe1f643326627ca85c204f09933098
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:25:05Z
sleep test
commit 8eeb1bf030d5c1804d687b94ebb216345253eaea
Author: astroshim <hsshim.nflabs.com>
Date: 2016-06-20T08:32:42Z
update version of shiro config module.
commit 67528b981311bc4ddec8c9595a62f492a20ea0b9
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:39:09Z
test debug message
commit 70d122471491245b25f2ea7613a7110b48a5bb10
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:48:17Z
replace ng-controller xpath
commit 3324bea9ca23ddcc211ac84a4396d7efb3817623
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T09:37:55Z
add sleep(2)
commit 51b547c50a6f0ed1d55adddaf2167cccd619b8a0
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T10:01:49Z
restore mvn and add sleep
commit 4982f8dee654633083214da53454ab90d26fce90
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T11:53:21Z
add log
commit 51aa2062901c0952aa0a8c2297c04e69f5bc5fe9
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T12:52:53Z
changed test code.
commit 19a70d1064f14a40a0cd3c857e818364b25481cd
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T13:27:02Z
remove sleep
commit 471552cd4ccf40e2806363aa94abc493f738b184
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T14:10:54Z
add log
commit 757c0a58d3a74f0a46b9228aa8fa2a68f3baba6c
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:11:00Z
selenium version change
commit b1531c6495ad58148fa43da51e24399f6ee96df8
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:13:24Z
Revert "add log"
This reverts commit 471552cd4ccf40e2806363aa94abc493f738b184.
commit e4610196fefef1e0908a2c5893c05ce8ba30bd44
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:51:28Z
check to force refresh
commit 558db56c50081f61e924381e1dc97351b337f0f5
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:55:00Z
Merge branch 'master' into cifail/selenium-testfailed-via-auth
Conflicts:
zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
commit 5a1f945c0b955761008baa4c209c3f88a04a2563
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T16:24:17Z
restore selenium version
commit 52bd3794680dfcc0e7e620d4d2ba69a4ce1fffea
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T16:58:03Z
test remove - testRemoveButton
commit d14bdc9fe90b5f8edb754a5ad9a79bc6daa3b784
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T17:08:15Z
Merge branch 'ZEPPELIN-1033' into cifail/selenium-testfailed-via-auth
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test (please, do not merge)
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1047
[ TEST ] Selenium test (please, do not merge)
### What is this PR for?
Shiro web test is included as an element of Selenium web test.
However, Shiro test case is to restart the zeppelin server.
As a result, the Selenium test does not work properly.
- Shiro modified to proceed to the last test.
```java
public class AuthenticationIT extends AbstractZeppelinIT {
@BeforeClass
public static void startUp() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
originalShiro = StringUtils.join(FileUtils.readLines(file, "UTF-8"), "\n");
FileUtils.write(file, authShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT startUp::", e);
}
ZeppelinITUtils.restartZeppelin(); // <---- restart
driver = WebDriverManager.getWebDriver();
}
@AfterClass
public static void tearDown() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
FileUtils.write(file, originalShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT tearDown::", e);
}
ZeppelinITUtils.restartZeppelin(); // <----- restart
driver.quit();
}
}
```
### What type of PR is it?
Bug Fix
### Todos
- [x] added plugin (maven-surefire) in zeppelin-server pom.
- [x] modified class name
(AuthenticationIT.java -> ZeppelinShiroAuthenticationIT.java) -fixed last test
### How should this be tested?
this is a travis result issue.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin cifail/selenium-testfailed-via-auth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1047.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1047
----
commit c0b0dd2aa752f6abed8bed8ddc7bbff66eabb480
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T05:18:27Z
Selenium test modified according to Shiro failed the test.
commit 6c99111bdd39e1c76817c9f0fb3a37a9b17bd998
Author: root <ro...@worker8.nflabs.com>
Date: 2016-06-20T06:21:45Z
add initSecurityManager method.
commit cff604eba088a6a32b33bcfa796baba637e0c23e
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T06:31:53Z
test import pr 1034
commit 46c1b25e3d1c99d905d5e1bb3e8481b65cdba98b
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T06:39:31Z
fix create note xpath
commit 13a6139b1714a32718b5fa36cc3c6d8fad2ca435
Author: astroshim <hsshim.nflabs.com>
Date: 2016-06-20T07:45:33Z
add shiro-config-core
commit dab34fb99dfacc7c5f5cb22b05d06ef79398ac08
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T07:58:16Z
test remove auth
commit 5a2b26829681f41ceae54ab7b4d90fea7df9e8ba
Author: astroshim <hsshim.nflabs.com>
Date: 2016-06-20T08:08:49Z
add shiro ini to SecurityManager.
commit d12193cd1cbe1f643326627ca85c204f09933098
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:25:05Z
sleep test
commit 8eeb1bf030d5c1804d687b94ebb216345253eaea
Author: astroshim <hsshim.nflabs.com>
Date: 2016-06-20T08:32:42Z
update version of shiro config module.
commit 67528b981311bc4ddec8c9595a62f492a20ea0b9
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:39:09Z
test debug message
commit 70d122471491245b25f2ea7613a7110b48a5bb10
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:48:17Z
replace ng-controller xpath
commit 3324bea9ca23ddcc211ac84a4396d7efb3817623
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T09:37:55Z
add sleep(2)
commit 51b547c50a6f0ed1d55adddaf2167cccd619b8a0
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T10:01:49Z
restore mvn and add sleep
commit 4982f8dee654633083214da53454ab90d26fce90
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T11:53:21Z
add log
commit 51aa2062901c0952aa0a8c2297c04e69f5bc5fe9
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T12:52:53Z
changed test code.
commit 19a70d1064f14a40a0cd3c857e818364b25481cd
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T13:27:02Z
remove sleep
commit 471552cd4ccf40e2806363aa94abc493f738b184
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T14:10:54Z
add log
commit 757c0a58d3a74f0a46b9228aa8fa2a68f3baba6c
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:11:00Z
selenium version change
commit b1531c6495ad58148fa43da51e24399f6ee96df8
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:13:24Z
Revert "add log"
This reverts commit 471552cd4ccf40e2806363aa94abc493f738b184.
commit e4610196fefef1e0908a2c5893c05ce8ba30bd44
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:51:28Z
check to force refresh
commit 558db56c50081f61e924381e1dc97351b337f0f5
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:55:00Z
Merge branch 'master' into cifail/selenium-testfailed-via-auth
Conflicts:
zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
commit 5a1f945c0b955761008baa4c209c3f88a04a2563
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T16:24:17Z
restore selenium version
commit 52bd3794680dfcc0e7e620d4d2ba69a4ce1fffea
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T16:58:03Z
test remove - testRemoveButton
commit d14bdc9fe90b5f8edb754a5ad9a79bc6daa3b784
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T17:08:15Z
Merge branch 'ZEPPELIN-1033' into cifail/selenium-testfailed-via-auth
commit 21f5beeb5b95aebfe94a600b138558154fef8fa2
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T18:36:28Z
fixed create new button test case 'automatically adds % interpreter tag'
commit 7f950efb824f51ce23be40c9efc58cc0fda0c9cd
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T18:51:35Z
changed paragraphActionIT - testCreateNewButton test case.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test (please, do not merge)
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1047
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test modified according to Sh...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1047
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1047
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1047
[ TEST ] Selenium test
### What is this PR for?
Shiro web test is included as an element of Selenium web test.
However, Shiro test case is to restart the zeppelin server.
As a result, the Selenium test does not work properly.
- Shiro modified to proceed to the last test.
```java
public class AuthenticationIT extends AbstractZeppelinIT {
@BeforeClass
public static void startUp() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
originalShiro = StringUtils.join(FileUtils.readLines(file, "UTF-8"), "\n");
FileUtils.write(file, authShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT startUp::", e);
}
ZeppelinITUtils.restartZeppelin(); // <---- restart
driver = WebDriverManager.getWebDriver();
}
@AfterClass
public static void tearDown() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
FileUtils.write(file, originalShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT tearDown::", e);
}
ZeppelinITUtils.restartZeppelin(); // <----- restart
driver.quit();
}
}
```
### What type of PR is it?
Bug Fix
### Todos
- [x] added plugin (maven-surefire) in zeppelin-server pom.
- [x] modified class name
(AuthenticationIT.java -> ZeppelinShiroAuthenticationIT.java) -fixed last test
### How should this be tested?
this is a travis result issue.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin cifail/selenium-testfailed-via-auth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1047.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1047
----
commit c0b0dd2aa752f6abed8bed8ddc7bbff66eabb480
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T05:18:27Z
Selenium test modified according to Shiro failed the test.
commit 6c99111bdd39e1c76817c9f0fb3a37a9b17bd998
Author: root <ro...@worker8.nflabs.com>
Date: 2016-06-20T06:21:45Z
add initSecurityManager method.
commit cff604eba088a6a32b33bcfa796baba637e0c23e
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T06:31:53Z
test import pr 1034
commit 46c1b25e3d1c99d905d5e1bb3e8481b65cdba98b
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T06:39:31Z
fix create note xpath
commit 13a6139b1714a32718b5fa36cc3c6d8fad2ca435
Author: astroshim <hsshim.nflabs.com>
Date: 2016-06-20T07:45:33Z
add shiro-config-core
commit dab34fb99dfacc7c5f5cb22b05d06ef79398ac08
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T07:58:16Z
test remove auth
commit 5a2b26829681f41ceae54ab7b4d90fea7df9e8ba
Author: astroshim <hsshim.nflabs.com>
Date: 2016-06-20T08:08:49Z
add shiro ini to SecurityManager.
commit d12193cd1cbe1f643326627ca85c204f09933098
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:25:05Z
sleep test
commit 8eeb1bf030d5c1804d687b94ebb216345253eaea
Author: astroshim <hsshim.nflabs.com>
Date: 2016-06-20T08:32:42Z
update version of shiro config module.
commit 67528b981311bc4ddec8c9595a62f492a20ea0b9
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:39:09Z
test debug message
commit 70d122471491245b25f2ea7613a7110b48a5bb10
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:48:17Z
replace ng-controller xpath
commit 3324bea9ca23ddcc211ac84a4396d7efb3817623
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T09:37:55Z
add sleep(2)
commit 51b547c50a6f0ed1d55adddaf2167cccd619b8a0
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T10:01:49Z
restore mvn and add sleep
commit 4982f8dee654633083214da53454ab90d26fce90
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T11:53:21Z
add log
commit 51aa2062901c0952aa0a8c2297c04e69f5bc5fe9
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T12:52:53Z
changed test code.
commit 19a70d1064f14a40a0cd3c857e818364b25481cd
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T13:27:02Z
remove sleep
commit 471552cd4ccf40e2806363aa94abc493f738b184
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T14:10:54Z
add log
commit 757c0a58d3a74f0a46b9228aa8fa2a68f3baba6c
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:11:00Z
selenium version change
commit b1531c6495ad58148fa43da51e24399f6ee96df8
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:13:24Z
Revert "add log"
This reverts commit 471552cd4ccf40e2806363aa94abc493f738b184.
commit e4610196fefef1e0908a2c5893c05ce8ba30bd44
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:51:28Z
check to force refresh
commit 558db56c50081f61e924381e1dc97351b337f0f5
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:55:00Z
Merge branch 'master' into cifail/selenium-testfailed-via-auth
Conflicts:
zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
commit 5a1f945c0b955761008baa4c209c3f88a04a2563
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T16:24:17Z
restore selenium version
commit 52bd3794680dfcc0e7e620d4d2ba69a4ce1fffea
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T16:58:03Z
test remove - testRemoveButton
commit d14bdc9fe90b5f8edb754a5ad9a79bc6daa3b784
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T17:08:15Z
Merge branch 'ZEPPELIN-1033' into cifail/selenium-testfailed-via-auth
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test modified according to Sh...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1047
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1047
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1047
[ TEST ] Selenium test
### What is this PR for?
Shiro web test is included as an element of Selenium web test.
However, Shiro test case is to restart the zeppelin server.
As a result, the Selenium test does not work properly.
- Shiro modified to proceed to the last test.
```java
public class AuthenticationIT extends AbstractZeppelinIT {
@BeforeClass
public static void startUp() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
originalShiro = StringUtils.join(FileUtils.readLines(file, "UTF-8"), "\n");
FileUtils.write(file, authShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT startUp::", e);
}
ZeppelinITUtils.restartZeppelin(); // <---- restart
driver = WebDriverManager.getWebDriver();
}
@AfterClass
public static void tearDown() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
FileUtils.write(file, originalShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT tearDown::", e);
}
ZeppelinITUtils.restartZeppelin(); // <----- restart
driver.quit();
}
}
```
### What type of PR is it?
Bug Fix
### Todos
- [x] added plugin (maven-surefire) in zeppelin-server pom.
- [x] modified class name
(AuthenticationIT.java -> ZeppelinShiroAuthenticationIT.java) -fixed last test
### How should this be tested?
this is a travis result issue.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin cifail/selenium-testfailed-via-auth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1047.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1047
----
commit c0b0dd2aa752f6abed8bed8ddc7bbff66eabb480
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T05:18:27Z
Selenium test modified according to Shiro failed the test.
commit cff604eba088a6a32b33bcfa796baba637e0c23e
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T06:31:53Z
test import pr 1034
commit 46c1b25e3d1c99d905d5e1bb3e8481b65cdba98b
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T06:39:31Z
fix create note xpath
commit dab34fb99dfacc7c5f5cb22b05d06ef79398ac08
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T07:58:16Z
test remove auth
commit d12193cd1cbe1f643326627ca85c204f09933098
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:25:05Z
sleep test
commit 67528b981311bc4ddec8c9595a62f492a20ea0b9
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:39:09Z
test debug message
commit 70d122471491245b25f2ea7613a7110b48a5bb10
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:48:17Z
replace ng-controller xpath
commit 3324bea9ca23ddcc211ac84a4396d7efb3817623
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T09:37:55Z
add sleep(2)
commit 51b547c50a6f0ed1d55adddaf2167cccd619b8a0
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T10:01:49Z
restore mvn and add sleep
commit 4982f8dee654633083214da53454ab90d26fce90
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T11:53:21Z
add log
commit 51aa2062901c0952aa0a8c2297c04e69f5bc5fe9
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T12:52:53Z
changed test code.
commit 19a70d1064f14a40a0cd3c857e818364b25481cd
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T13:27:02Z
remove sleep
commit 471552cd4ccf40e2806363aa94abc493f738b184
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T14:10:54Z
add log
commit 757c0a58d3a74f0a46b9228aa8fa2a68f3baba6c
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:11:00Z
selenium version change
commit b1531c6495ad58148fa43da51e24399f6ee96df8
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:13:24Z
Revert "add log"
This reverts commit 471552cd4ccf40e2806363aa94abc493f738b184.
commit e4610196fefef1e0908a2c5893c05ce8ba30bd44
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:51:28Z
check to force refresh
commit 558db56c50081f61e924381e1dc97351b337f0f5
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T15:55:00Z
Merge branch 'master' into cifail/selenium-testfailed-via-auth
Conflicts:
zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test (please, do not merge)
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1047
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test modified according to Sh...
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1047
[ TEST ] Selenium test modified according to Shiro failed the test.
### What is this PR for?
Shiro web test is included as an element of Selenium web test.
However, Shiro test case is to restart the zeppelin server.
As a result, the Selenium test does not work properly.
- Shiro modified to proceed to the last test.
```java
public class AuthenticationIT extends AbstractZeppelinIT {
@BeforeClass
public static void startUp() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
originalShiro = StringUtils.join(FileUtils.readLines(file, "UTF-8"), "\n");
FileUtils.write(file, authShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT startUp::", e);
}
ZeppelinITUtils.restartZeppelin(); // <---- restart
driver = WebDriverManager.getWebDriver();
}
@AfterClass
public static void tearDown() {
if (!endToEndTestEnabled()) {
return;
}
try {
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
File file = new File(conf.getShiroPath());
FileUtils.write(file, originalShiro, "UTF-8");
} catch (IOException e) {
LOG.error("Error in AuthenticationIT tearDown::", e);
}
ZeppelinITUtils.restartZeppelin(); // <----- restart
driver.quit();
}
}
```
### What type of PR is it?
Bug Fix
### Todos
- [x] added plugin (maven-surefire) in zeppelin-server pom.
- [x] modified class name
(AuthenticationIT.java -> ZeppelinShiroAuthenticationIT.java) -fixed last test
### How should this be tested?
this is a travis result issue.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin cifail/selenium-testfailed-via-auth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1047.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1047
----
commit c0b0dd2aa752f6abed8bed8ddc7bbff66eabb480
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T05:18:27Z
Selenium test modified according to Shiro failed the test.
commit cff604eba088a6a32b33bcfa796baba637e0c23e
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T06:31:53Z
test import pr 1034
commit 46c1b25e3d1c99d905d5e1bb3e8481b65cdba98b
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T06:39:31Z
fix create note xpath
commit dab34fb99dfacc7c5f5cb22b05d06ef79398ac08
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T07:58:16Z
test remove auth
commit d12193cd1cbe1f643326627ca85c204f09933098
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:25:05Z
sleep test
commit 67528b981311bc4ddec8c9595a62f492a20ea0b9
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:39:09Z
test debug message
commit 70d122471491245b25f2ea7613a7110b48a5bb10
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T08:48:17Z
replace ng-controller xpath
commit 3324bea9ca23ddcc211ac84a4396d7efb3817623
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T09:37:55Z
add sleep(2)
commit 51b547c50a6f0ed1d55adddaf2167cccd619b8a0
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T10:01:49Z
restore mvn and add sleep
commit 4982f8dee654633083214da53454ab90d26fce90
Author: CloverHearts <cl...@gmail.com>
Date: 2016-06-20T11:53:21Z
add log
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1047: [ TEST ] Selenium test
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1047
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---