You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2014/06/10 00:11:08 UTC

[jira] [Resolved] (SOLR-6067) add buildAndRunCollectorChain methods to reduce code duplication in SolrIndexSearcher

     [ https://issues.apache.org/jira/browse/SOLR-6067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved SOLR-6067.
----------------------------

       Resolution: Fixed
    Fix Version/s: 5.0
                   4.9

Thanks Christine!

Feel free to open a new issue for changing/fixing hte grouping code as well - i just want to make sure it gets thought through (and ideally gets some more test cases as well) ... because if that collector can never be null, a ot of other code in that same are can be simplified (and if it can be null: then you suggested change wasn't equivalent, so we should make a conscious choice that it's a bug fix / improvement, not just a refactoring)

> add buildAndRunCollectorChain methods to reduce code duplication in SolrIndexSearcher
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-6067
>                 URL: https://issues.apache.org/jira/browse/SOLR-6067
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Christine Poerschke
>            Priority: Minor
>             Fix For: 4.9, 5.0
>
>         Attachments: SOLR-6067.patch, SOLR-6067.patch
>
>
> https://github.com/apache/lucene-solr/pull/48 has the proposed change. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org