You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/04/15 09:16:48 UTC

[GitHub] [cloudstack] sureshanaparti opened a new pull request #4922: Change default git branch name from 'master' to 'main'

sureshanaparti opened a new pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922


   ### Description
   Change default git branch name from 'master' to 'main' (post renaming/changing default git branch to 'main' in git repo)
   
   This PR updates the default git branch to 'main'.
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [x] Others - Git repo changes
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-840928753


   <b>Trillian test result (tid-681)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43012 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t681-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 82 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 500.69 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 284.08 | test_internal_lb.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1063.62 | test_privategw_acl.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 454.54 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 3610.12 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 81.43 | test_kubernetes_clusters.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 325.14 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 333.79 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 360.92 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 338.48 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 225.96 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 163.95 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 289.11 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 289.12 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 423.18 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853660768


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855274470


   <b>Trillian test result (tid-867)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42693 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t867-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 85 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 378.89 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 369.81 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 603.86 | test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 603.88 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 526.30 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 527.11 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 527.12 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1320.67 | test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.16 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853895201


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848144168


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r642363670



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41510to41600.sql
##########
@@ -303,3 +303,14 @@ from
         
 -- Update name for global configuration user.vm.readonly.ui.details
 Update configuration set name='user.vm.readonly.details' where name='user.vm.readonly.ui.details';
+
+-- Update name for global configuration 'user.vm.readonly.ui.details' to 'user.vm.denied.details'
+UPDATE `cloud`.`configuration` SET name='user.vm.denied.details' WHERE name='user.vm.blacklisted.details';

Review comment:
       Config key is called - `user.vm.denylisted.details` - maybe fix one of the other one?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-836783370


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-827332772


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853660768






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848142637


   @blueorangutan test centos7 vmware-67u3 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-840532848


   @sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-846561452


   <b>Trillian test result (tid-722)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46632 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t722-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 82 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 533.83 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 307.48 | test_internal_lb.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 3609.04 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 49.90 | test_kubernetes_clusters.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1145.87 | test_privategw_acl.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 370.38 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 362.45 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 367.02 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 348.20 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 228.94 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 176.58 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 310.86 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 310.87 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 445.54 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 318.81 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-854445206


   <b>Trillian test result (tid-831)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 79552 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t831-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 78 look OK, 10 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3613.49 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 191.34 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 3618.11 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 3669.69 | test_kubernetes_clusters.py
   ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.38 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.40 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.43 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.42 | test_templates.py
   test_04_extract_template | `Failure` | 130.28 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_volume_usage | `Error` | 72.17 | test_usage.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 1553.85 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | `Failure` | 1510.27 | test_vm_life_cycle.py
   ContextSuite context=TestVolumes>:setup | `Error` | 1947.25 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 29.89 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-840914912


   <b>Trillian test result (tid-683)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39633 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t683-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 83 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 538.87 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 315.25 | test_internal_lb.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1117.35 | test_privategw_acl.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 379.19 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 373.21 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 352.41 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 344.32 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 225.66 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 172.07 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 313.26 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 313.27 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 445.08 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-840532225


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-854416930


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-849424826


   @blueorangutan test centos7 xenserver-71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-837475996


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 570


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-856633046


   <b>Trillian test result (tid-892)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35705 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t892-vmware-67u3.zip
   Smoke tests completed. 88 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r629403133



##########
File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
##########
@@ -821,7 +821,7 @@
     public static final String SEMANTIC_VERSION = "semanticversion";
     public static final String KUBERNETES_VERSION_ID = "kubernetesversionid";
     public static final String KUBERNETES_VERSION_NAME = "kubernetesversionname";
-    public static final String MASTER_NODES = "masternodes";
+    public static final String PRIMARY_NODES = "primarynodes";

Review comment:
       > @sureshanaparti Please use Leader instead of primary to follow the kubernetes paradigm
   
   @davidjumani control nodes seems to be appropriate, is used for the kubernetes master nodes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-846476788


   @blueorangutan test matrix 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-845817547


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd closed pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-856331099


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-847589420


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nathanmcgarvey commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
nathanmcgarvey commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-831407134


   Overall, and this is probably too late for this suggestion: I'd recommend breaking this out into multiple commits: this is a huge single commit which makes reverting, diffing, and really all repo maintenance hard.
   
   Detailed suggestions:
   
   
   1. Carefully evaluate things things that are really version bump ideas that could break external API compatibility:
       E.g. systemvm/debian/opt/cloud/bin/master.py → systemvm/debian/opt/cloud/bin/router_mode.py
           a. Both the renaming of that file, and the changing of the command line arguments.
           b. tools/docker/systemtpl.sh   I hope those URLs and files actually exist immediately after merge!
   
   2. Remove unrelated changes to this PR... don't just tailgate stuff onto an already huge commit:
       plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java 
       plugins/hypervisors/ovm/src/main/java/com/cloud/ovm/object/Test.java 
       test/integration/component/test_acl_listsnapshot.py partially (Non-relevant typos: ("Snapshotss"))
   
   3. Match internal terminology to other external project documentation:
       Examples:
           a. Instead of "backup/cloudBackup"... call "replica/cloudReplica" to line up with MySQL docs post 8.0.23 (Ref: https://dev.mysql.com/doc/refman/8.0/en/binlog-replication-configuration-overview.html)
   
               Found at least in these files:
                   client/conf/db.properties.in
                   framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java 
   
           b. Instead of "Secondary" interface, which has a different meaning, how about "member" or maybe not even changing it quite yet since most OS documentation and Linux proper still actually calls them "slaves" in terms of Linux channel-bonding, by definition. This is going to get really confusing since if someone says 'secondary' interface, they usually mean a literal second NIC or alias, not a subordinate interface in a channel-bond/team/whatever.
               Found at least in these files:
                   plugins/hypervisors/ovm3/src/test/java/com/cloud/hypervisor/ovm3/objects/NetworkTest.java 
                   scripts/vm/hypervisor/xenserver/cloud-setup-bonding.sh
                   ...s/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
   
   4. There are missing corrections if you were trying to be 100% code-complete.
       Example:
           a. ...va/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixSetupCommandWrapper.java still has "slave" as a passed method parameter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853894609






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855086404


   <b>Trillian test result (tid-864)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34683 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t864-kvm-centos7.zip
   Smoke tests completed. 88 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-847430117


   <b>Trillian test result (tid-724)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38379 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t724-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 83 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 428.01 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 231.74 | test_internal_lb.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1014.17 | test_privategw_acl.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 294.04 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 289.59 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 281.64 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 274.32 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 173.80 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 128.10 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 233.03 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 233.04 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 324.82 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 253.46 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855188713


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855568875


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nathanmcgarvey edited a comment on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
nathanmcgarvey edited a comment on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-831407134


   Overall, and this is probably too late for this suggestion: I'd recommend breaking this out into multiple commits: this is a huge single commit which makes reverting, diffing, and really all repo maintenance hard.
   
   Detailed suggestions:
   
   
   1. Carefully evaluate things things that are really version bump ideas that could break external API compatibility:
       E.g. systemvm/debian/opt/cloud/bin/master.py → systemvm/debian/opt/cloud/bin/router_mode.py
           a. Both the renaming of that file, and the changing of the command line arguments.
           b. tools/docker/systemtpl.sh   I hope those URLs and files actually exist immediately after merge!
   
   2. Remove unrelated changes to this PR... don't just tailgate stuff onto an already huge commit:
       plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java 
       plugins/hypervisors/ovm/src/main/java/com/cloud/ovm/object/Test.java 
       test/integration/component/test_acl_listsnapshot.py partially (Non-relevant typos: ("Snapshotss"))
   
   3. Match internal terminology to other external project documentation:
       Examples:
           a. Instead of "backup/cloudBackup"... call "replica/cloudReplica" to line up with MySQL docs post 8.0.23 (Ref: https://dev.mysql.com/doc/refman/8.0/en/binlog-replication-configuration-overview.html)
   
               Found at least in these files:
                   client/conf/db.properties.in
                   framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java 
   
           b. Instead of "Secondary" interface, which has a different meaning, how about "member" or maybe not even changing it quite yet since most OS documentation and Linux proper still actually calls them "slaves" in terms of Linux channel-bonding, by definition. This is going to get really confusing since if someone says 'secondary' interface, they usually mean a literal second NIC or alias, not a subordinate interface in a channel-bond/team/whatever.
           Found at least in these files:
               plugins/hypervisors/ovm3/src/test/java/com/cloud/hypervisor/ovm3/objects/NetworkTest.java 
               scripts/vm/hypervisor/xenserver/cloud-setup-bonding.sh
               ...s/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
   
   4. There are missing corrections if you were trying to be 100% code-complete.
       Example:
           a. ...va/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixSetupCommandWrapper.java still has "slave" as a passed method parameter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r642363177



##########
File path: api/src/main/java/org/apache/cloudstack/query/QueryService.java
##########
@@ -92,8 +92,8 @@
     ConfigKey<Boolean> AllowUserViewDestroyedVM = new ConfigKey<>("Advanced", Boolean.class, "allow.user.view.destroyed.vm", "false",
             "Determines whether users can view their destroyed or expunging vm ", true, ConfigKey.Scope.Account);
 
-    static final ConfigKey<String> UserVMBlacklistedDetails = new ConfigKey<String>("Advanced", String.class,
-            "user.vm.blacklisted.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
+    static final ConfigKey<String> UserVMDenyListedDetails = new ConfigKey<String>("Advanced", String.class,
+            "user.vm.denylisted.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",

Review comment:
       @sureshanaparti for all config keys that are renamed we need an upgrade path that update the row in cloud.configuration table for that config key (global setting).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851512470


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 129


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nathanmcgarvey edited a comment on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
nathanmcgarvey edited a comment on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-837648414


   Visually LGTM. I did no functional, smoke, or any other actual technical testing.
   
   Side-note: @sureshanaparti , that was a crazy-fast revision.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-850609632


   <b>Trillian test result (tid-771)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39427 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t771-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Smoke tests completed. 88 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851515056


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r642458085



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41510to41600.sql
##########
@@ -303,3 +303,14 @@ from
         
 -- Update name for global configuration user.vm.readonly.ui.details
 Update configuration set name='user.vm.readonly.details' where name='user.vm.readonly.ui.details';
+
+-- Update name for global configuration 'user.vm.readonly.ui.details' to 'user.vm.denied.details'
+UPDATE `cloud`.`configuration` SET name='user.vm.denied.details' WHERE name='user.vm.blacklisted.details';

Review comment:
       thanks @rhtyd, updated to 'user.vm.denied.details'.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-846476336


   <b>Trillian test result (tid-719)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41859 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t719-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 83 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 444.50 | test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 421.96 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 228.08 | test_internal_lb.py
   test_04_rvpc_privategw_static_routes | `Failure` | 959.63 | test_privategw_acl.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 292.80 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 284.23 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 270.28 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 267.84 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 172.07 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 125.75 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 225.01 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 225.02 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 323.89 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-861289280


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853708325


   <b>Trillian Build Failed (tid-829)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853697856


   @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-847619167


   <b>Trillian test result (tid-728)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 7053 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t728-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-827324159


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-847611023


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-827340909


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-856331406


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-854916158


   <b>Trillian test result (tid-855)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38640 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t855-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 86 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 287.19 | test_internal_lb.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 287.66 | test_routers_network_ops.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-846476853


   @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4922: Change default git branch name from 'master' to 'main'

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-822252151


   let's do this immediately after releasing 4.15.1 and before 4.16


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-861375055


   @sureshanaparti this was manually quash merged, did we miss anything? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855164911


   <b>Trillian test result (tid-865)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44415 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t865-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 87 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 627.91 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 663.56 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 554.85 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 554.86 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-847610560


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853894609


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-846564001


   <b>Trillian test result (tid-720)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47648 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t720-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 82 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 485.27 | test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 518.68 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 297.78 | test_internal_lb.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1085.51 | test_privategw_acl.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 84.76 | test_kubernetes_clusters.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 328.29 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 327.61 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 365.57 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 348.09 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 215.42 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 166.42 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 294.73 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 294.75 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 437.10 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-845878685


   @sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-854416574


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nathanmcgarvey edited a comment on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
nathanmcgarvey edited a comment on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-831407134


   Overall, and this is probably too late for this suggestion: I'd recommend breaking this out into multiple commits: this is a huge single commit which makes reverting, diffing, and really all repo maintenance hard.
   
   Detailed suggestions:
   
   
   1. Carefully evaluate things things that are really version bump ideas that could break external API compatibility:
       E.g. systemvm/debian/opt/cloud/bin/master.py → systemvm/debian/opt/cloud/bin/router_mode.py
           a. Both the renaming of that file, and the changing of the command line arguments.
           b. tools/docker/systemtpl.sh   I hope those URLs and files actually exist immediately after merge!
   
   2. Remove unrelated changes to this PR... don't just tailgate stuff onto an already huge commit:
       plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java 
       plugins/hypervisors/ovm/src/main/java/com/cloud/ovm/object/Test.java 
       test/integration/component/test_acl_listsnapshot.py partially (Non-relevant typos: ("Snapshotss"))
   
   3. Match internal terminology to other external project documentation:
       Examples:
           a. Instead of "backup/cloudBackup"... call "replica/cloudReplica" to line up with MySQL docs post 8.0.23 (Ref: https://dev.mysql.com/doc/refman/8.0/en/binlog-replication-configuration-overview.html)
           Found at least in these files:
               client/conf/db.properties.in
               framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java 
   .
           b. Instead of "Secondary" interface, which has a different meaning, how about "member" or maybe not even changing it quite yet since most OS documentation and Linux proper still actually calls them "slaves" in terms of Linux channel-bonding, by definition. This is going to get really confusing since if someone says 'secondary' interface, they usually mean a literal second NIC or alias, not a subordinate interface in a channel-bond/team/whatever.
          Found at least in these files:
               plugins/hypervisors/ovm3/src/test/java/com/cloud/hypervisor/ovm3/objects/NetworkTest.java 
               scripts/vm/hypervisor/xenserver/cloud-setup-bonding.sh
               ...s/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
   
   4. There are missing corrections if you were trying to be 100% code-complete.
       Example:
           a. ...va/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixSetupCommandWrapper.java still has "slave" as a passed method parameter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855792653


   @sureshanaparti can you check if the intermittently failing VR/network tests are caused by this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-840901137


   <b>Trillian test result (tid-682)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37532 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t682-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 83 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 429.68 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 226.44 | test_internal_lb.py
   test_04_rvpc_privategw_static_routes | `Failure` | 987.29 | test_privategw_acl.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 286.86 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 287.66 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 274.79 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 275.84 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 172.46 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 128.07 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 232.72 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 232.72 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 328.93 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-846563767


   <b>Trillian test result (tid-721)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 47439 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t721-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 82 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 423.67 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 226.63 | test_internal_lb.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1038.29 | test_privategw_acl.py
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3625.52 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 95.85 | test_kubernetes_clusters.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 284.09 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 282.64 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 276.94 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 276.03 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 175.66 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 132.26 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 230.54 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 230.55 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 325.73 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-836782326


   > > Overall, and this is probably too late for this suggestion: I'd recommend breaking this out into multiple commits: this is a huge single commit which makes reverting, diffing, and really all repo maintenance hard.
   > > Detailed suggestions:
   > > 
   > > 1. Carefully evaluate things things that are really version bump ideas that could break external API compatibility:
   > >    E.g. systemvm/debian/opt/cloud/bin/master.py → systemvm/debian/opt/cloud/bin/router_mode.py
   > >    a. Both the renaming of that file, and the changing of the command line arguments.
   > >    b. tools/docker/systemtpl.sh   I hope those URLs and files actually exist immediately after merge!
   > > 2. Remove unrelated changes to this PR... don't just tailgate stuff onto an already huge commit:
   > >    plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
   > >    plugins/hypervisors/ovm/src/main/java/com/cloud/ovm/object/Test.java
   > >    test/integration/component/test_acl_listsnapshot.py partially (Non-relevant typos: ("Snapshotss"))
   > > 3. Match internal terminology to other external project documentation:
   > >    Examples:
   > >    a. Instead of "backup/cloudBackup"... call "replica/cloudReplica" to line up with MySQL docs post 8.0.23 (Ref: https://dev.mysql.com/doc/refman/8.0/en/binlog-replication-configuration-overview.html)
   > >    Found at least in these files:
   > >    client/conf/db.properties.in
   > >    framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java
   > >    .
   > >    b. Instead of "Secondary" interface, which has a different meaning, how about "member" or maybe not even changing it quite yet since most OS documentation and Linux proper still actually calls them "slaves" in terms of Linux channel-bonding, by definition. This is going to get really confusing since if someone says 'secondary' interface, they usually mean a literal second NIC or alias, not a subordinate interface in a channel-bond/team/whatever.
   > >    Found at least in these files:
   > >    plugins/hypervisors/ovm3/src/test/java/com/cloud/hypervisor/ovm3/objects/NetworkTest.java
   > >    scripts/vm/hypervisor/xenserver/cloud-setup-bonding.sh
   > >    ...s/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
   > > 4. There are missing corrections if you were trying to be 100% code-complete.
   > >    Example:
   > >    a. ...va/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixSetupCommandWrapper.java still has "slave" as a passed method parameter.
   > 
   > @nathanmcgarvey Thanks for the review, I'll update the changes accordingly.
   
    @nathanmcgarvey I've split these changes across multiple commits, please take a look.
   Regarding your suggestions.
   1. I have carefully checked the files that were renamed as part of this exercise. The file name references and any changes to the command line arguments are addressed, and the files exist immediately after merge.
   2. Removed unrelated changes in _plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java_, except the comments & typos: 'Snapshotss' at _test/integration/component/test_acl_listsnapshot.py_ (minor changes and can forget to correct this later, so ignoring this).
   3. Updated the internal terminology to match with the other external / third party product documentation (MySQL source / replicas, XenSever pool master, etc).
   4. Corrected the missing parts. Removed the changes here _plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixSetupCommandWrapper.java_ , to be in sync with XenSever pool master and slave.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r642452683



##########
File path: framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java
##########
@@ -1196,8 +1196,8 @@ private static String getDBHAParams(String dbName, Properties dbProps) {
         sb.append("failOverReadOnly=" + dbProps.getProperty("db." + dbName + ".failOverReadOnly"));
         sb.append("&").append("reconnectAtTxEnd=" + dbProps.getProperty("db." + dbName + ".reconnectAtTxEnd"));
         sb.append("&").append("autoReconnectForPools=" + dbProps.getProperty("db." + dbName + ".autoReconnectForPools"));
-        sb.append("&").append("secondsBeforeRetryMaster=" + dbProps.getProperty("db." + dbName + ".secondsBeforeRetryMaster"));
-        sb.append("&").append("queriesBeforeRetryMaster=" + dbProps.getProperty("db." + dbName + ".queriesBeforeRetryMaster"));
+        sb.append("&").append("secondsBeforeRetrySource=" + dbProps.getProperty("db." + dbName + ".secondsBeforeRetrySource"));

Review comment:
       @rhtyd these options 'secondsBeforeRetrySource', 'queriesBeforeRetrySource' works with mysql connector.
   Some references here:
   - https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-config-failover.html
   - https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-reference-configuration-properties.html
   
    MySQL Connector 8.0 supports MySQL Server 5.6, 5.7 and  8.0.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851629405


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851487958


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848470092


   @blueorangutan test centos7 xs71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855569041


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-846394559


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-852031952


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r642483933



##########
File path: ui/CONTRIBUTING.md
##########
@@ -16,13 +16,13 @@ configuration, development, usage, extension and testing.
 It's very important that we can easily track bug fix commits, so their hashes should remain the same in all branches.
 Therefore, a pull request (PR) that fixes a bug, should be sent against a release branch.
 This can be either the "current release" or the "previous release", depending on which ones are maintained.
-Since the goal is a stable master, bug fixes should be "merged forward" to the next branch in order: "previous release" -> "current release" -> master (in other words: old to new)

Review comment:
       > the ui/CONTRIBUTING.md can be removed as this was from old primate repo which is not necessary; the repo already has a CONTRIBUTING.md in root repo dir.
   
   @rhtyd Revert the changes, and created a PR (https://github.com/apache/cloudstack/pull/5054) to remove the file 'ui/CONTRIBUTING.md'.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-852900854


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851488564


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848471371


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-849425112


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-854699754


   @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848069731


   <b>Trillian test result (tid-729)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35083 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t729-kvm-centos7.zip
   Smoke tests completed. 88 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4922: Change default git branch name from 'master' to 'main'

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r615614463



##########
File path: CHANGES.md
##########
@@ -711,7 +711,7 @@ Bug Fixes:
 * CLOUDSTACK-1391 EventBus is not getting injected after javelin merge
 * CLOUDSTACK-1383 Deploying basic zone on 4.1 fails in NPE

Review comment:
       I would add that changes that were done when the branch was called 'master' were not done to 'main'. I agree on removing the file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r642364997



##########
File path: server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java
##########
@@ -344,9 +344,9 @@ public UserVmResponse newUserVmResponse(ResponseView view, String objectName, Us
                 userVmResponse.setPoolType(userVm.getPoolType().toString());
             }
 
-            // Remove blacklisted settings if user is not admin
+            // Remove deny listed settings if user is not admin
             if (caller.getType() != Account.ACCOUNT_TYPE_ADMIN) {
-                String[] userVmSettingsToHide = QueryService.UserVMBlacklistedDetails.value().split(",");
+                String[] userVmSettingsToHide = QueryService.UserVMDenyListedDetails.value().split(",");

Review comment:
       Let's rename it simply to `UserVmDenyListDetails`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848470360


   @sureshanaparti unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, centos8, ubuntu18, ubuntu20`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu18, kvm-ubuntu20, xenserver-71, xenserver-65sp1, vmware-70u1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-852900420


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4922: Change default git branch name from 'master' to 'main'

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r613907320



##########
File path: CHANGES.md
##########
@@ -711,7 +711,7 @@ Bug Fixes:
 * CLOUDSTACK-1391 EventBus is not getting injected after javelin merge
 * CLOUDSTACK-1383 Deploying basic zone on 4.1 fails in NPE

Review comment:
       @sureshanaparti I think we should remove the CHANGES file - nobody maintains that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-856435634


   > Trillian test result (tid-877)
   > Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   > Total time taken: 44800 seconds
   > Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t877-xenserver-71.zip
   > Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   > Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   > Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   > Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   > Smoke tests completed. 86 look OK, 2 have error(s)
   > Only failed tests results shown below:
   > 
   > Test	Result	Time (s)	Test File
   > test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Failure`	363.54	test_routers_network_ops.py
   > test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	593.44	test_vpc_redundant.py
   > test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	445.72	test_vpc_redundant.py
   > test_05_rvpc_multi_tiers	`Failure`	563.38	test_vpc_redundant.py
   
   test results are not consistent, triggering them again.
   
   @blueorangutan test centos7 xenserver-71
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848470934


   @blueorangutan test centos7 xenserver-71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-846303848


   <b>Trillian test result (tid-713)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39966 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t713-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 83 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 558.30 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 333.90 | test_internal_lb.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1118.12 | test_privategw_acl.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 362.10 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 362.64 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 373.37 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 398.11 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 230.06 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 176.28 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 310.55 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 310.57 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 433.03 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855188370


   <b>Trillian test result (tid-863)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 58850 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t863-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 84 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
   test_DeleteDomain | `Error` | 4.09 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 3.97 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.34 | test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 364.19 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 364.21 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 617.46 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 528.44 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r642364176



##########
File path: framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java
##########
@@ -1196,8 +1196,8 @@ private static String getDBHAParams(String dbName, Properties dbProps) {
         sb.append("failOverReadOnly=" + dbProps.getProperty("db." + dbName + ".failOverReadOnly"));
         sb.append("&").append("reconnectAtTxEnd=" + dbProps.getProperty("db." + dbName + ".reconnectAtTxEnd"));
         sb.append("&").append("autoReconnectForPools=" + dbProps.getProperty("db." + dbName + ".autoReconnectForPools"));
-        sb.append("&").append("secondsBeforeRetryMaster=" + dbProps.getProperty("db." + dbName + ".secondsBeforeRetryMaster"));
-        sb.append("&").append("queriesBeforeRetryMaster=" + dbProps.getProperty("db." + dbName + ".queriesBeforeRetryMaster"));
+        sb.append("&").append("secondsBeforeRetrySource=" + dbProps.getProperty("db." + dbName + ".secondsBeforeRetrySource"));

Review comment:
       are these options validated by MySQL? (that is do they work wrt the mysql connector or mysql server)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-852049671


   <b>Trillian test result (tid-806)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 56068 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t806-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 84 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 480.14 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 3922.00 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Error` | 3922.01 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 128.87 | test_vpc_redundant.py
   test_01_VPC_nics_after_destroy | `Error` | 5.63 | test_vpc_router_nics.py
   test_02_VPC_default_routes | `Error` | 4.62 | test_vpc_router_nics.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 7.38 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 5.32 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | `Failure` | 4.16 | test_vpc_vpn.py
   test_01_vpc_site2site_vpn | `Failure` | 6.33 | test_vpc_vpn.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 0.04 | test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 0.04 | test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.04 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853697531


   @blueorangutan test matrix 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-836784815


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855188587


   @blueorangutan test centos7 xenserver-71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848470360


   @sureshanaparti unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, centos8, ubuntu18, ubuntu20`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu18, kvm-ubuntu20, xenserver-71, xenserver-65sp1, vmware-70u1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853940139


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-856329195


   <b>Trillian test result (tid-878)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 67108 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t878-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 79 look OK, 9 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.51 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.37 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 75.21 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.44 | test_templates.py
   test_04_extract_template | `Failure` | 200.14 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_volume_usage | `Failure` | 672.46 | test_usage.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 1561.50 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | `Failure` | 1510.24 | test_vm_life_cycle.py
   test_change_service_offering_for_vm_with_snapshots | `Error` | 219.34 | test_vm_snapshots.py
   ContextSuite context=TestVolumes>:setup | `Error` | 1967.42 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851919055


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r628901397



##########
File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
##########
@@ -821,7 +821,7 @@
     public static final String SEMANTIC_VERSION = "semanticversion";
     public static final String KUBERNETES_VERSION_ID = "kubernetesversionid";
     public static final String KUBERNETES_VERSION_NAME = "kubernetesversionname";
-    public static final String MASTER_NODES = "masternodes";
+    public static final String PRIMARY_NODES = "primarynodes";

Review comment:
       @sureshanaparti Please use Leader instead of primary to follow the kubernetes paradigm 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848658703


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853940885


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-852410764


   <b>Trillian test result (tid-809)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41201 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t809-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 86 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_reboot_router | `Error` | 191.50 | test_network.py
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 175.48 | test_kubernetes_clusters.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 263.03 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 1.08 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.15 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 1.18 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 3.18 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.19 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.20 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 272.41 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853660310


   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-867466437


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-846394513


   @blueorangutan test 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-847016601


   @sureshanaparti pl check if the repeated failure are due to your change (notice in VRRP backup/master may not be changed or you've to be cautious with what you do with redudant routers)
   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-831731002


   > Overall, and this is probably too late for this suggestion: I'd recommend breaking this out into multiple commits: this is a huge single commit which makes reverting, diffing, and really all repo maintenance hard.
   > 
   > Detailed suggestions:
   > 
   > 1. Carefully evaluate things things that are really version bump ideas that could break external API compatibility:
   >    E.g. systemvm/debian/opt/cloud/bin/master.py → systemvm/debian/opt/cloud/bin/router_mode.py
   >    a. Both the renaming of that file, and the changing of the command line arguments.
   >    b. tools/docker/systemtpl.sh   I hope those URLs and files actually exist immediately after merge!
   > 2. Remove unrelated changes to this PR... don't just tailgate stuff onto an already huge commit:
   >    plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
   >    plugins/hypervisors/ovm/src/main/java/com/cloud/ovm/object/Test.java
   >    test/integration/component/test_acl_listsnapshot.py partially (Non-relevant typos: ("Snapshotss"))
   > 3. Match internal terminology to other external project documentation:
   >    Examples:
   >    a. Instead of "backup/cloudBackup"... call "replica/cloudReplica" to line up with MySQL docs post 8.0.23 (Ref: https://dev.mysql.com/doc/refman/8.0/en/binlog-replication-configuration-overview.html)
   >    Found at least in these files:
   >    client/conf/db.properties.in
   >    framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java
   >    .
   >    b. Instead of "Secondary" interface, which has a different meaning, how about "member" or maybe not even changing it quite yet since most OS documentation and Linux proper still actually calls them "slaves" in terms of Linux channel-bonding, by definition. This is going to get really confusing since if someone says 'secondary' interface, they usually mean a literal second NIC or alias, not a subordinate interface in a channel-bond/team/whatever.
   >    Found at least in these files:
   >    plugins/hypervisors/ovm3/src/test/java/com/cloud/hypervisor/ovm3/objects/NetworkTest.java
   >    scripts/vm/hypervisor/xenserver/cloud-setup-bonding.sh
   >    ...s/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
   > 4. There are missing corrections if you were trying to be 100% code-complete.
   >    Example:
   >    a. ...va/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixSetupCommandWrapper.java still has "slave" as a passed method parameter.
   
   @nathanmcgarvey Thanks for the review, I'll update the changes accordingly. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-856434284


   > @sureshanaparti can you check if the intermittently failing VR/network tests are caused by this PR?
   
   @rhtyd these test failures are related to some network connectivity issues, and not related to this PR changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-845831945


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 68


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-849847275


   <b>Trillian test result (tid-761)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36377 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t761-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 88 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848608089


   <b>Trillian test result (tid-744)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 50909 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t744-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 84 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 633.38 | test_internal_lb.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 326.38 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 403.06 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 709.04 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 607.29 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 565.07 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 565.08 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 4.49 | test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 3.51 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-861289963


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-850222451


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r642461459



##########
File path: server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java
##########
@@ -344,9 +344,9 @@ public UserVmResponse newUserVmResponse(ResponseView view, String objectName, Us
                 userVmResponse.setPoolType(userVm.getPoolType().toString());
             }
 
-            // Remove blacklisted settings if user is not admin
+            // Remove deny listed settings if user is not admin
             if (caller.getType() != Account.ACCOUNT_TYPE_ADMIN) {
-                String[] userVmSettingsToHide = QueryService.UserVMBlacklistedDetails.value().split(",");
+                String[] userVmSettingsToHide = QueryService.UserVMDenyListedDetails.value().split(",");

Review comment:
       > Let's rename it simply to `UserVmDenyListDetails`?
   
   renamed to 'UserVMDeniedDetails' (in sync with config name).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-847590158


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-861307456


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 236


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r634943669



##########
File path: api/src/main/java/com/cloud/network/router/VirtualRouter.java
##########
@@ -35,7 +35,7 @@
     boolean getIsRedundantRouter();
 
     public enum RedundantState {
-        UNKNOWN, MASTER, BACKUP, FAULT
+        UNKNOWN, PRIMARY, BACKUP, FAULT

Review comment:
       @sureshanaparti as this value will be stored in the db, do we need to handle that or will it be taken care of as VRs may need to be recreated after the upgrade?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-854698301


   @blueorangutan test matrix 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-856435769


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855340388


   @blueorangutan test centos7 xenserver-71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r642460541



##########
File path: api/src/main/java/org/apache/cloudstack/query/QueryService.java
##########
@@ -92,8 +92,8 @@
     ConfigKey<Boolean> AllowUserViewDestroyedVM = new ConfigKey<>("Advanced", Boolean.class, "allow.user.view.destroyed.vm", "false",
             "Determines whether users can view their destroyed or expunging vm ", true, ConfigKey.Scope.Account);
 
-    static final ConfigKey<String> UserVMBlacklistedDetails = new ConfigKey<String>("Advanced", String.class,
-            "user.vm.blacklisted.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
+    static final ConfigKey<String> UserVMDenyListedDetails = new ConfigKey<String>("Advanced", String.class,
+            "user.vm.denylisted.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",

Review comment:
       Updated config to 'user.vm.denied.details', upgrade path (schema file) has the relevant changes for config name change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848470092


   @blueorangutan test centos7 xs71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851629180


   @blueorangutan test centos7 xenserver-71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-856817310


   <b>Trillian test result (tid-893)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33604 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t893-xenserver-71.zip
   Smoke tests completed. 88 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-856645364


   Github was down, so I manually merged it in 958182481e200afa95f04022fe37044393085265 and closing this PR based on that. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-847016794


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-856640980


   Tests LGTM, let's merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851646164


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853693256


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 153


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-846314369


   <b>Trillian test result (tid-711)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43818 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t711-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 82 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 500.99 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 290.73 | test_internal_lb.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1129.79 | test_privategw_acl.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 331.12 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 329.43 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 369.52 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 340.08 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 217.80 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 168.52 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 290.29 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 290.30 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 417.31 | test_vpc_vpn.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 305.45 | test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 3605.24 | test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 2621.77 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-862030047


   > @sureshanaparti this was manually quash merged, did we miss anything?
   
   nothing missed @rhtyd, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855340592


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-854273526


   <b>Trillian test result (tid-832)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 53517 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t832-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 85 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 378.35 | test_internal_lb.py
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3603.25 | test_kubernetes_clusters.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 67.77 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 60.52 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 52.31 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 62.54 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 44.57 | test_kubernetes_clusters.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 677.35 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 571.64 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 577.26 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 577.28 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-827751544


   <b>Trillian test result (tid-539)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36114 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t539-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 83 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 366.84 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 202.63 | test_internal_lb.py
   test_04_rvpc_privategw_static_routes | `Failure` | 949.85 | test_privategw_acl.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 263.78 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 263.21 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 232.23 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 231.25 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 148.92 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 108.66 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 208.01 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 234.89 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 281.46 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-845816962


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-845878339


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-846282756


   <b>Trillian test result (tid-712)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36431 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t712-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 82 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_ping_in_cpvm_success | `Failure` | 15.34 | test_diagnostics.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 421.63 | test_internal_lb.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 222.40 | test_internal_lb.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1023.60 | test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 1005.89 | test_privategw_acl.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 296.03 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 295.65 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 272.86 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 265.64 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 170.84 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 123.95 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 222.38 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 222.39 | test_vpc_redundant.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 322.56 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-854396147


   <b>Trillian test result (tid-841)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 53210 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t841-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Smoke tests completed. 86 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_ping_in_cpvm_success | `Failure` | 5.39 | test_diagnostics.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3615.49 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 3612.35 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.14 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 3.18 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.08 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.08 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.33 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 92.52 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd closed pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855439049


   <b>Trillian test result (tid-877)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44800 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t877-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 86 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 363.54 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 593.44 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 445.72 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 563.38 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851847103


   <b>Trillian test result (tid-797)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 55843 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t797-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 79 look OK, 9 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 333.76 | test_routers_network_ops.py
   ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
   test_04_extract_template | `Failure` | 128.30 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_volume_usage | `Error` | 188.73 | test_usage.py
   test_10_attachAndDetach_iso | `Failure` | 1510.15 | test_vm_life_cycle.py
   test_06_download_detached_volume | `Failure` | 355.50 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-852037934


   <b>Trillian Build Failed (tid-813)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851646259


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851919822


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-847608058


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 82


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nathanmcgarvey commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
nathanmcgarvey commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-837648414


   Visually LGTM. I did no functional, smoke, or any other actual function testing.
   
   Side-note: @sureshanaparti , that was a crazy-fast revision.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-827340459


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-850221872


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-848658381


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-849210261


   <b>Trillian test result (tid-747)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 48845 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t747-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 83 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 0.07 | test_internal_lb.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 148.98 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 458.61 | test_routers_network_ops.py
   test_10_list_volumes | `Failure` | 366.56 | test_volumes.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 639.95 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 666.45 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 313.82 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 632.61 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 632.63 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 19.73 | test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 96.78 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r642366154



##########
File path: ui/CONTRIBUTING.md
##########
@@ -16,13 +16,13 @@ configuration, development, usage, extension and testing.
 It's very important that we can easily track bug fix commits, so their hashes should remain the same in all branches.
 Therefore, a pull request (PR) that fixes a bug, should be sent against a release branch.
 This can be either the "current release" or the "previous release", depending on which ones are maintained.
-Since the goal is a stable master, bug fixes should be "merged forward" to the next branch in order: "previous release" -> "current release" -> master (in other words: old to new)

Review comment:
       the ui/CONTRIBUTING.md can be removed as this was from old primate repo which is not necessary; the repo already has a CONTRIBUTING.md in root repo dir.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851810060


   <b>Trillian test result (tid-805)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36994 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t805-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Smoke tests completed. 87 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_change_service_offering_for_vm_with_snapshots | `Error` | 1.21 | test_vm_snapshots.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-847619167


   <b>Trillian test result (tid-728)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 7053 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4922-t728-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853918674


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-827323884


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-840416535


   @sureshanaparti can you kick test matrix and ensure all build/tests are passing 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-852031680


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-851514837


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appropriate

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853660310






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org