You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/03 22:30:21 UTC

[GitHub] [airflow] ferruzzi commented on a diff in pull request #28321: Add support in AWS Batch Operator for multinode jobs

ferruzzi commented on code in PR #28321:
URL: https://github.com/apache/airflow/pull/28321#discussion_r1061006224


##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -108,12 +110,13 @@ class BatchOperator(BaseOperator):
         "job_queue",
         "overrides",

Review Comment:
   > TIL the names here need to match not the parameter name in the ctor but the name of the attribute in the class
   
   To translate that into ELI5: if you have `self.foo = bar` in your operator, the template field would be named "foo" to match "self.foo", not "bar". :P 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org