You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "tmedicci (via GitHub)" <gi...@apache.org> on 2023/04/04 13:11:33 UTC
[GitHub] [nuttx] tmedicci opened a new pull request, #8963: esp32/wifi: Fix Wi-Fi driver parameter settings
tmedicci opened a new pull request, #8963:
URL: https://github.com/apache/nuttx/pull/8963
## Summary
This PR fixes [#7857](https://github.com/apache/nuttx/issues/7857) and [#7193](https://github.com/apache/nuttx/issues/7193) by saving Wi-Fi parameters and setting them at once, avoiding unknown behaviors of the Wi-Fi driver, like setting auth mode without a valid password.
Also, it enables setting the auth of the STA/softAP modes while connecting to/providing the wireless network.
Finally, it notifies the networking layer about the current state of the STA interface.
## Impact
Fix known bugs of the Wi-Fi driver on ESP32 (C3 is not affected because of its driver implementation) and improve security as it sets the minimum auth method to connect to an AP.
## Testing
CI testing that covers erroneous behavior prior to this MR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei merged pull request #8963: esp32/wifi: Fix Wi-Fi driver parameter settings
Posted by "gustavonihei (via GitHub)" <gi...@apache.org>.
gustavonihei merged PR #8963:
URL: https://github.com/apache/nuttx/pull/8963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] tmedicci commented on a diff in pull request #8963: esp32/wifi: Fix Wi-Fi driver parameter settings
Posted by "tmedicci (via GitHub)" <gi...@apache.org>.
tmedicci commented on code in PR #8963:
URL: https://github.com/apache/nuttx/pull/8963#discussion_r1159850928
##########
arch/xtensa/src/esp32/esp32_wlan.c:
##########
@@ -1763,12 +1763,46 @@ static void wlan_softap_tx_done(uint8_t *data, uint16_t *len, bool status)
wlan_tx_done(priv);
}
-#endif
+#endif /* ESP32_WLAN_HAS_SOFTAP */
/****************************************************************************
* Public Functions
****************************************************************************/
+/****************************************************************************
+ * Name: esp32_wlan_sta_set_linkstatus
+ *
+ * Description:
+ * Set Wi-Fi station link status
+ *
+ * Parameters:
+ * linkstatus - true Notifies the networking layer about an available
+ * carrier, false Notifies the networking layer about an
+ * disappeared carrier.
+ *
+ * Returned Value:
+ * OK on success; Negated errno on failure.
+ *
+ ****************************************************************************/
+
+#ifdef ESP32_WLAN_HAS_STA
+int esp32_wlan_sta_set_linkstatus(bool linkstatus)
+{
+ int ret = -EINVAL;
+ FAR struct wlan_priv_s *priv = &g_wlan_priv[ESP32_WLAN_STA_DEVNO];
Review Comment:
Please, check https://github.com/apache/nuttx/pull/8977/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8963: esp32/wifi: Fix Wi-Fi driver parameter settings
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #8963:
URL: https://github.com/apache/nuttx/pull/8963#discussion_r1158847254
##########
arch/xtensa/src/esp32/esp32_wlan.c:
##########
@@ -1763,12 +1763,46 @@ static void wlan_softap_tx_done(uint8_t *data, uint16_t *len, bool status)
wlan_tx_done(priv);
}
-#endif
+#endif /* ESP32_WLAN_HAS_SOFTAP */
/****************************************************************************
* Public Functions
****************************************************************************/
+/****************************************************************************
+ * Name: esp32_wlan_sta_set_linkstatus
+ *
+ * Description:
+ * Set Wi-Fi station link status
+ *
+ * Parameters:
+ * linkstatus - true Notifies the networking layer about an available
+ * carrier, false Notifies the networking layer about an
+ * disappeared carrier.
+ *
+ * Returned Value:
+ * OK on success; Negated errno on failure.
+ *
+ ****************************************************************************/
+
+#ifdef ESP32_WLAN_HAS_STA
+int esp32_wlan_sta_set_linkstatus(bool linkstatus)
+{
+ int ret = -EINVAL;
+ FAR struct wlan_priv_s *priv = &g_wlan_priv[ESP32_WLAN_STA_DEVNO];
Review Comment:
Remove FAR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org