You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Christopher Schultz (JIRA)" <de...@velocity.apache.org> on 2008/05/28 21:41:45 UTC

[jira] Commented: (VELTOOLS-105) MessageTool doesn't support MessageResources the same way Struts does in terms of scoping

    [ https://issues.apache.org/jira/browse/VELTOOLS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600585#action_12600585 ] 

Christopher Schultz commented on VELTOOLS-105:
----------------------------------------------

I think the real question is why "StrutsUtils.getMessageResources(request, application)" does not return your MessageResources object. If that worked properly, there would be no need to change MessageResourcesTool.

Note that there is no page scope available, here. Page scope applies only to JSPs.

I don't believe MessageResourcesTool consults the ServletContext at all for the bundle in question.

Can you give us a bit more detail? For instance, when does your application place the bundle into the request? Under what key? Globals.MESSAGES_KEY? I don't think that's appropriate, as the documentation for that "constant" is that it is to be used in the "context" scope.

> MessageTool doesn't support MessageResources the same way Struts does in terms of scoping
> -----------------------------------------------------------------------------------------
>
>                 Key: VELTOOLS-105
>                 URL: https://issues.apache.org/jira/browse/VELTOOLS-105
>             Project: Velocity Tools
>          Issue Type: Bug
>          Components: VelocityStruts
>    Affects Versions: 1.4, 2.0
>            Reporter: Cott Lang
>         Attachments: MessageResourcesTool.patch1
>
>
> We have an application that, for various reasons, inserts it's own MessageResources object into the Request in the RequestProcessor.
> We do not have message-resource defined in the struts config.
> This works fine in Struts, because Struts (at least 1.2.9)  defaults 'bundle' to Globals.MESSAGES_KEY if it's null and checks the page, request, and application scopes in that order (see TagUtils)
> StrutsUtils has similar behavior.  Unfortunately, MessageResourcesTool prevents it from working because getResources() returns an error if 'bundle' is null and there was not a MessageResources in the ServletContext. 
> I fixed this by simply changing MessageResourcesTool to return the locally cached 'resources' object if 'bundle' is null and resources is not, but otherwise to call StrutsUtils and let it find the MessageResources.  To be completely compatible with Struts, it seems like StrutsUtils also needs to be modified to check the page scope before the request scope.
> 2.0 is different, but looks like it would still suffer from this problem in our application. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org