You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeff Jirsa (JIRA)" <ji...@apache.org> on 2017/12/01 17:37:00 UTC

[jira] [Comment Edited] (CASSANDRA-14008) RTs at index boundaries in 2.x sstables can create unexpected CQL row in 3.x

    [ https://issues.apache.org/jira/browse/CASSANDRA-14008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273735#comment-16273735 ] 

Jeff Jirsa edited comment on CASSANDRA-14008 at 12/1/17 5:36 PM:
-----------------------------------------------------------------

The raw patches that fix the bug in LegacyLayout are at 

|| Branch || CI ||
| [3.0|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.0-14008] | [!https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.0-14008.svg?style=svg!|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.0-14008/] | 
| [3.11|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.11-14008] | [!https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.11-14008.svg?style=svg!|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.11-14008/]| 

I was hoping to actually have a solution to un-breaking the broken 3.0 sstables in the same patch, but it's proving to be more difficult than I anticipated. I haven't yet tried to make some sample sstables for regression tests, I agree it'd be nice to have those. 

Please glance at the code, and I'll work on the regression sstables before committing.


was (Author: jjirsa):
The raw patches that fix the bug in LegacyLayout are at 

|| Branch || CI ||
| [3.0|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.0-14008] | [!https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.0-14008.svg?style=svg!|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.0-14008/] | 
| [3.11|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.11-14008] | [!https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.1-14008.svg?style=svg!|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.11-14008/]| 

I was hoping to actually have a solution to un-breaking the broken 3.0 sstables in the same patch, but it's proving to be more difficult than I anticipated. I haven't yet tried to make some sample sstables for regression tests, I agree it'd be nice to have those. 

Please glance at the code, and I'll work on the regression sstables before committing.

> RTs at index boundaries in 2.x sstables can create unexpected CQL row in 3.x
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14008
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14008
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Jeff Jirsa
>            Assignee: Jeff Jirsa
>              Labels: correctness
>             Fix For: 3.0.x, 3.11.x
>
>
> In 2.1/2.2, it is possible for a range tombstone that isn't a row deletion and isn't a complex deletion to appear between two cells with the same clustering. The 8099 legacy code incorrectly treats the two (non-RT) cells as two distinct CQL rows, despite having the same clustering prefix.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org