You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by hx...@apache.org on 2022/12/01 02:20:36 UTC

[flink] 02/03: [FLINK-29155][python] Change default KEEP_ALIVE_TIME_SEC to 19

This is an automated email from the ASF dual-hosted git repository.

hxb pushed a commit to branch release-1.15
in repository https://gitbox.apache.org/repos/asf/flink.git

commit 6659d0049d9270173458b44fa87dd5317e9c6638
Author: huangxingbo <hx...@apache.org>
AuthorDate: Wed Nov 30 19:02:29 2022 +0800

    [FLINK-29155][python] Change default KEEP_ALIVE_TIME_SEC to 19
    
    The BDP ping period is locally-decided and the keep alive time is 20 seconds in client side,
    so we choose the server to allow pings every 19 seconds.
    
    This closes #21430
---
 .../java/org/apache/beam/runners/fnexecution/ServerFactory.java    | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/flink-python/src/main/java/org/apache/beam/runners/fnexecution/ServerFactory.java b/flink-python/src/main/java/org/apache/beam/runners/fnexecution/ServerFactory.java
index 7a86c399a0f..e2b6c5400f9 100644
--- a/flink-python/src/main/java/org/apache/beam/runners/fnexecution/ServerFactory.java
+++ b/flink-python/src/main/java/org/apache/beam/runners/fnexecution/ServerFactory.java
@@ -42,9 +42,16 @@ import java.util.function.Supplier;
 
 import static org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkArgument;
 
+// This class is copied from Beam's org.apache.beam.runners.fnexecution.ServerFactory,
+// can be removed after https://github.com/apache/beam/issues/21598 is fixed.
+//
+// Changed lines: 53~55
+
 /** A {@link Server gRPC server} factory. */
 public abstract class ServerFactory {
 
+    // The BDP ping period is locally-decided and the keep alive time is 20 seconds in client
+    // side, so we choose the server to allow pings every 19 seconds.
     private static final int KEEP_ALIVE_TIME_SEC = 19;
 
     /** Create a default {@link InetSocketAddressServerFactory}. */