You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by fe...@apache.org on 2007/11/14 21:57:56 UTC
svn commit: r595054 -
/directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/aci/ProtectedItem.java
Author: felixk
Date: Wed Nov 14 12:57:51 2007
New Revision: 595054
URL: http://svn.apache.org/viewvc?rev=595054&view=rev
Log:
equals() method does not check for null argument
This implementation of equals(Object) violates the contract defined by java.lang.Object.equals() because it does not check for null being passed as the argument. All equals() methods should return false if passed a null value.
Modified:
directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/aci/ProtectedItem.java
Modified: directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/aci/ProtectedItem.java
URL: http://svn.apache.org/viewvc/directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/aci/ProtectedItem.java?rev=595054&r1=595053&r2=595054&view=diff
==============================================================================
--- directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/aci/ProtectedItem.java (original)
+++ directory/shared/branches/bigbang/ldap/src/main/java/org/apache/directory/shared/ldap/aci/ProtectedItem.java Wed Nov 14 12:57:51 2007
@@ -234,6 +234,11 @@
return true;
}
+ if ( o == null )
+ {
+ return false;
+ }
+
if ( getClass().isAssignableFrom( o.getClass() ) )
{
AttributeTypeProtectedItem that = ( AttributeTypeProtectedItem ) o;