You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2014/07/28 21:50:54 UTC
svn commit: r1614151 - in
/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress:
archivers/arj/ archivers/tar/ archivers/zip/ compressors/deflate/
compressors/snappy/
Author: sebb
Date: Mon Jul 28 19:50:54 2014
New Revision: 1614151
URL: http://svn.apache.org/r1614151
Log:
Close resources
Modified:
commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/arj/ArjArchiveInputStreamTest.java
commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStreamTest.java
commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ExplodeSupportTest.java
commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/compressors/deflate/DeflateCompressorOutputStreamTest.java
commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/compressors/snappy/FramedSnappyCompressorInputStreamTest.java
Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/arj/ArjArchiveInputStreamTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/arj/ArjArchiveInputStreamTest.java?rev=1614151&r1=1614150&r2=1614151&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/arj/ArjArchiveInputStreamTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/arj/ArjArchiveInputStreamTest.java Mon Jul 28 19:50:54 2014
@@ -60,6 +60,7 @@ public class ArjArchiveInputStreamTest e
cal.set(2008, 9, 6, 23, 50, 52);
cal.set(Calendar.MILLISECOND, 0);
assertEquals(cal.getTime(), entry.getLastModifiedDate());
+ in.close();
}
public void testReadingOfAttributesUnixVersion() throws Exception {
@@ -72,5 +73,6 @@ public class ArjArchiveInputStreamTest e
cal.set(2008, 9, 6, 21, 50, 52);
cal.set(Calendar.MILLISECOND, 0);
assertEquals(cal.getTime(), entry.getLastModifiedDate());
+ in.close();
}
}
Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStreamTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStreamTest.java?rev=1614151&r1=1614150&r2=1614151&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStreamTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveInputStreamTest.java Mon Jul 28 19:50:54 2014
@@ -202,6 +202,7 @@ public class TarArchiveInputStreamTest {
entry = tar.getNextTarEntry();
}
assertEquals(31, count);
+ tar.close();
} catch (IOException e) {
fail("COMPRESS-245: " + e.getMessage());
} finally {
Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ExplodeSupportTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ExplodeSupportTest.java?rev=1614151&r1=1614150&r2=1614151&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ExplodeSupportTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ExplodeSupportTest.java Mon Jul 28 19:50:54 2014
@@ -47,6 +47,7 @@ public class ExplodeSupportTest extends
out.flush();
assertEquals("CRC32", entry.getCrc(), out.getChecksum().getValue());
+ zip.close();
}
public void testArchiveWithImplodeCompression4K2Trees() throws IOException {
Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/compressors/deflate/DeflateCompressorOutputStreamTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/compressors/deflate/DeflateCompressorOutputStreamTest.java?rev=1614151&r1=1614150&r2=1614151&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/compressors/deflate/DeflateCompressorOutputStreamTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/compressors/deflate/DeflateCompressorOutputStreamTest.java Mon Jul 28 19:50:54 2014
@@ -34,6 +34,7 @@ public class DeflateCompressorOutputStre
cos.flush();
cos.finish();
Assert.assertTrue(bos.toByteArray().length > 0);
+ cos.close();
}
}
Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/compressors/snappy/FramedSnappyCompressorInputStreamTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/compressors/snappy/FramedSnappyCompressorInputStreamTest.java?rev=1614151&r1=1614150&r2=1614151&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/compressors/snappy/FramedSnappyCompressorInputStreamTest.java (original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/compressors/snappy/FramedSnappyCompressorInputStreamTest.java Mon Jul 28 19:50:54 2014
@@ -152,6 +152,7 @@ public final class FramedSnappyCompresso
new FramedSnappyCompressorInputStream(new ByteArrayInputStream(input));
in.read();
fail("expected an exception");
+ in.close();
} catch (IOException ex) {
assertTrue(ex.getMessage().indexOf("unskippable chunk") > -1);
}