[jira] [Commented] (HADOOP-7685) Issues with hadoop-common-project\hadoop-common\src\main\packages\hadoop-setup-conf.sh file

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-7685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119663#comment-13119663 ] 

Hadoop QA commented on HADOOP-7685:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12496914/HADOOP-7685-0.20-security.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/258//console

This message is automatically generated.
                
> Issues with hadoop-common-project\hadoop-common\src\main\packages\hadoop-setup-conf.sh file 
> --------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7685
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7685
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.20.205.0, 0.23.0
>            Reporter: Devaraj K
>            Assignee: Eric Yang
>         Attachments: HADOOP-7685-0.20-security.patch, HADOOP-7685-trunk.patch, HADOOP-7685.patch, HADOOP-7685.patch
>
>
> hadoop-common-project\hadoop-common\src\main\packages\hadoop-setup-conf.sh has following issues
> 1. check_permission does not work as expected if there are two folders with $NAME as part of their name inside $PARENT
> e.g. /home/hadoop/conf, /home/hadoop/someconf, 
> The result of `ls -ln $PARENT | grep -w $NAME| awk '{print $3}'` is non zero..it is 0 0 and hence the following if check becomes true.
> {code:xml}
> if [ "$OWNER" != "0" ]; then
> RESULT=1
> break
> fi 
> {code}
> 2. Spelling mistake
> {code:xml}
> HADDOP_DN_ADDR="0.0.0.0:50010"
> {code}
> it should be 
> {code:xml}
> HADOOP_DN_ADDR="0.0.0.0:50010"
> {code}
> 3. HADOOP_SNN_HOST is not set due to which the hdfs-site.xml contains following configuration
> {code:xml}
> <property>
> <name>dfs.namenode.http-address</name>
> <value>:50070</value>
> <description>
> The address and the base port where the dfs namenode web ui will listen on.
> If the port is 0 then the server will start on a free port.
> </description>
> </property>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira