You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/12/18 08:14:24 UTC

[kudu-CR] KUDU-3027 Some fixing for kudu on aarch64 

huangtianhua223@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14921


Change subject: KUDU-3027 Some fixing for kudu on aarch64
......................................................................

KUDU-3027 Some fixing for kudu on aarch64

This changes:
1. Don't set compiler flag with '-msse4.2' for aarch64
2. Modify 'LLVM_TARGETS_TO_BUILD' to include AArch64 target

Change-Id: I710bfb6325e588b7bc801a6350cbec9432e48449
---
M CMakeLists.txt
M thirdparty/build-definitions.sh
2 files changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/14921/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I710bfb6325e588b7bc801a6350cbec9432e48449
Gerrit-Change-Number: 14921
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>

[kudu-CR] KUDU-3027 Some fixing for kudu on aarch64

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14921

to look at the new patch set (#2).

Change subject: KUDU-3027 Some fixing for kudu on aarch64
......................................................................

KUDU-3027 Some fixing for kudu on aarch64

This changes:
1. Don't set compiler flag with '-msse4.2' for aarch64
2. Modify 'LLVM_TARGETS_TO_BUILD' to include AArch64 target

Change-Id: I710bfb6325e588b7bc801a6350cbec9432e48449
---
M CMakeLists.txt
M thirdparty/build-definitions.sh
2 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/14921/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710bfb6325e588b7bc801a6350cbec9432e48449
Gerrit-Change-Number: 14921
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3027 Some fixing for kudu on aarch64

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.

Change subject: KUDU-3027 Some fixing for kudu on aarch64
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/14921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I710bfb6325e588b7bc801a6350cbec9432e48449
Gerrit-Change-Number: 14921
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3027 Some fixing for kudu on aarch64

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14921 )

Change subject: KUDU-3027 Some fixing for kudu on aarch64
......................................................................


Patch Set 2: Verified+1 Code-Review+2

Overriding Jenkins, unrelated test failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/14921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I710bfb6325e588b7bc801a6350cbec9432e48449
Gerrit-Change-Number: 14921
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Dec 2019 17:25:16 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3027 Some fixing for kudu on aarch64

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14921 )

Change subject: KUDU-3027 Some fixing for kudu on aarch64
......................................................................

KUDU-3027 Some fixing for kudu on aarch64

This changes:
1. Don't set compiler flag with '-msse4.2' for aarch64
2. Modify 'LLVM_TARGETS_TO_BUILD' to include AArch64 target

Change-Id: I710bfb6325e588b7bc801a6350cbec9432e48449
Reviewed-on: http://gerrit.cloudera.org:8080/14921
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M CMakeLists.txt
M thirdparty/build-definitions.sh
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14921
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I710bfb6325e588b7bc801a6350cbec9432e48449
Gerrit-Change-Number: 14921
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)