You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GayathriMurali <gi...@git.apache.org> on 2016/03/07 03:20:58 UTC
[GitHub] spark pull request: [SPARK-13034] Add export/import for all estima...
GitHub user GayathriMurali opened a pull request:
https://github.com/apache/spark/pull/11552
[SPARK-13034] Add export/import for all estimators and transformers(w…
## What changes were proposed in this pull request?
Add export/import for all estimators and transformers(which have Scala implementation) under pyspark/ml/classification.py.
JIRA : https://issues.apache.org/jira/browse/SPARK-13034
## How was this patch tested?
Unit tests added to tests.py
…hich have Scala implementation) under pyspark/ml/classification.py
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GayathriMurali/spark SPARK-13034
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11552.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11552
----
commit 4760bcb73913dcb80f2419ce0fc989a119f02044
Author: GayathriMurali <ga...@gmail.com>
Date: 2016-03-07T02:18:18Z
[SPARK-13034] Add export/import for all estimators and transformers(which have Scala implementation) under pyspark/ml/classification.py
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13034] Add export/import for all estima...
Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali commented on the pull request:
https://github.com/apache/spark/pull/11552#issuecomment-194501286
@yanboliang Can you please help review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13034] Add export/import for all estima...
Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali commented on the pull request:
https://github.com/apache/spark/pull/11552#issuecomment-193940338
@wangmiao1981 Sorry about that. I did see your comments and since there wasnt any pull request, I went ahead and sent one. We could definitely work together to get this merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13034] Add export/import for all estima...
Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/11552#issuecomment-194441901
@GayathriMurali Thanks! I see you add one more classification other than logisticregression and navie bayes. When I was working on my code base, that classifier doesn't have scala import/export support yet. I think yours is more recent than mine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13034] Add export/import for all estima...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/11552#issuecomment-194531086
@GayathriMurali @wangmiao1981 It will be great to add persistence for LogisticRegression and NaiveBayes. The other algorithms will need to wait since they do not yet have Scala support for persistence. Could you please reconcile your 2 PRs? It would be great to close one and have both of you collaborate on 1 PR. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13034] Add export/import for all estima...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11552#issuecomment-193057635
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13034] Add export/import for all estima...
Posted by wangmiao1981 <gi...@git.apache.org>.
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/11552#issuecomment-193931859
Hi Gayathri,
I put my comments in the JIRA about 2 weeks ago and worked with Yanbo on putting some code.
Can we work together to get it merged? I can close my PR if needed. By the way, what is the best way to notify people that I am working on some JIRA and we will not spend time on the same JIRA in the future.
Thanks!
Miao
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13034] Add export/import for all estima...
Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali commented on the pull request:
https://github.com/apache/spark/pull/11552#issuecomment-195207183
@wangmiao1981 I can close my PR and we can may be work on yours?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13034] Add export/import for all estima...
Posted by GayathriMurali <gi...@git.apache.org>.
Github user GayathriMurali closed the pull request at:
https://github.com/apache/spark/pull/11552
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org