[jira] [Updated] (TEZ-3432) Add unit test for session timeout

["Sreenath Somarajapuram (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TEZ-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sreenath Somarajapuram updated TEZ-3432:
----------------------------------------
    Attachment: TEZ-3432.4.patch

Thanks [~hitesh]
Attaching a fresh patch with the comments addressed.

bq. was this tried on a VM
It was run on an open-stack machine. Have bumped the buffer to 20%, is that good enough?

bq. there should be checks to ensure that diagnostics is not null and not empty.
In the current patch, isn't Assert.assertTrue(diagnostics.contains("Session timed out")); enough for the same.

As getDiagnosticParams accepts a string now, its implementation have become more generic. So should we put it in some shared class for helper functions.

> Add unit test for session timeout
> ---------------------------------
>
>                 Key: TEZ-3432
>                 URL: https://issues.apache.org/jira/browse/TEZ-3432
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Sushmitha Sreenivasan
>            Assignee: Sreenath Somarajapuram
>              Labels: newbie
>         Attachments: TEZ-3432.1.patch, TEZ-3432.2.patch, TEZ-3432.3.patch, TEZ-3432.4.patch
>
>
> Add unit test which sets tez.session.am.dag.submit.timeout.secs to say 5 secs and checking if dag submission timeouts after the configured time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)