You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2017/07/03 21:10:50 UTC
Git protected branches
Hi,
I don't know current configuration but I would like to ensure that our
release branches, that is master and branch-xx are 'protected'.
I mean at least that 'force push' must be forbidden to everyone.
In github it is simple to enable such protection, see
https://help.github.com/articles/about-protected-branches/
I don't want to try btyy performing a force push. Maybe we can ask infra
about current configuration
Thoughts?
Enrico
--
-- Enrico Olivelli
Re: Git protected branches
Posted by Sijie Guo <gu...@gmail.com>.
I don't think INFRA extends such admin privileges to projects. I think this
is how Gitbox is working. But if we want PMC/projects want to have more
privileges, that might require broader discussions in the ASF.
- Sijie
On Fri, Jul 14, 2017 at 3:13 PM, Enrico Olivelli <eo...@gmail.com>
wrote:
> Yes Flavio,
> it is a pity that we cannot ever see in readonly mode the actual
> configuration.
> If you look at the issue, the operator attached a screenshot in order to
> let me see the actual configuration
>
> Maybe as PMC you or at least Sijie can ask for more privileges
>
> -- Enrico
>
> 2017-07-14 9:10 GMT+02:00 Flavio Junqueira <fp...@apache.org>:
>
> > It's kind of odd that we have to go through infra to do this. Such a
> > configuration feels like should be under the control of committers or at
> > least the PMC.
> >
> > Thanks for doing it in any case, Enrico.
> >
> > -Flavio
> >
> > > On 13 Jul 2017, at 01:55, Jia Zhai <zh...@gmail.com> wrote:
> > >
> > > 👍
> > >
> > > On Thu, Jul 13, 2017 at 5:34 AM, Venkateswara Rao Jujjuri <
> > jujjuri@gmail.com
> > >> wrote:
> > >
> > >> Awesome. !!
> > >>
> > >> On Tue, Jul 11, 2017 at 6:06 AM, Enrico Olivelli <eolivelli@gmail.com
> >
> > >> wrote:
> > >>
> > >>> The ticket has been closed.
> > >>> The protection is on
> > >>>
> > >>> -- Enrico
> > >>>
> > >>> 2017-07-07 11:22 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
> > >>>
> > >>>>
> > >>>>
> > >>>> 2017-07-07 1:51 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> > >>>>
> > >>>>> +1 for disable force push to master
> > >>>>>
> > >>>>
> > >>>>
> > >>>> this is the issue:
> > >>>> https://issues.apache.org/jira/browse/INFRA-14535
> > >>>>
> > >>>> I will send updates
> > >>>>
> > >>>> - Enrico
> > >>>>
> > >>>>
> > >>>>>
> > >>>>> On Thu, Jul 6, 2017 at 1:16 PM, Enrico Olivelli <
> eolivelli@gmail.com
> > >
> > >>>>> wrote:
> > >>>>>
> > >>>>>> Other thoughts?
> > >>>>>> If there is no objection I would like to enable the force push
> > >> block.
> > >>>>> Next
> > >>>>>> week
> > >>>>>>
> > >>>>>> Enrico
> > >>>>>>
> > >>>>>> Il mar 4 lug 2017, 10:28 Enrico Olivelli <eo...@gmail.com> ha
> > >>>>> scritto:
> > >>>>>>
> > >>>>>>> 2017-07-04 5:51 GMT+02:00 Jia Zhai <zh...@gmail.com>:
> > >>>>>>>> Agree to have them protected.
> > >>>>>>>> Currently, seems these branches are not protected, at least
> > >> master
> > >>>>>> branch
> > >>>>>>>> is not. The merge button is still available even "Jenkins: Maven
> > >>>>> clean
> > >>>>>>>> install — Build finished." in some of PRs
> > >>>>>>>> <https://github.com/apache/bookkeeper/pulls>
> > >>>>>>>> We may first need to make the test stable.
> > >>>>>>>
> > >>>>>>> I think that is it enough to only protect against "force push",
> > >>> which
> > >>>>>>> makes impossible for anyone to 'rewrite' the "public history" of
> > >> the
> > >>>>>>> project
> > >>>>>>> Other checks are performed by QA test and by the committer who
> > >> takes
> > >>>>>>> responsibility for pushing the patch in the repo
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> -- Enrico
> > >>>>>>>
> > >>>>>>>
> > >>>>>>>>
> > >>>>>>>> On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <
> > >>>>> eolivelli@gmail.com>
> > >>>>>>> wrote:
> > >>>>>>>>
> > >>>>>>>>> Hi,
> > >>>>>>>>> I don't know current configuration but I would like to ensure
> > >>> that
> > >>>>> our
> > >>>>>>>>> release branches, that is master and branch-xx are 'protected'.
> > >>>>>>>>> I mean at least that 'force push' must be forbidden to
> > >> everyone.
> > >>>>>>>>>
> > >>>>>>>>> In github it is simple to enable such protection, see
> > >>>>>>>>> https://help.github.com/articles/about-protected-branches/
> > >>>>>>>>>
> > >>>>>>>>> I don't want to try btyy performing a force push. Maybe we can
> > >>> ask
> > >>>>>> infra
> > >>>>>>>>> about current configuration
> > >>>>>>>>>
> > >>>>>>>>> Thoughts?
> > >>>>>>>>>
> > >>>>>>>>> Enrico
> > >>>>>>>>> --
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> -- Enrico Olivelli
> > >>>>>>>>>
> > >>>>>>>
> > >>>>>> --
> > >>>>>>
> > >>>>>>
> > >>>>>> -- Enrico Olivelli
> > >>>>>>
> > >>>>>
> > >>>>
> > >>>>
> > >>>
> > >>
> > >>
> > >>
> > >> --
> > >> Jvrao
> > >> ---
> > >> First they ignore you, then they laugh at you, then they fight you,
> then
> > >> you win. - Mahatma Gandhi
> > >>
> >
> >
>
Re: Git protected branches
Posted by Enrico Olivelli <eo...@gmail.com>.
Yes Flavio,
it is a pity that we cannot ever see in readonly mode the actual
configuration.
If you look at the issue, the operator attached a screenshot in order to
let me see the actual configuration
Maybe as PMC you or at least Sijie can ask for more privileges
-- Enrico
2017-07-14 9:10 GMT+02:00 Flavio Junqueira <fp...@apache.org>:
> It's kind of odd that we have to go through infra to do this. Such a
> configuration feels like should be under the control of committers or at
> least the PMC.
>
> Thanks for doing it in any case, Enrico.
>
> -Flavio
>
> > On 13 Jul 2017, at 01:55, Jia Zhai <zh...@gmail.com> wrote:
> >
> > 👍
> >
> > On Thu, Jul 13, 2017 at 5:34 AM, Venkateswara Rao Jujjuri <
> jujjuri@gmail.com
> >> wrote:
> >
> >> Awesome. !!
> >>
> >> On Tue, Jul 11, 2017 at 6:06 AM, Enrico Olivelli <eo...@gmail.com>
> >> wrote:
> >>
> >>> The ticket has been closed.
> >>> The protection is on
> >>>
> >>> -- Enrico
> >>>
> >>> 2017-07-07 11:22 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
> >>>
> >>>>
> >>>>
> >>>> 2017-07-07 1:51 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> >>>>
> >>>>> +1 for disable force push to master
> >>>>>
> >>>>
> >>>>
> >>>> this is the issue:
> >>>> https://issues.apache.org/jira/browse/INFRA-14535
> >>>>
> >>>> I will send updates
> >>>>
> >>>> - Enrico
> >>>>
> >>>>
> >>>>>
> >>>>> On Thu, Jul 6, 2017 at 1:16 PM, Enrico Olivelli <eolivelli@gmail.com
> >
> >>>>> wrote:
> >>>>>
> >>>>>> Other thoughts?
> >>>>>> If there is no objection I would like to enable the force push
> >> block.
> >>>>> Next
> >>>>>> week
> >>>>>>
> >>>>>> Enrico
> >>>>>>
> >>>>>> Il mar 4 lug 2017, 10:28 Enrico Olivelli <eo...@gmail.com> ha
> >>>>> scritto:
> >>>>>>
> >>>>>>> 2017-07-04 5:51 GMT+02:00 Jia Zhai <zh...@gmail.com>:
> >>>>>>>> Agree to have them protected.
> >>>>>>>> Currently, seems these branches are not protected, at least
> >> master
> >>>>>> branch
> >>>>>>>> is not. The merge button is still available even "Jenkins: Maven
> >>>>> clean
> >>>>>>>> install — Build finished." in some of PRs
> >>>>>>>> <https://github.com/apache/bookkeeper/pulls>
> >>>>>>>> We may first need to make the test stable.
> >>>>>>>
> >>>>>>> I think that is it enough to only protect against "force push",
> >>> which
> >>>>>>> makes impossible for anyone to 'rewrite' the "public history" of
> >> the
> >>>>>>> project
> >>>>>>> Other checks are performed by QA test and by the committer who
> >> takes
> >>>>>>> responsibility for pushing the patch in the repo
> >>>>>>>
> >>>>>>>
> >>>>>>> -- Enrico
> >>>>>>>
> >>>>>>>
> >>>>>>>>
> >>>>>>>> On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <
> >>>>> eolivelli@gmail.com>
> >>>>>>> wrote:
> >>>>>>>>
> >>>>>>>>> Hi,
> >>>>>>>>> I don't know current configuration but I would like to ensure
> >>> that
> >>>>> our
> >>>>>>>>> release branches, that is master and branch-xx are 'protected'.
> >>>>>>>>> I mean at least that 'force push' must be forbidden to
> >> everyone.
> >>>>>>>>>
> >>>>>>>>> In github it is simple to enable such protection, see
> >>>>>>>>> https://help.github.com/articles/about-protected-branches/
> >>>>>>>>>
> >>>>>>>>> I don't want to try btyy performing a force push. Maybe we can
> >>> ask
> >>>>>> infra
> >>>>>>>>> about current configuration
> >>>>>>>>>
> >>>>>>>>> Thoughts?
> >>>>>>>>>
> >>>>>>>>> Enrico
> >>>>>>>>> --
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> -- Enrico Olivelli
> >>>>>>>>>
> >>>>>>>
> >>>>>> --
> >>>>>>
> >>>>>>
> >>>>>> -- Enrico Olivelli
> >>>>>>
> >>>>>
> >>>>
> >>>>
> >>>
> >>
> >>
> >>
> >> --
> >> Jvrao
> >> ---
> >> First they ignore you, then they laugh at you, then they fight you, then
> >> you win. - Mahatma Gandhi
> >>
>
>
Re: Git protected branches
Posted by Flavio Junqueira <fp...@apache.org>.
It's kind of odd that we have to go through infra to do this. Such a configuration feels like should be under the control of committers or at least the PMC.
Thanks for doing it in any case, Enrico.
-Flavio
> On 13 Jul 2017, at 01:55, Jia Zhai <zh...@gmail.com> wrote:
>
> 👍
>
> On Thu, Jul 13, 2017 at 5:34 AM, Venkateswara Rao Jujjuri <jujjuri@gmail.com
>> wrote:
>
>> Awesome. !!
>>
>> On Tue, Jul 11, 2017 at 6:06 AM, Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>>> The ticket has been closed.
>>> The protection is on
>>>
>>> -- Enrico
>>>
>>> 2017-07-07 11:22 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>>>
>>>>
>>>>
>>>> 2017-07-07 1:51 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>>>>
>>>>> +1 for disable force push to master
>>>>>
>>>>
>>>>
>>>> this is the issue:
>>>> https://issues.apache.org/jira/browse/INFRA-14535
>>>>
>>>> I will send updates
>>>>
>>>> - Enrico
>>>>
>>>>
>>>>>
>>>>> On Thu, Jul 6, 2017 at 1:16 PM, Enrico Olivelli <eo...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Other thoughts?
>>>>>> If there is no objection I would like to enable the force push
>> block.
>>>>> Next
>>>>>> week
>>>>>>
>>>>>> Enrico
>>>>>>
>>>>>> Il mar 4 lug 2017, 10:28 Enrico Olivelli <eo...@gmail.com> ha
>>>>> scritto:
>>>>>>
>>>>>>> 2017-07-04 5:51 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>>>>>>>> Agree to have them protected.
>>>>>>>> Currently, seems these branches are not protected, at least
>> master
>>>>>> branch
>>>>>>>> is not. The merge button is still available even "Jenkins: Maven
>>>>> clean
>>>>>>>> install — Build finished." in some of PRs
>>>>>>>> <https://github.com/apache/bookkeeper/pulls>
>>>>>>>> We may first need to make the test stable.
>>>>>>>
>>>>>>> I think that is it enough to only protect against "force push",
>>> which
>>>>>>> makes impossible for anyone to 'rewrite' the "public history" of
>> the
>>>>>>> project
>>>>>>> Other checks are performed by QA test and by the committer who
>> takes
>>>>>>> responsibility for pushing the patch in the repo
>>>>>>>
>>>>>>>
>>>>>>> -- Enrico
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <
>>>>> eolivelli@gmail.com>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>> I don't know current configuration but I would like to ensure
>>> that
>>>>> our
>>>>>>>>> release branches, that is master and branch-xx are 'protected'.
>>>>>>>>> I mean at least that 'force push' must be forbidden to
>> everyone.
>>>>>>>>>
>>>>>>>>> In github it is simple to enable such protection, see
>>>>>>>>> https://help.github.com/articles/about-protected-branches/
>>>>>>>>>
>>>>>>>>> I don't want to try btyy performing a force push. Maybe we can
>>> ask
>>>>>> infra
>>>>>>>>> about current configuration
>>>>>>>>>
>>>>>>>>> Thoughts?
>>>>>>>>>
>>>>>>>>> Enrico
>>>>>>>>> --
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> -- Enrico Olivelli
>>>>>>>>>
>>>>>>>
>>>>>> --
>>>>>>
>>>>>>
>>>>>> -- Enrico Olivelli
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>>
>> --
>> Jvrao
>> ---
>> First they ignore you, then they laugh at you, then they fight you, then
>> you win. - Mahatma Gandhi
>>
Re: Git protected branches
Posted by Jia Zhai <zh...@gmail.com>.
👍
On Thu, Jul 13, 2017 at 5:34 AM, Venkateswara Rao Jujjuri <jujjuri@gmail.com
> wrote:
> Awesome. !!
>
> On Tue, Jul 11, 2017 at 6:06 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > The ticket has been closed.
> > The protection is on
> >
> > -- Enrico
> >
> > 2017-07-07 11:22 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
> >
> > >
> > >
> > > 2017-07-07 1:51 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> > >
> > >> +1 for disable force push to master
> > >>
> > >
> > >
> > > this is the issue:
> > > https://issues.apache.org/jira/browse/INFRA-14535
> > >
> > > I will send updates
> > >
> > > - Enrico
> > >
> > >
> > >>
> > >> On Thu, Jul 6, 2017 at 1:16 PM, Enrico Olivelli <eo...@gmail.com>
> > >> wrote:
> > >>
> > >> > Other thoughts?
> > >> > If there is no objection I would like to enable the force push
> block.
> > >> Next
> > >> > week
> > >> >
> > >> > Enrico
> > >> >
> > >> > Il mar 4 lug 2017, 10:28 Enrico Olivelli <eo...@gmail.com> ha
> > >> scritto:
> > >> >
> > >> > > 2017-07-04 5:51 GMT+02:00 Jia Zhai <zh...@gmail.com>:
> > >> > > > Agree to have them protected.
> > >> > > > Currently, seems these branches are not protected, at least
> master
> > >> > branch
> > >> > > > is not. The merge button is still available even "Jenkins: Maven
> > >> clean
> > >> > > > install — Build finished." in some of PRs
> > >> > > > <https://github.com/apache/bookkeeper/pulls>
> > >> > > > We may first need to make the test stable.
> > >> > >
> > >> > > I think that is it enough to only protect against "force push",
> > which
> > >> > > makes impossible for anyone to 'rewrite' the "public history" of
> the
> > >> > > project
> > >> > > Other checks are performed by QA test and by the committer who
> takes
> > >> > > responsibility for pushing the patch in the repo
> > >> > >
> > >> > >
> > >> > > -- Enrico
> > >> > >
> > >> > >
> > >> > > >
> > >> > > > On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <
> > >> eolivelli@gmail.com>
> > >> > > wrote:
> > >> > > >
> > >> > > >> Hi,
> > >> > > >> I don't know current configuration but I would like to ensure
> > that
> > >> our
> > >> > > >> release branches, that is master and branch-xx are 'protected'.
> > >> > > >> I mean at least that 'force push' must be forbidden to
> everyone.
> > >> > > >>
> > >> > > >> In github it is simple to enable such protection, see
> > >> > > >> https://help.github.com/articles/about-protected-branches/
> > >> > > >>
> > >> > > >> I don't want to try btyy performing a force push. Maybe we can
> > ask
> > >> > infra
> > >> > > >> about current configuration
> > >> > > >>
> > >> > > >> Thoughts?
> > >> > > >>
> > >> > > >> Enrico
> > >> > > >> --
> > >> > > >>
> > >> > > >>
> > >> > > >> -- Enrico Olivelli
> > >> > > >>
> > >> > >
> > >> > --
> > >> >
> > >> >
> > >> > -- Enrico Olivelli
> > >> >
> > >>
> > >
> > >
> >
>
>
>
> --
> Jvrao
> ---
> First they ignore you, then they laugh at you, then they fight you, then
> you win. - Mahatma Gandhi
>
Re: Git protected branches
Posted by Venkateswara Rao Jujjuri <ju...@gmail.com>.
Awesome. !!
On Tue, Jul 11, 2017 at 6:06 AM, Enrico Olivelli <eo...@gmail.com>
wrote:
> The ticket has been closed.
> The protection is on
>
> -- Enrico
>
> 2017-07-07 11:22 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>
> >
> >
> > 2017-07-07 1:51 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> >
> >> +1 for disable force push to master
> >>
> >
> >
> > this is the issue:
> > https://issues.apache.org/jira/browse/INFRA-14535
> >
> > I will send updates
> >
> > - Enrico
> >
> >
> >>
> >> On Thu, Jul 6, 2017 at 1:16 PM, Enrico Olivelli <eo...@gmail.com>
> >> wrote:
> >>
> >> > Other thoughts?
> >> > If there is no objection I would like to enable the force push block.
> >> Next
> >> > week
> >> >
> >> > Enrico
> >> >
> >> > Il mar 4 lug 2017, 10:28 Enrico Olivelli <eo...@gmail.com> ha
> >> scritto:
> >> >
> >> > > 2017-07-04 5:51 GMT+02:00 Jia Zhai <zh...@gmail.com>:
> >> > > > Agree to have them protected.
> >> > > > Currently, seems these branches are not protected, at least master
> >> > branch
> >> > > > is not. The merge button is still available even "Jenkins: Maven
> >> clean
> >> > > > install — Build finished." in some of PRs
> >> > > > <https://github.com/apache/bookkeeper/pulls>
> >> > > > We may first need to make the test stable.
> >> > >
> >> > > I think that is it enough to only protect against "force push",
> which
> >> > > makes impossible for anyone to 'rewrite' the "public history" of the
> >> > > project
> >> > > Other checks are performed by QA test and by the committer who takes
> >> > > responsibility for pushing the patch in the repo
> >> > >
> >> > >
> >> > > -- Enrico
> >> > >
> >> > >
> >> > > >
> >> > > > On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <
> >> eolivelli@gmail.com>
> >> > > wrote:
> >> > > >
> >> > > >> Hi,
> >> > > >> I don't know current configuration but I would like to ensure
> that
> >> our
> >> > > >> release branches, that is master and branch-xx are 'protected'.
> >> > > >> I mean at least that 'force push' must be forbidden to everyone.
> >> > > >>
> >> > > >> In github it is simple to enable such protection, see
> >> > > >> https://help.github.com/articles/about-protected-branches/
> >> > > >>
> >> > > >> I don't want to try btyy performing a force push. Maybe we can
> ask
> >> > infra
> >> > > >> about current configuration
> >> > > >>
> >> > > >> Thoughts?
> >> > > >>
> >> > > >> Enrico
> >> > > >> --
> >> > > >>
> >> > > >>
> >> > > >> -- Enrico Olivelli
> >> > > >>
> >> > >
> >> > --
> >> >
> >> >
> >> > -- Enrico Olivelli
> >> >
> >>
> >
> >
>
--
Jvrao
---
First they ignore you, then they laugh at you, then they fight you, then
you win. - Mahatma Gandhi
Re: Git protected branches
Posted by Enrico Olivelli <eo...@gmail.com>.
The ticket has been closed.
The protection is on
-- Enrico
2017-07-07 11:22 GMT+02:00 Enrico Olivelli <eo...@gmail.com>:
>
>
> 2017-07-07 1:51 GMT+02:00 Sijie Guo <gu...@gmail.com>:
>
>> +1 for disable force push to master
>>
>
>
> this is the issue:
> https://issues.apache.org/jira/browse/INFRA-14535
>
> I will send updates
>
> - Enrico
>
>
>>
>> On Thu, Jul 6, 2017 at 1:16 PM, Enrico Olivelli <eo...@gmail.com>
>> wrote:
>>
>> > Other thoughts?
>> > If there is no objection I would like to enable the force push block.
>> Next
>> > week
>> >
>> > Enrico
>> >
>> > Il mar 4 lug 2017, 10:28 Enrico Olivelli <eo...@gmail.com> ha
>> scritto:
>> >
>> > > 2017-07-04 5:51 GMT+02:00 Jia Zhai <zh...@gmail.com>:
>> > > > Agree to have them protected.
>> > > > Currently, seems these branches are not protected, at least master
>> > branch
>> > > > is not. The merge button is still available even "Jenkins: Maven
>> clean
>> > > > install — Build finished." in some of PRs
>> > > > <https://github.com/apache/bookkeeper/pulls>
>> > > > We may first need to make the test stable.
>> > >
>> > > I think that is it enough to only protect against "force push", which
>> > > makes impossible for anyone to 'rewrite' the "public history" of the
>> > > project
>> > > Other checks are performed by QA test and by the committer who takes
>> > > responsibility for pushing the patch in the repo
>> > >
>> > >
>> > > -- Enrico
>> > >
>> > >
>> > > >
>> > > > On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <
>> eolivelli@gmail.com>
>> > > wrote:
>> > > >
>> > > >> Hi,
>> > > >> I don't know current configuration but I would like to ensure that
>> our
>> > > >> release branches, that is master and branch-xx are 'protected'.
>> > > >> I mean at least that 'force push' must be forbidden to everyone.
>> > > >>
>> > > >> In github it is simple to enable such protection, see
>> > > >> https://help.github.com/articles/about-protected-branches/
>> > > >>
>> > > >> I don't want to try btyy performing a force push. Maybe we can ask
>> > infra
>> > > >> about current configuration
>> > > >>
>> > > >> Thoughts?
>> > > >>
>> > > >> Enrico
>> > > >> --
>> > > >>
>> > > >>
>> > > >> -- Enrico Olivelli
>> > > >>
>> > >
>> > --
>> >
>> >
>> > -- Enrico Olivelli
>> >
>>
>
>
Re: Git protected branches
Posted by Enrico Olivelli <eo...@gmail.com>.
2017-07-07 1:51 GMT+02:00 Sijie Guo <gu...@gmail.com>:
> +1 for disable force push to master
>
this is the issue:
https://issues.apache.org/jira/browse/INFRA-14535
I will send updates
- Enrico
>
> On Thu, Jul 6, 2017 at 1:16 PM, Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Other thoughts?
> > If there is no objection I would like to enable the force push block.
> Next
> > week
> >
> > Enrico
> >
> > Il mar 4 lug 2017, 10:28 Enrico Olivelli <eo...@gmail.com> ha
> scritto:
> >
> > > 2017-07-04 5:51 GMT+02:00 Jia Zhai <zh...@gmail.com>:
> > > > Agree to have them protected.
> > > > Currently, seems these branches are not protected, at least master
> > branch
> > > > is not. The merge button is still available even "Jenkins: Maven
> clean
> > > > install — Build finished." in some of PRs
> > > > <https://github.com/apache/bookkeeper/pulls>
> > > > We may first need to make the test stable.
> > >
> > > I think that is it enough to only protect against "force push", which
> > > makes impossible for anyone to 'rewrite' the "public history" of the
> > > project
> > > Other checks are performed by QA test and by the committer who takes
> > > responsibility for pushing the patch in the repo
> > >
> > >
> > > -- Enrico
> > >
> > >
> > > >
> > > > On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <eolivelli@gmail.com
> >
> > > wrote:
> > > >
> > > >> Hi,
> > > >> I don't know current configuration but I would like to ensure that
> our
> > > >> release branches, that is master and branch-xx are 'protected'.
> > > >> I mean at least that 'force push' must be forbidden to everyone.
> > > >>
> > > >> In github it is simple to enable such protection, see
> > > >> https://help.github.com/articles/about-protected-branches/
> > > >>
> > > >> I don't want to try btyy performing a force push. Maybe we can ask
> > infra
> > > >> about current configuration
> > > >>
> > > >> Thoughts?
> > > >>
> > > >> Enrico
> > > >> --
> > > >>
> > > >>
> > > >> -- Enrico Olivelli
> > > >>
> > >
> > --
> >
> >
> > -- Enrico Olivelli
> >
>
Re: Git protected branches
Posted by Sijie Guo <gu...@gmail.com>.
+1 for disable force push to master
On Thu, Jul 6, 2017 at 1:16 PM, Enrico Olivelli <eo...@gmail.com> wrote:
> Other thoughts?
> If there is no objection I would like to enable the force push block. Next
> week
>
> Enrico
>
> Il mar 4 lug 2017, 10:28 Enrico Olivelli <eo...@gmail.com> ha scritto:
>
> > 2017-07-04 5:51 GMT+02:00 Jia Zhai <zh...@gmail.com>:
> > > Agree to have them protected.
> > > Currently, seems these branches are not protected, at least master
> branch
> > > is not. The merge button is still available even "Jenkins: Maven clean
> > > install — Build finished." in some of PRs
> > > <https://github.com/apache/bookkeeper/pulls>
> > > We may first need to make the test stable.
> >
> > I think that is it enough to only protect against "force push", which
> > makes impossible for anyone to 'rewrite' the "public history" of the
> > project
> > Other checks are performed by QA test and by the committer who takes
> > responsibility for pushing the patch in the repo
> >
> >
> > -- Enrico
> >
> >
> > >
> > > On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> > >
> > >> Hi,
> > >> I don't know current configuration but I would like to ensure that our
> > >> release branches, that is master and branch-xx are 'protected'.
> > >> I mean at least that 'force push' must be forbidden to everyone.
> > >>
> > >> In github it is simple to enable such protection, see
> > >> https://help.github.com/articles/about-protected-branches/
> > >>
> > >> I don't want to try btyy performing a force push. Maybe we can ask
> infra
> > >> about current configuration
> > >>
> > >> Thoughts?
> > >>
> > >> Enrico
> > >> --
> > >>
> > >>
> > >> -- Enrico Olivelli
> > >>
> >
> --
>
>
> -- Enrico Olivelli
>
Re: Git protected branches
Posted by Enrico Olivelli <eo...@gmail.com>.
Other thoughts?
If there is no objection I would like to enable the force push block. Next
week
Enrico
Il mar 4 lug 2017, 10:28 Enrico Olivelli <eo...@gmail.com> ha scritto:
> 2017-07-04 5:51 GMT+02:00 Jia Zhai <zh...@gmail.com>:
> > Agree to have them protected.
> > Currently, seems these branches are not protected, at least master branch
> > is not. The merge button is still available even "Jenkins: Maven clean
> > install — Build finished." in some of PRs
> > <https://github.com/apache/bookkeeper/pulls>
> > We may first need to make the test stable.
>
> I think that is it enough to only protect against "force push", which
> makes impossible for anyone to 'rewrite' the "public history" of the
> project
> Other checks are performed by QA test and by the committer who takes
> responsibility for pushing the patch in the repo
>
>
> -- Enrico
>
>
> >
> > On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <eo...@gmail.com>
> wrote:
> >
> >> Hi,
> >> I don't know current configuration but I would like to ensure that our
> >> release branches, that is master and branch-xx are 'protected'.
> >> I mean at least that 'force push' must be forbidden to everyone.
> >>
> >> In github it is simple to enable such protection, see
> >> https://help.github.com/articles/about-protected-branches/
> >>
> >> I don't want to try btyy performing a force push. Maybe we can ask infra
> >> about current configuration
> >>
> >> Thoughts?
> >>
> >> Enrico
> >> --
> >>
> >>
> >> -- Enrico Olivelli
> >>
>
--
-- Enrico Olivelli
Re: Git protected branches
Posted by Enrico Olivelli <eo...@gmail.com>.
2017-07-04 5:51 GMT+02:00 Jia Zhai <zh...@gmail.com>:
> Agree to have them protected.
> Currently, seems these branches are not protected, at least master branch
> is not. The merge button is still available even "Jenkins: Maven clean
> install — Build finished." in some of PRs
> <https://github.com/apache/bookkeeper/pulls>
> We may first need to make the test stable.
I think that is it enough to only protect against "force push", which
makes impossible for anyone to 'rewrite' the "public history" of the
project
Other checks are performed by QA test and by the committer who takes
responsibility for pushing the patch in the repo
-- Enrico
>
> On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <eo...@gmail.com> wrote:
>
>> Hi,
>> I don't know current configuration but I would like to ensure that our
>> release branches, that is master and branch-xx are 'protected'.
>> I mean at least that 'force push' must be forbidden to everyone.
>>
>> In github it is simple to enable such protection, see
>> https://help.github.com/articles/about-protected-branches/
>>
>> I don't want to try btyy performing a force push. Maybe we can ask infra
>> about current configuration
>>
>> Thoughts?
>>
>> Enrico
>> --
>>
>>
>> -- Enrico Olivelli
>>
Re: Git protected branches
Posted by Jia Zhai <zh...@gmail.com>.
Agree to have them protected.
Currently, seems these branches are not protected, at least master branch
is not. The merge button is still available even "Jenkins: Maven clean
install — Build finished." in some of PRs
<https://github.com/apache/bookkeeper/pulls>
We may first need to make the test stable.
On Tue, Jul 4, 2017 at 5:10 AM, Enrico Olivelli <eo...@gmail.com> wrote:
> Hi,
> I don't know current configuration but I would like to ensure that our
> release branches, that is master and branch-xx are 'protected'.
> I mean at least that 'force push' must be forbidden to everyone.
>
> In github it is simple to enable such protection, see
> https://help.github.com/articles/about-protected-branches/
>
> I don't want to try btyy performing a force push. Maybe we can ask infra
> about current configuration
>
> Thoughts?
>
> Enrico
> --
>
>
> -- Enrico Olivelli
>