You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/18 18:23:19 UTC

[GitHub] [airflow] chethanuk-plutoflume opened a new pull request, #25135: AIP-47 - Migrate Airbyte DAGs to new design

chethanuk-plutoflume opened a new pull request, #25135:
URL: https://github.com/apache/airflow/pull/25135

   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #25135: AIP-47 - Migrate Airbyte DAGs to new design

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25135:
URL: https://github.com/apache/airflow/pull/25135#issuecomment-1188236859

   Static checks failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #25135: AIP-47 - Migrate Airbyte DAGs to new design

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25135:
URL: https://github.com/apache/airflow/pull/25135#issuecomment-1191904426

   Just copying the exact instructions:
   
   ```
   Make sure to add those lines to docs/apache-airflow-providers-airbyte/index.rst:
   
   
   .. toctree::
       :hidden:
       :caption: System tests
   
       System Tests <_api/tests/system/providers/airbyte/index>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #25135: AIP-47 - Migrate Airbyte DAGs to new design

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25135:
URL: https://github.com/apache/airflow/pull/25135#issuecomment-1191905182

   @chethanuk-plutoflume - I am not sure what the problem is - but the instructions are pretty self-explanatory. Am I missing something? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #25135: AIP-47 - Migrate Airbyte DAGs to new design

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25135:
URL: https://github.com/apache/airflow/pull/25135


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] chethanuk-plutoflume commented on pull request #25135: AIP-47 - Migrate Airbyte DAGs to new design

Posted by GitBox <gi...@apache.org>.
chethanuk-plutoflume commented on PR #25135:
URL: https://github.com/apache/airflow/pull/25135#issuecomment-1190696726

   I have no idea how to fix this conflicts. It says:
   
   ```bash
   All ok. The docs/apache-airflow-providers-apache-sqoop/index.rst does not contain system tests.
   
   Checking docs/apache-airflow-providers-airbyte/index.rst
   The docs/apache-airflow-providers-airbyte/index.rst does not contain System Tests TOC.
   
   Make sure to add those lines to docs/apache-airflow-providers-airbyte/index.rst:
   
   
   .. toctree::
       :hidden:
       :caption: System tests
   
       System Tests <_api/tests/system/providers/airbyte/index>
   
   Checking docs/apache-airflow-providers-singularity/index.rst
   All ok. The docs/apache-airflow-providers-singularity/index.rst contains hidden index.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org