[GitHub] [pinot] KKcorps commented on a diff in pull request #10214: Add broker metrics to V2 Engine

["KKcorps (via GitHub)" <gi...@apache.org>]

KKcorps commented on code in PR #10214:
URL: https://github.com/apache/pinot/pull/10214#discussion_r1095051535


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java:
##########
@@ -76,6 +80,8 @@ public LeafStageTransferableBlockOperator(List<InstanceResponseBlock> baseResult
     _errorBlock = baseResultBlock.stream().filter(e -> !e.getExceptions().isEmpty()).findFirst().orElse(null);
     _currentIndex = 0;
     _operatorStats = new OperatorStats(requestId, stageId, EXPLAIN_NAME);
+    _metadata = OperatorUtils.aggregateMetadata(
+        _baseResultBlock.stream().map(InstanceResponseBlock::getResponseMetadata).collect(Collectors.toList()));

Review Comment:
   Ohh yes, the code I was working with before rebase didn't have OperatorStats class. 
   It seems better to combine them now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org