You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Cameron McKenzie <ca...@apache.org> on 2020/02/24 00:59:53 UTC
[VOTE] Release Apache Curator version 4.3.0
Hello,
This is the vote for Apache Curator version 4.3.0
*** Please download, test and vote within approx. 72 hours
Note that we are voting upon the source (tag) and binaries are provided for
convenience.
Link to release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12345141
Staging repo:
https://dist.apache.org/repos/dist/dev/curator/4.3.0/
<https://dist.apache.org/repos/dist/dev/curator/4.2.0/>
Binary artifacts:
https://repository.apache.org/content/repositories/orgapachecurator-1048
The tag to be voted upon:
https://gitbox.apache.org/repos/asf?p=curator.git;a=tag;h=5c517465392710d42944654d2d246e1b1e23001a
Curator's KEYS file containing PGP keys we use to sign the release:
http://www.apache.org/dist/curator/KEYS
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Re: [VOTE] Release Apache Curator version 4.3.0
Posted by shay shimony <sh...@gmail.com>.
+1
Hash matches
Tests pass
On Mon, Feb 24, 2020 at 5:03 AM Jordan Zimmerman <jo...@jordanzimmerman.com>
wrote:
> +1 (binding)
>
> Signature matches
> Hash matches
> Tests pass (I had to re-rerun TestMapsWithJersey and TestSchema)
>
> -Jordan
>
> > On Feb 23, 2020, at 7:59 PM, Cameron McKenzie <ca...@apache.org>
> wrote:
> >
> > Hello,
> >
> > This is the vote for Apache Curator version 4.3.0
> >
> > *** Please download, test and vote within approx. 72 hours
> >
> > Note that we are voting upon the source (tag) and binaries are provided
> for
> > convenience.
> >
> > Link to release notes:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12345141
> >
> > Staging repo:
> > https://dist.apache.org/repos/dist/dev/curator/4.3.0/
> > <https://dist.apache.org/repos/dist/dev/curator/4.2.0/>
> >
> > Binary artifacts:
> > https://repository.apache.org/content/repositories/orgapachecurator-1048
> >
> > The tag to be voted upon:
> >
> https://gitbox.apache.org/repos/asf?p=curator.git;a=tag;h=5c517465392710d42944654d2d246e1b1e23001a
> >
> > Curator's KEYS file containing PGP keys we use to sign the release:
> > http://www.apache.org/dist/curator/KEYS
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
>
>
Re: [VOTE] Release Apache Curator version 4.3.0
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
+1 (binding)
Signature matches
Hash matches
Tests pass (I had to re-rerun TestMapsWithJersey and TestSchema)
-Jordan
> On Feb 23, 2020, at 7:59 PM, Cameron McKenzie <ca...@apache.org> wrote:
>
> Hello,
>
> This is the vote for Apache Curator version 4.3.0
>
> *** Please download, test and vote within approx. 72 hours
>
> Note that we are voting upon the source (tag) and binaries are provided for
> convenience.
>
> Link to release notes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12345141
>
> Staging repo:
> https://dist.apache.org/repos/dist/dev/curator/4.3.0/
> <https://dist.apache.org/repos/dist/dev/curator/4.2.0/>
>
> Binary artifacts:
> https://repository.apache.org/content/repositories/orgapachecurator-1048
>
> The tag to be voted upon:
> https://gitbox.apache.org/repos/asf?p=curator.git;a=tag;h=5c517465392710d42944654d2d246e1b1e23001a
>
> Curator's KEYS file containing PGP keys we use to sign the release:
> http://www.apache.org/dist/curator/KEYS
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
Re: [VOTE] Release Apache Curator version 4.3.0
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
Can you try the command I have below?
> On Feb 26, 2020, at 11:51 AM, Jay Zarfoss <ja...@gmail.com> wrote:
>
> I grabbed the snapshot zip and ran that if it makes any difference (it shouldn't of course).
>
> On Wed, Feb 26, 2020 at 8:45 AM Jordan Zimmerman <jordan@jordanzimmerman.com <ma...@jordanzimmerman.com>> wrote:
> I just did:
>
> mvn -fn -Dtest=TestReconfiguration,TestFramework,TestLeaderLatchCluster test
>
> on master and it worked for me. Hmm.
>
> -Jordan
>
>> On Feb 26, 2020, at 11:37 AM, Jay Zarfoss <jay.zarfoss@gmail.com <ma...@gmail.com>> wrote:
>>
>> These fail reliably/consistently:
>>
>> [INFO] Running org.apache.curator.framework.imps.TestReconfiguration
>> [ERROR] Tests run: 16, Failures: 3, Errors: 0, Skipped: 3, Time elapsed: 193.557 s <<< FAILURE! - in org.apache.curator.framework.imps.TestReconfiguration
>> [ERROR] testAdd(org.apache.curator.framework.imps.TestReconfiguration) Time elapsed: 15.243 s <<< FAILURE!
>> org.apache.zookeeper.KeeperException$NewConfigNoQuorum: KeeperErrorCode = NewConfigNoQuorum
>> at org.apache.curator.framework.imps.TestReconfiguration.testAdd(TestReconfiguration.java:195)
>>
>> [ERROR] testAddAndRemove(org.apache.curator.framework.imps.TestReconfiguration) Time elapsed: 17.828 s <<< FAILURE!
>> org.apache.zookeeper.KeeperException$NewConfigNoQuorum: KeeperErrorCode = NewConfigNoQuorum
>> at org.apache.curator.framework.imps.TestReconfiguration.testAddAndRemove(TestReconfiguration.java:277)
>>
>> [ERROR] testAddAsync(org.apache.curator.framework.imps.TestReconfiguration) Time elapsed: 66.245 s <<< FAILURE!
>> java.lang.AssertionError: expected [true] but found [false]
>> at org.apache.curator.framework.imps.TestReconfiguration.testAddAsync(TestReconfiguration.java:239)
>>
>> Sporadically getting these timeouts on other tests:
>>
>> [INFO] Running org.apache.curator.framework.imps.TestFramework
>> [ERROR] Tests run: 24, Failures: 1, Errors: 0, Skipped: 11, Time elapsed: 75.324 s <<< FAILURE! - in org.apache.curator.framework.imps.TestFramework
>> [ERROR] setup(org.apache.curator.framework.imps.TestFramework) Time elapsed: 50.132 s <<< FAILURE!
>> java.lang.IllegalStateException: Timed out waiting for server startup
>> at org.apache.curator.framework.imps.TestFramework.setup(TestFramework.java:68)
>>
>> Other tests seemingly hanging:
>>
>> [INFO] Running org.apache.curator.framework.recipes.leader.TestLeaderLatchCluster
>>
>> I'm sure it's something stupid, I just don't have time to look into it today, going to dentist right now then going into SF with my wife promised her I would go to the harry potter show today and it's an all day affair apparently.
>>
>>
>>
>>
>>
>> On Tue, Feb 25, 2020 at 10:18 PM Cameron McKenzie <mckenzie.cam@gmail.com <ma...@gmail.com>> wrote:
>> Thanks Jay,
>> What's the problem?
>>
>> Interestingly, this build was the first one in ages that all the tests ran fine on for me.
>> Cheers
>>
>> On Wed, Feb 26, 2020, 5:13 PM Jay Zarfoss <jay.zarfoss@gmail.com <ma...@gmail.com>> wrote:
>> I've been trying for a couple of hours and I can't get a clean test/build run on my laptop. I've got to head to bed and them I'm AFK for all of tomorrow, I can try again on Thursday from work.
>>
>> On Tue, Feb 25, 2020 at 7:53 AM Jordan Zimmerman <jordan@jordanzimmerman.com <ma...@jordanzimmerman.com>> wrote:
>> Thanks Jay!
>>
>>> On Feb 25, 2020, at 10:53 AM, Jay Zarfoss <jay.zarfoss@gmail.com <ma...@gmail.com>> wrote:
>>>
>>> I'm just getting back from vacation in Colorado I can check it tonight.
>>>
>>> On Tue, Feb 25, 2020, 6:55 AM Jordan Zimmerman <jordan@jordanzimmerman.com <ma...@jordanzimmerman.com>> wrote:
>>> Thanks Shay
>>>
>>>> On Feb 25, 2020, at 9:54 AM, shay shimony <shayshim@gmail.com <ma...@gmail.com>> wrote:
>>>>
>>>> I don't want to install stuff on the machine where I stay, I will get home by tomorrow and do the tests and vote.
>>>>
>>>> On Tue, Feb 25, 2020 at 8:41 AM shay shimony <shayshim@gmail.com <ma...@gmail.com>> wrote:
>>>> Got it, thanks.
>>>>
>>>> On Tue, Feb 25, 2020 at 8:40 AM Jordan Zimmerman <jordan@jordanzimmerman.com <ma...@jordanzimmerman.com>> wrote:
>>>> That's controlled by Jira. CURATOR-557 didn't have the release set - I fixed it. Any open issues will get moved to the next release when we mark 4.3.0 as released - so CURATOR-558 won't show in the final release notes.
>>>>
>>>> -JZ
>>>>
>>>>> On Feb 25, 2020, at 8:36 AM, shay shimony <shayshim@gmail.com <ma...@gmail.com>> wrote:
>>>>>
>>>>> Hi Jordan,
>>>>> Shouldn't we have in release notes only changes that were merged to master before the release?
>>>>> Some changes like CURATOR-558 were not merged yet, but appear in the release notes.
>>>>> Also, CURATOR-557, which was merged, does not appear in the release notes.
>>>>> Thanks,
>>>>> Shay
>>>>>
>>>>> On Tue, Feb 25, 2020 at 7:53 AM Jordan Zimmerman <jordan@jordanzimmerman.com <ma...@jordanzimmerman.com>> wrote:
>>>>> Hi Guys,
>>>>>
>>>>> If you could, we'd appreciate a vote on the release.
>>>>>
>>>>> Thank you!
>>>>>
>>>>> -Jordan
>>>>>
>>>>>> Begin forwarded message:
>>>>>>
>>>>>> From: Cameron McKenzie <cammckenzie@apache.org <ma...@apache.org>>
>>>>>> Subject: [VOTE] Release Apache Curator version 4.3.0
>>>>>> Date: February 23, 2020 at 7:59:53 PM EST
>>>>>> To: dev@curator.apache.org <ma...@curator.apache.org>
>>>>>> Reply-To: dev@curator.apache.org <ma...@curator.apache.org>
>>>>>> Reply-To: cammckenzie@apache.org <ma...@apache.org>
>>>>>>
>>>>>> Hello,
>>>>>>
>>>>>> This is the vote for Apache Curator version 4.3.0
>>>>>>
>>>>>> *** Please download, test and vote within approx. 72 hours
>>>>>>
>>>>>> Note that we are voting upon the source (tag) and binaries are provided for
>>>>>> convenience.
>>>>>>
>>>>>> Link to release notes:
>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12345141 <https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12345141>
>>>>>>
>>>>>> Staging repo:
>>>>>> https://dist.apache.org/repos/dist/dev/curator/4.3.0/ <https://dist.apache.org/repos/dist/dev/curator/4.3.0/>
>>>>>> <https://dist.apache.org/repos/dist/dev/curator/4.2.0/ <https://dist.apache.org/repos/dist/dev/curator/4.2.0/>>
>>>>>>
>>>>>> Binary artifacts:
>>>>>> https://repository.apache.org/content/repositories/orgapachecurator-1048 <https://repository.apache.org/content/repositories/orgapachecurator-1048>
>>>>>>
>>>>>> The tag to be voted upon:
>>>>>> https://gitbox.apache.org/repos/asf?p=curator.git;a=tag;h=5c517465392710d42944654d2d246e1b1e23001a <https://gitbox.apache.org/repos/asf?p=curator.git;a=tag;h=5c517465392710d42944654d2d246e1b1e23001a>
>>>>>>
>>>>>> Curator's KEYS file containing PGP keys we use to sign the release:
>>>>>> http://www.apache.org/dist/curator/KEYS <http://www.apache.org/dist/curator/KEYS>
>>>>>>
>>>>>> [ ] +1 approve
>>>>>> [ ] +0 no opinion
>>>>>> [ ] -1 disapprove (and reason why)
>>>>>
>>>>
>>>
>>
>
Re: [VOTE] Release Apache Curator version 4.3.0
Posted by Jay Zarfoss <ja...@gmail.com>.
I grabbed the snapshot zip and ran that if it makes any difference (it
shouldn't of course).
On Wed, Feb 26, 2020 at 8:45 AM Jordan Zimmerman <jo...@jordanzimmerman.com>
wrote:
> I just did:
>
> mvn -fn -Dtest=TestReconfiguration,TestFramework,TestLeaderLatchCluster
> test
>
> on master and it worked for me. Hmm.
>
> -Jordan
>
> On Feb 26, 2020, at 11:37 AM, Jay Zarfoss <ja...@gmail.com> wrote:
>
> These fail reliably/consistently:
>
> [*INFO*] Running org.apache.curator.framework.imps.*TestReconfiguration*
> [*ERROR*] *Tests **run: 16*, *Failures: 3*, Errors: 0, *Skipped: 3*, Time
> elapsed: 193.557 s* <<< FAILURE!* - in org.apache.curator.framework.imps.
> *TestReconfiguration*
> [*ERROR*] testAdd(org.apache.curator.framework.imps.TestReconfiguration) Time
> elapsed: 15.243 s <<< FAILURE!
> org.apache.zookeeper.KeeperException$NewConfigNoQuorum: KeeperErrorCode =
> NewConfigNoQuorum
> at
> org.apache.curator.framework.imps.TestReconfiguration.testAdd(TestReconfiguration.java:195)
>
> [*ERROR*]
> testAddAndRemove(org.apache.curator.framework.imps.TestReconfiguration) Time
> elapsed: 17.828 s <<< FAILURE!
> org.apache.zookeeper.KeeperException$NewConfigNoQuorum: KeeperErrorCode =
> NewConfigNoQuorum
> at
> org.apache.curator.framework.imps.TestReconfiguration.testAddAndRemove(TestReconfiguration.java:277)
>
> [*ERROR*]
> testAddAsync(org.apache.curator.framework.imps.TestReconfiguration) Time
> elapsed: 66.245 s <<< FAILURE!
> java.lang.AssertionError: expected [true] but found [false]
> at
> org.apache.curator.framework.imps.TestReconfiguration.testAddAsync(TestReconfiguration.java:239)
>
> Sporadically getting these timeouts on other tests:
>
> [*INFO*] Running org.apache.curator.framework.imps.*TestFramework*
> [*ERROR*] *Tests **run: 24*, *Failures: 1*, Errors: 0, *Skipped: 11*,
> Time elapsed: 75.324 s* <<< FAILURE!* - in
> org.apache.curator.framework.imps.*TestFramework*
> [*ERROR*] setup(org.apache.curator.framework.imps.TestFramework) Time
> elapsed: 50.132 s <<< FAILURE!
> java.lang.IllegalStateException: Timed out waiting for server startup
>
> at
> org.apache.curator.framework.imps.TestFramework.setup(TestFramework.java:68)
>
> Other tests seemingly hanging:
>
> [*INFO*] Running org.apache.curator.framework.recipes.leader.
> *TestLeaderLatchCluster*
>
> I'm sure it's something stupid, I just don't have time to look into it
> today, going to dentist right now then going into SF with my wife promised
> her I would go to the harry potter show today and it's an all day affair
> apparently.
>
>
>
>
>
> On Tue, Feb 25, 2020 at 10:18 PM Cameron McKenzie <mc...@gmail.com>
> wrote:
>
>> Thanks Jay,
>> What's the problem?
>>
>> Interestingly, this build was the first one in ages that all the tests
>> ran fine on for me.
>> Cheers
>>
>> On Wed, Feb 26, 2020, 5:13 PM Jay Zarfoss <ja...@gmail.com> wrote:
>>
>>> I've been trying for a couple of hours and I can't get a clean
>>> test/build run on my laptop. I've got to head to bed and them I'm AFK for
>>> all of tomorrow, I can try again on Thursday from work.
>>>
>>> On Tue, Feb 25, 2020 at 7:53 AM Jordan Zimmerman <
>>> jordan@jordanzimmerman.com> wrote:
>>>
>>>> Thanks Jay!
>>>>
>>>> On Feb 25, 2020, at 10:53 AM, Jay Zarfoss <ja...@gmail.com>
>>>> wrote:
>>>>
>>>> I'm just getting back from vacation in Colorado I can check it tonight.
>>>>
>>>> On Tue, Feb 25, 2020, 6:55 AM Jordan Zimmerman <
>>>> jordan@jordanzimmerman.com> wrote:
>>>>
>>>>> Thanks Shay
>>>>>
>>>>> On Feb 25, 2020, at 9:54 AM, shay shimony <sh...@gmail.com> wrote:
>>>>>
>>>>> I don't want to install stuff on the machine where I stay, I will get
>>>>> home by tomorrow and do the tests and vote.
>>>>>
>>>>> On Tue, Feb 25, 2020 at 8:41 AM shay shimony <sh...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Got it, thanks.
>>>>>>
>>>>>> On Tue, Feb 25, 2020 at 8:40 AM Jordan Zimmerman <
>>>>>> jordan@jordanzimmerman.com> wrote:
>>>>>>
>>>>>>> That's controlled by Jira. CURATOR-557 didn't have the release set -
>>>>>>> I fixed it. Any open issues will get moved to the next release when we mark
>>>>>>> 4.3.0 as released - so CURATOR-558 won't show in the final release notes.
>>>>>>>
>>>>>>> -JZ
>>>>>>>
>>>>>>> On Feb 25, 2020, at 8:36 AM, shay shimony <sh...@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>> Hi Jordan,
>>>>>>> Shouldn't we have in release notes only changes that were merged to
>>>>>>> master before the release?
>>>>>>> Some changes like CURATOR-558 were not merged yet, but appear in the
>>>>>>> release notes.
>>>>>>> Also, CURATOR-557, which was merged, does not appear in the release
>>>>>>> notes.
>>>>>>> Thanks,
>>>>>>> Shay
>>>>>>>
>>>>>>> On Tue, Feb 25, 2020 at 7:53 AM Jordan Zimmerman <
>>>>>>> jordan@jordanzimmerman.com> wrote:
>>>>>>>
>>>>>>>> Hi Guys,
>>>>>>>>
>>>>>>>> If you could, we'd appreciate a vote on the release.
>>>>>>>>
>>>>>>>> Thank you!
>>>>>>>>
>>>>>>>> -Jordan
>>>>>>>>
>>>>>>>> Begin forwarded message:
>>>>>>>>
>>>>>>>> *From: *Cameron McKenzie <ca...@apache.org>
>>>>>>>> *Subject: **[VOTE] Release Apache Curator version 4.3.0*
>>>>>>>> *Date: *February 23, 2020 at 7:59:53 PM EST
>>>>>>>> *To: *dev@curator.apache.org
>>>>>>>> *Reply-To: *dev@curator.apache.org
>>>>>>>> *Reply-To: *cammckenzie@apache.org
>>>>>>>>
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> This is the vote for Apache Curator version 4.3.0
>>>>>>>>
>>>>>>>> *** Please download, test and vote within approx. 72 hours
>>>>>>>>
>>>>>>>> Note that we are voting upon the source (tag) and binaries are
>>>>>>>> provided for
>>>>>>>> convenience.
>>>>>>>>
>>>>>>>> Link to release notes:
>>>>>>>>
>>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12345141
>>>>>>>>
>>>>>>>> Staging repo:
>>>>>>>> https://dist.apache.org/repos/dist/dev/curator/4.3.0/
>>>>>>>> <https://dist.apache.org/repos/dist/dev/curator/4.2.0/>
>>>>>>>>
>>>>>>>> Binary artifacts:
>>>>>>>>
>>>>>>>> https://repository.apache.org/content/repositories/orgapachecurator-1048
>>>>>>>>
>>>>>>>> The tag to be voted upon:
>>>>>>>>
>>>>>>>> https://gitbox.apache.org/repos/asf?p=curator.git;a=tag;h=5c517465392710d42944654d2d246e1b1e23001a
>>>>>>>>
>>>>>>>> Curator's KEYS file containing PGP keys we use to sign the release:
>>>>>>>> http://www.apache.org/dist/curator/KEYS
>>>>>>>>
>>>>>>>> [ ] +1 approve
>>>>>>>> [ ] +0 no opinion
>>>>>>>> [ ] -1 disapprove (and reason why)
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>
>>>>
>
Re: [VOTE] Release Apache Curator version 4.3.0
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
I just did:
mvn -fn -Dtest=TestReconfiguration,TestFramework,TestLeaderLatchCluster test
on master and it worked for me. Hmm.
-Jordan
> On Feb 26, 2020, at 11:37 AM, Jay Zarfoss <ja...@gmail.com> wrote:
>
> These fail reliably/consistently:
>
> [INFO] Running org.apache.curator.framework.imps.TestReconfiguration
> [ERROR] Tests run: 16, Failures: 3, Errors: 0, Skipped: 3, Time elapsed: 193.557 s <<< FAILURE! - in org.apache.curator.framework.imps.TestReconfiguration
> [ERROR] testAdd(org.apache.curator.framework.imps.TestReconfiguration) Time elapsed: 15.243 s <<< FAILURE!
> org.apache.zookeeper.KeeperException$NewConfigNoQuorum: KeeperErrorCode = NewConfigNoQuorum
> at org.apache.curator.framework.imps.TestReconfiguration.testAdd(TestReconfiguration.java:195)
>
> [ERROR] testAddAndRemove(org.apache.curator.framework.imps.TestReconfiguration) Time elapsed: 17.828 s <<< FAILURE!
> org.apache.zookeeper.KeeperException$NewConfigNoQuorum: KeeperErrorCode = NewConfigNoQuorum
> at org.apache.curator.framework.imps.TestReconfiguration.testAddAndRemove(TestReconfiguration.java:277)
>
> [ERROR] testAddAsync(org.apache.curator.framework.imps.TestReconfiguration) Time elapsed: 66.245 s <<< FAILURE!
> java.lang.AssertionError: expected [true] but found [false]
> at org.apache.curator.framework.imps.TestReconfiguration.testAddAsync(TestReconfiguration.java:239)
>
> Sporadically getting these timeouts on other tests:
>
> [INFO] Running org.apache.curator.framework.imps.TestFramework
> [ERROR] Tests run: 24, Failures: 1, Errors: 0, Skipped: 11, Time elapsed: 75.324 s <<< FAILURE! - in org.apache.curator.framework.imps.TestFramework
> [ERROR] setup(org.apache.curator.framework.imps.TestFramework) Time elapsed: 50.132 s <<< FAILURE!
> java.lang.IllegalStateException: Timed out waiting for server startup
> at org.apache.curator.framework.imps.TestFramework.setup(TestFramework.java:68)
>
> Other tests seemingly hanging:
>
> [INFO] Running org.apache.curator.framework.recipes.leader.TestLeaderLatchCluster
>
> I'm sure it's something stupid, I just don't have time to look into it today, going to dentist right now then going into SF with my wife promised her I would go to the harry potter show today and it's an all day affair apparently.
>
>
>
>
>
> On Tue, Feb 25, 2020 at 10:18 PM Cameron McKenzie <mckenzie.cam@gmail.com <ma...@gmail.com>> wrote:
> Thanks Jay,
> What's the problem?
>
> Interestingly, this build was the first one in ages that all the tests ran fine on for me.
> Cheers
>
> On Wed, Feb 26, 2020, 5:13 PM Jay Zarfoss <jay.zarfoss@gmail.com <ma...@gmail.com>> wrote:
> I've been trying for a couple of hours and I can't get a clean test/build run on my laptop. I've got to head to bed and them I'm AFK for all of tomorrow, I can try again on Thursday from work.
>
> On Tue, Feb 25, 2020 at 7:53 AM Jordan Zimmerman <jordan@jordanzimmerman.com <ma...@jordanzimmerman.com>> wrote:
> Thanks Jay!
>
>> On Feb 25, 2020, at 10:53 AM, Jay Zarfoss <jay.zarfoss@gmail.com <ma...@gmail.com>> wrote:
>>
>> I'm just getting back from vacation in Colorado I can check it tonight.
>>
>> On Tue, Feb 25, 2020, 6:55 AM Jordan Zimmerman <jordan@jordanzimmerman.com <ma...@jordanzimmerman.com>> wrote:
>> Thanks Shay
>>
>>> On Feb 25, 2020, at 9:54 AM, shay shimony <shayshim@gmail.com <ma...@gmail.com>> wrote:
>>>
>>> I don't want to install stuff on the machine where I stay, I will get home by tomorrow and do the tests and vote.
>>>
>>> On Tue, Feb 25, 2020 at 8:41 AM shay shimony <shayshim@gmail.com <ma...@gmail.com>> wrote:
>>> Got it, thanks.
>>>
>>> On Tue, Feb 25, 2020 at 8:40 AM Jordan Zimmerman <jordan@jordanzimmerman.com <ma...@jordanzimmerman.com>> wrote:
>>> That's controlled by Jira. CURATOR-557 didn't have the release set - I fixed it. Any open issues will get moved to the next release when we mark 4.3.0 as released - so CURATOR-558 won't show in the final release notes.
>>>
>>> -JZ
>>>
>>>> On Feb 25, 2020, at 8:36 AM, shay shimony <shayshim@gmail.com <ma...@gmail.com>> wrote:
>>>>
>>>> Hi Jordan,
>>>> Shouldn't we have in release notes only changes that were merged to master before the release?
>>>> Some changes like CURATOR-558 were not merged yet, but appear in the release notes.
>>>> Also, CURATOR-557, which was merged, does not appear in the release notes.
>>>> Thanks,
>>>> Shay
>>>>
>>>> On Tue, Feb 25, 2020 at 7:53 AM Jordan Zimmerman <jordan@jordanzimmerman.com <ma...@jordanzimmerman.com>> wrote:
>>>> Hi Guys,
>>>>
>>>> If you could, we'd appreciate a vote on the release.
>>>>
>>>> Thank you!
>>>>
>>>> -Jordan
>>>>
>>>>> Begin forwarded message:
>>>>>
>>>>> From: Cameron McKenzie <cammckenzie@apache.org <ma...@apache.org>>
>>>>> Subject: [VOTE] Release Apache Curator version 4.3.0
>>>>> Date: February 23, 2020 at 7:59:53 PM EST
>>>>> To: dev@curator.apache.org <ma...@curator.apache.org>
>>>>> Reply-To: dev@curator.apache.org <ma...@curator.apache.org>
>>>>> Reply-To: cammckenzie@apache.org <ma...@apache.org>
>>>>>
>>>>> Hello,
>>>>>
>>>>> This is the vote for Apache Curator version 4.3.0
>>>>>
>>>>> *** Please download, test and vote within approx. 72 hours
>>>>>
>>>>> Note that we are voting upon the source (tag) and binaries are provided for
>>>>> convenience.
>>>>>
>>>>> Link to release notes:
>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12345141 <https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12345141>
>>>>>
>>>>> Staging repo:
>>>>> https://dist.apache.org/repos/dist/dev/curator/4.3.0/ <https://dist.apache.org/repos/dist/dev/curator/4.3.0/>
>>>>> <https://dist.apache.org/repos/dist/dev/curator/4.2.0/ <https://dist.apache.org/repos/dist/dev/curator/4.2.0/>>
>>>>>
>>>>> Binary artifacts:
>>>>> https://repository.apache.org/content/repositories/orgapachecurator-1048 <https://repository.apache.org/content/repositories/orgapachecurator-1048>
>>>>>
>>>>> The tag to be voted upon:
>>>>> https://gitbox.apache.org/repos/asf?p=curator.git;a=tag;h=5c517465392710d42944654d2d246e1b1e23001a <https://gitbox.apache.org/repos/asf?p=curator.git;a=tag;h=5c517465392710d42944654d2d246e1b1e23001a>
>>>>>
>>>>> Curator's KEYS file containing PGP keys we use to sign the release:
>>>>> http://www.apache.org/dist/curator/KEYS <http://www.apache.org/dist/curator/KEYS>
>>>>>
>>>>> [ ] +1 approve
>>>>> [ ] +0 no opinion
>>>>> [ ] -1 disapprove (and reason why)
>>>>
>>>
>>
>