[GitHub] [hbase] ndimiduk commented on a change in pull request #3372: HBASE-25986 set default value of normalization enabled from hbase site

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #3372:
URL: https://github.com/apache/hbase/pull/3372#discussion_r657295798



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptor.java
##########
@@ -275,11 +275,11 @@
 
   /**
    * Check if normalization enable flag of the table is true. If flag is false
-   * then no region normalizer won't attempt to normalize this table.
+   * then region normalizer won't attempt to normalize this table.
    *
-   * @return true if region normalization is enabled for this table
+   * @return value of NORMALIZATION_ENABLED key for this table if present else return defaultValue
    */
-  boolean isNormalizationEnabled();
+  boolean isNormalizationEnabled(boolean defaulValue);

Review comment:
       I agree. Do not mix concerns of what's in the TableDescriptor with what's in hbase-site. Instead, have the code that needs to use the value look in both places and make a determination.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org