You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/04/23 20:48:26 UTC
[GitHub] [incubator-iceberg] aokolnychyi opened a new pull request #959: Spark: Default staging location in RewriteManifestsAction to metadata location
aokolnychyi opened a new pull request #959:
URL: https://github.com/apache/incubator-iceberg/pull/959
As a follow-up to #875, this PR defaults the staging location in `RewriteManifestsAction` to the metadata location.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #959: Spark: Default staging location in RewriteManifestsAction to metadata location
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #959:
URL: https://github.com/apache/incubator-iceberg/pull/959#discussion_r414174466
##########
File path: spark/src/main/java/org/apache/iceberg/actions/RewriteManifestsAction.java
##########
@@ -162,8 +169,6 @@ public RewriteManifestsAction useCaching(boolean newUseCaching) {
@Override
public RewriteManifestsActionResult execute() {
- Preconditions.checkArgument(stagingLocation != null, "Staging location must be set");
Review comment:
My worry is that it may be confusing that we default the staging location only in some cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #959: Spark: Default staging location in RewriteManifestsAction to metadata location
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #959:
URL: https://github.com/apache/incubator-iceberg/pull/959#discussion_r414173253
##########
File path: spark/src/main/java/org/apache/iceberg/actions/RewriteManifestsAction.java
##########
@@ -162,8 +169,6 @@ public RewriteManifestsAction useCaching(boolean newUseCaching) {
@Override
public RewriteManifestsActionResult execute() {
- Preconditions.checkArgument(stagingLocation != null, "Staging location must be set");
Review comment:
We could but we use the same principle in a number of places, including the remove orphan files action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #959: Spark: Default staging location in RewriteManifestsAction to metadata location
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #959:
URL: https://github.com/apache/incubator-iceberg/pull/959#discussion_r414173851
##########
File path: spark/src/main/java/org/apache/iceberg/actions/RewriteManifestsAction.java
##########
@@ -162,8 +169,6 @@ public RewriteManifestsAction useCaching(boolean newUseCaching) {
@Override
public RewriteManifestsActionResult execute() {
- Preconditions.checkArgument(stagingLocation != null, "Staging location must be set");
Review comment:
Instead of relying on `TableOperations`, we could check table properties directly too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #959: Spark: Default staging location in RewriteManifestsAction to metadata location
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #959:
URL: https://github.com/apache/incubator-iceberg/pull/959#discussion_r414123172
##########
File path: spark/src/main/java/org/apache/iceberg/actions/RewriteManifestsAction.java
##########
@@ -162,8 +169,6 @@ public RewriteManifestsAction useCaching(boolean newUseCaching) {
@Override
public RewriteManifestsActionResult execute() {
- Preconditions.checkArgument(stagingLocation != null, "Staging location must be set");
Review comment:
What if we kept this and did a check whether the table implements `HasTableOperations`? Then we wouldn't need an unchecked cast.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org