[GitHub] [hbase] ZhaoBQ commented on a change in pull request #2976: HBASE-25597 Add row info in Exception when cell size exceeds maxCellSize

[GitBox <gi...@apache.org>]

ZhaoBQ commented on a change in pull request #2976:
URL: https://github.com/apache/hbase/pull/2976#discussion_r589198615



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -902,7 +902,8 @@ private void checkCellSizeLimit(final HRegion r, final Mutation m) throws IOExce
       while (cells.advance()) {
         int size = PrivateCellUtil.estimatedSerializedSizeOf(cells.current());
         if (size > r.maxCellSize) {
-          String msg = "Cell with size " + size + " exceeds limit of " + r.maxCellSize + " bytes";
+          String msg = "Cell[" + Bytes.toString(m.getRow()) + "] with size " + size
+            + " exceeds limit of " + r.maxCellSize + " bytes";
           LOG.debug(msg);

Review comment:
       I found that only cells.current() may be better, the KeyValue.toString() method will be called, which print out  rowkey, column, timestamp, type, vlen, and seqid. What do you think @Apache9 ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org