You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/14 05:53:34 UTC
[GitHub] [doris] mrhhsg opened a new pull request, #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
mrhhsg opened a new pull request, #15072:
URL: https://github.com/apache/doris/pull/15072
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15072:
URL: https://github.com/apache/doris/pull/15072#issuecomment-1350724979
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15072:
URL: https://github.com/apache/doris/pull/15072#issuecomment-1354080469
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #15072:
URL: https://github.com/apache/doris/pull/15072#discussion_r1049500945
##########
be/src/vec/common/hash_table/hash_table.h:
##########
@@ -349,11 +350,13 @@ class alignas(64) HashTableGrowerWithPrecalculation {
: ((initial_size_degree > static_cast<size_t>(log2(num_elems - 1)) + 2)
? initial_size_degree
: (static_cast<size_t>(log2(num_elems - 1)) + 2));
+ DCHECK(size_degree_ <= 64);
increase_size_degree(0);
}
void set_buf_size(size_t buf_size_) {
size_degree_ = static_cast<size_t>(log2(buf_size_ - 1) + 1);
+ DCHECK(size_degree_ <= 64);
Review Comment:
ditto
##########
be/src/vec/common/hash_table/hash_table.h:
##########
@@ -349,11 +350,13 @@ class alignas(64) HashTableGrowerWithPrecalculation {
: ((initial_size_degree > static_cast<size_t>(log2(num_elems - 1)) + 2)
? initial_size_degree
: (static_cast<size_t>(log2(num_elems - 1)) + 2));
+ DCHECK(size_degree_ <= 64);
Review Comment:
There is a DCHECK in `increase_size_degree` already so this can be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15072:
URL: https://github.com/apache/doris/pull/15072#issuecomment-1354072150
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15072:
URL: https://github.com/apache/doris/pull/15072#issuecomment-1354079853
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mrhhsg commented on a diff in pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
mrhhsg commented on code in PR #15072:
URL: https://github.com/apache/doris/pull/15072#discussion_r1050304689
##########
be/src/vec/exec/vset_operation_node.cpp:
##########
@@ -174,6 +174,8 @@ Status VSetOperationNode<is_intersect>::init(const TPlanNode& tnode, RuntimeStat
_child_expr_lists.push_back(ctxs);
}
+ _probe_finished_children_index.assign(_child_expr_lists.size(), false);
Review Comment:
`alloc_resource` will be called multi times(sink operator/source operator/probe sink operator)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #15072:
URL: https://github.com/apache/doris/pull/15072#discussion_r1049533224
##########
be/src/vec/exec/vset_operation_node.cpp:
##########
@@ -183,7 +185,6 @@ Status VSetOperationNode<is_intersect>::alloc_resource(RuntimeState* state) {
for (const std::vector<VExprContext*>& exprs : _child_expr_lists) {
RETURN_IF_ERROR(VExpr::open(exprs, state));
}
- _probe_finished_children_index.assign(_child_expr_lists.size(), false);
_probe_columns.resize(_child_expr_lists[1].size());
Review Comment:
why resize _probe_columns by the second _child_expr_lists?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
Gabriel39 merged PR #15072:
URL: https://github.com/apache/doris/pull/15072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15072:
URL: https://github.com/apache/doris/pull/15072#issuecomment-1354079823
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15072:
URL: https://github.com/apache/doris/pull/15072#issuecomment-1350943936
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.42 seconds
load time: 473 seconds
storage size: 17123356924 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221214110141_clickbench_pr_63293.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15072:
URL: https://github.com/apache/doris/pull/15072#issuecomment-1350439111
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15072:
URL: https://github.com/apache/doris/pull/15072#issuecomment-1354301446
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #15072: [fix](pipeline) _valid_element_in_hash_tbl was not set correctly
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #15072:
URL: https://github.com/apache/doris/pull/15072#discussion_r1049504890
##########
be/src/vec/exec/vset_operation_node.cpp:
##########
@@ -174,6 +174,8 @@ Status VSetOperationNode<is_intersect>::init(const TPlanNode& tnode, RuntimeStat
_child_expr_lists.push_back(ctxs);
}
+ _probe_finished_children_index.assign(_child_expr_lists.size(), false);
Review Comment:
Any difference between do it in `init` and `alloc_resource ` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org