You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/03/24 00:10:17 UTC
[GitHub] couchdb-fauxton pull request: Design doc names truncated in sideba...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/330
Design doc names truncated in sidebar
Long design doc names displayed in the sidebar of the Docs page would
overlap with the rightmost ("+") icon. This truncates them with an
ellipsis and adds a tooltip (just a title attr) to provide a means to
let user see the full design doc name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton truncate-long-view-names-in-sidebar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/330.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #330
----
commit 624760c2ca175757fc3477c2f34d8be2aa979de4
Author: Ben Keen <be...@gmail.com>
Date: 2015-03-23T23:07:47Z
Design doc names truncated in sidebar
Long design doc names displayed in the sidebar of the Docs page would
overlap with the rightmost ("+") icon. This truncates them with an
ellipsis and adds a tooltip (just a title attr) to provide a means to
let user see the full design doc name.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design doc names truncated in sideba...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/330#issuecomment-87709587
Closing this PR - travis won't re-trigger for some reason. I'll link the new PR to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design doc names truncated in sideba...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/330#issuecomment-87662857
@benkeen could you rebase and if tests pass, could you merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design doc names truncated in sideba...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/330#issuecomment-85595881
left a small suggestion, looks good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design doc names truncated in sideba...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/330#discussion_r27048309
--- Diff: app/addons/documents/assets/less/sidenav.less ---
@@ -84,10 +84,17 @@
.accordion-list-item p{
.transition(all 0.25s linear);
}
- .accordion-list-item p{
+ .design-doc-name {
+ cursor: pointer;
margin: 0;
- padding: 10px 13px 10px 36px;
color: @linkColor;
+ span {
+ width: 300px;
--- End diff --
you can do:
```
width: @sidebarWidth - 30px;
```
this way it will not break if the sidebar width changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design doc names truncated in sideba...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/330#discussion_r27049149
--- Diff: app/addons/documents/assets/less/sidenav.less ---
@@ -84,10 +84,17 @@
.accordion-list-item p{
.transition(all 0.25s linear);
}
- .accordion-list-item p{
+ .design-doc-name {
+ cursor: pointer;
margin: 0;
- padding: 10px 13px 10px 36px;
color: @linkColor;
+ span {
+ width: 300px;
--- End diff --
Good call. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design doc names truncated in sideba...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/330#issuecomment-85243077
Before:
After:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design doc names truncated in sideba...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/330#issuecomment-85595978
+1 after addressing it (and travis is green)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Design doc names truncated in sideba...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/330
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---