You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Daniel Templeton (JIRA)" <ji...@apache.org> on 2017/02/22 23:27:44 UTC
[jira] [Comment Edited] (YARN-6210) FS: Node reservations can
interfere with preemption
[ https://issues.apache.org/jira/browse/YARN-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879463#comment-15879463 ]
Daniel Templeton edited comment on YARN-6210 at 2/22/17 11:27 PM:
------------------------------------------------------------------
You're gonna love me for this one...
We now have:
{code}
if (!starved) {
lastTimeAtFairShare = now;
}
if (!starved ||
now - lastTimeAtFairShare < fsQueue.getFairSharePreemptionTimeout()) {
fairshareStarvation = Resources.none();
}
{code}
What about:
{code}
if (!starved ||
now - lastTimeAtFairShare < fsQueue.getFairSharePreemptionTimeout()) {
if (!starved) {
lastTimeAtFairShare = now;
}
fairshareStarvation = Resources.none();
}
{code}
?
Just a thought. I'm a +1 either way.
was (Author: templedf):
You're gonna love me for this one...
We now have:
{code}
if (!starved) {
lastTimeAtFairShare = now;
}
if (!starved ||
now - lastTimeAtFairShare < fsQueue.getFairSharePreemptionTimeout()) {
fairshareStarvation = Resources.none();
}
{code}
What about:
{code}
if (!starved ||
now - lastTimeAtFairShare < fsQueue.getFairSharePreemptionTimeout()) {
if (!starved) {
lastTimeAtFairShare = now;
}
fairshareStarvation = Resources.none();
}
{code}
?
> FS: Node reservations can interfere with preemption
> ---------------------------------------------------
>
> Key: YARN-6210
> URL: https://issues.apache.org/jira/browse/YARN-6210
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 2.9.0
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: YARN-6210.1.patch, YARN-6210.2.patch, YARN-6210.3.patch, YARN-6210.4.patch
>
>
> Today, on a saturated cluster, apps with pending demand reserve nodes. A new app might not be able to preempt resources because these nodes are already reserved. This can be reproduced by the example in YARN-6151.
> Since node reservations are to prevent starvation of apps requesting large containers, triggering these reservations only on starved applications would avoid this situation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org