You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/18 07:38:00 UTC
[GitHub] [yunikorn-k8shim] HuangTing-Yao opened a new pull request, #504: [YUNIKORN-1284]upgrade zap logger to a recent version
HuangTing-Yao opened a new pull request, #504:
URL: https://github.com/apache/yunikorn-k8shim/pull/504
### What is this PR for?
Upgrade zap version to 1.24.0
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1284
###
How should this be tested?
scheduler log look ok
![sch_log](https://user-images.githubusercontent.com/61864060/208286789-19fa956b-a598-4c96-ba7c-64b07adae069.png)
admission log look ok
![ad_log](https://user-images.githubusercontent.com/61864060/208286818-c0d5ab45-ef44-42a9-9682-78605725cf59.png)
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #504: [YUNIKORN-1284]upgrade zap logger to a recent version
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #504: [YUNIKORN-1284]upgrade zap logger to a recent version
URL: https://github.com/apache/yunikorn-k8shim/pull/504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #504: [YUNIKORN-1284]upgrade zap logger to a recent version
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #504:
URL: https://github.com/apache/yunikorn-k8shim/pull/504#issuecomment-1356724082
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/504?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#504](https://codecov.io/gh/apache/yunikorn-k8shim/pull/504?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58144d9) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/de8d8b62fc35bfe528b7fa3334673e20584e3f20?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de8d8b6) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #504 +/- ##
=======================================
Coverage 69.48% 69.48%
=======================================
Files 45 45
Lines 7711 7711
=======================================
Hits 5358 5358
Misses 2157 2157
Partials 196 196
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org