[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5625: Make DataSource independent of query execution (not extend Operator)

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on pull request #5625:
URL: https://github.com/apache/incubator-pinot/pull/5625#issuecomment-654038189


   @mayankshriv @siddharthteotia Initially I wanted to make this PR relatively small and just add the new interfaces, but because of the current code structure, it will somehow pollute the interface (e.g. introduces the `ColumnValueReader` class to replace the current `SingleValueReader` and `MultiValueReader`), and cause confusions for the reviewers.
   I updated the PR to directly get the clean interface in one step, and addressed all the problems mentioned in the comments. The code change is much bigger, but the interface should be much cleaner, and easier to review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org