You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by gs...@apache.org on 2023/12/12 03:20:14 UTC
(lucene) branch main updated: Make TestDrillSideways#testCollectionTerminated less strict (#12920)
This is an automated email from the ASF dual-hosted git repository.
gsmiller pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/lucene.git
The following commit(s) were added to refs/heads/main by this push:
new cf13a929505 Make TestDrillSideways#testCollectionTerminated less strict (#12920)
cf13a929505 is described below
commit cf13a9295052288b748ed8f279f05ee26f3bfd5f
Author: Greg Miller <gs...@gmail.com>
AuthorDate: Mon Dec 11 19:20:08 2023 -0800
Make TestDrillSideways#testCollectionTerminated less strict (#12920)
---
lucene/CHANGES.txt | 3 +++
lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java | 4 ----
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 88087525bc9..9fc666f03b9 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -195,6 +195,9 @@ Bug Fixes
* GITHUB#12558: Ensure #finish is called on all drill-sideways FacetsCollectors even when no hits are scored.
(Greg Miller)
+* GITHUB#12920: Address bug in TestDrillSideways#testCollectionTerminated that could occasionally cause the test to
+ fail with certain random seeds. (Greg Miller)
+
Other
---------------------
diff --git a/lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java b/lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java
index 4bc20a1aeff..da4bb4f3fc5 100644
--- a/lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java
+++ b/lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java
@@ -326,10 +326,6 @@ public class TestDrillSideways extends FacetTestCase {
// termination occurs (i.e., #finish is properly called in that scenario):
assertEquals(1, baseFC.getMatchingDocs().size());
assertEquals(1, dimFC.getMatchingDocs().size());
- FacetsCollector.MatchingDocs baseMD = baseFC.getMatchingDocs().get(0);
- FacetsCollector.MatchingDocs dimMD = dimFC.getMatchingDocs().get(0);
- assertEquals(1, baseMD.totalHits);
- assertEquals(1, dimMD.totalHits);
}
}
}