You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2026/02/06 10:53:18 UTC

[PR] [fix][broker] Fix httpProxyTimeout config [pulsar]

nodece opened a new pull request, #25223:
URL: https://github.com/apache/pulsar/pull/25223

   ### Motivation
   
   #25211 improves `org.apache.pulsar.proxy.server.AdminProxyHandler#createHttpClient`.
   However, it introduced a bug: the call to `super.createHttpClient()` overrides the request timeout defined in `org.apache.pulsar.proxy.server.ProxyConfiguration#httpProxyTimeout`.
   
   ### Modifications
   
   - Move `setTimeout` logic to the `customizeHttpClient` method.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][broker] Fix httpProxyTimeout config [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #25223:
URL: https://github.com/apache/pulsar/pull/25223#issuecomment-3859852071

   Good catch @nodece! please fix checkstyle


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][broker] Fix httpProxyTimeout config [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #25223:
URL: https://github.com/apache/pulsar/pull/25223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][broker] Fix httpProxyTimeout config [pulsar]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #25223:
URL: https://github.com/apache/pulsar/pull/25223#discussion_r2773566249


##########
pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/AdminProxyHandlerTest.java:
##########
@@ -30,6 +34,7 @@
 import javax.servlet.ServletException;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
+import lombok.Cleanup;

Review Comment:
   Unused import: `Cleanup` is imported but never used in the test code. Consider removing this import to keep the code clean.
   ```suggestion
   
   ```



##########
pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/AdminProxyHandlerTest.java:
##########
@@ -20,7 +20,11 @@
 
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;

Review Comment:
   Unused imports: `times` and `verify` are imported but never used in the test code. Consider removing these imports to keep the code clean.
   ```suggestion
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org