[GitHub] [maven-shade-plugin] hboutemy commented on pull request #93: Improve and simplify ServicesResourceTransformer

[GitBox <gi...@apache.org>]

hboutemy commented on pull request #93:
URL: https://github.com/apache/maven-shade-plugin/pull/93#issuecomment-846365632


   platform dependent newline is not an issue, it's normal, even if sometimes it adds some complexity: it does not block Reproducible Builds, see https://github.com/jvm-repo-rebuild/reproducible-central where I reproduced many releases done on Windows (even if I build with a Linux Docker image)
   
   in case of shade transformer, thinking deeper at it, you are not forced to keep original newline: you can rewrite the file if you need it (and by "need", it can mean "makes your life easier"), the transformer perfectly knows the format of what it transforms, what is important is that:
   1. the output is valid
   2. the output is Reproducible, that is 2 runs give the same output (no randomness added, newline not being seen as randomness but reproducibility environment requirement = accepted constraint)
   
   so choose the strategy you wish on newline for this file: it's a local personal choice that won't affect other parts of the build where platform newline is used.
   IMHO only one choice is to be avoided: mix different newlines in one file. Even that one is a question of taste, because it does not break the 2 previous key requirements = valid + reproducible


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org