[GitHub] [arrow] pitrou commented on a diff in pull request #14556: PARQUET-2211: [C++] Print ColumnMetaData.encoding_stats field

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #14556:
URL: https://github.com/apache/arrow/pull/14556#discussion_r1014839927


##########
cpp/src/parquet/printer.cc:
##########
@@ -39,6 +39,25 @@ namespace parquet {
 
 class ColumnReader;
 
+namespace {
+
+void PrintPageEncodingStats(std::ostream& stream,
+                            const std::vector<PageEncodingStats>& encoding_stats) {
+  for (size_t i = 0; i < encoding_stats.size(); ++i) {
+    const auto& encoding = encoding_stats.at(i);
+    stream << EncodingToString(encoding.encoding);
+    if (encoding.page_type == parquet::PageType::DICTIONARY_PAGE) {
+      // Explicitly tell if this encoding comes from a dictionary page
+      stream << "(DICT_PAGE)";

Review Comment:
   Can you explain what this means? Can a dictionary encoding come from a non-dict page, or vice-versa?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org